* [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
@ 2022-09-02 7:54 ` cgel.zte
0 siblings, 0 replies; 6+ messages in thread
From: cgel.zte @ 2022-09-02 7:54 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, wenjing.liu, Zeal Robot, Xinhui.Pan,
Rodrigo.Siqueira, linux-kernel, amd-gfx,
meenakshikumar.somasundaram, airlied, Jerry.Zuo, zhang songyi,
dri-devel, daniel, alexander.deucher, hanghong.ma, Jun.Lei,
christian.koenig, Jimmy.Kizito
From: zhang songyi <zhang.songyi@zte.com.cn>
Return the enable_link_dp() directly instead of storing it in another
redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index f9b798b7933c..4ab27e231337 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
struct dc_state *state,
struct pipe_ctx *pipe_ctx)
{
- enum dc_status status;
-
- status = enable_link_dp(state, pipe_ctx);
-
- return status;
+ return enable_link_dp(state, pipe_ctx);
}
static enum dc_status enable_link_dp_mst(
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
@ 2022-09-02 7:54 ` cgel.zte
0 siblings, 0 replies; 6+ messages in thread
From: cgel.zte @ 2022-09-02 7:54 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, wenjing.liu, Zeal Robot, Xinhui.Pan,
Rodrigo.Siqueira, linux-kernel, amd-gfx,
meenakshikumar.somasundaram, airlied, Jerry.Zuo, zhang songyi,
dri-devel, alexander.deucher, hanghong.ma, Jun.Lei,
christian.koenig, Jimmy.Kizito
From: zhang songyi <zhang.songyi@zte.com.cn>
Return the enable_link_dp() directly instead of storing it in another
redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index f9b798b7933c..4ab27e231337 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
struct dc_state *state,
struct pipe_ctx *pipe_ctx)
{
- enum dc_status status;
-
- status = enable_link_dp(state, pipe_ctx);
-
- return status;
+ return enable_link_dp(state, pipe_ctx);
}
static enum dc_status enable_link_dp_mst(
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
2022-09-02 7:54 ` cgel.zte
(?)
@ 2022-09-06 15:44 ` Rodrigo Siqueira Jordao
-1 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-06 15:44 UTC (permalink / raw)
To: cgel.zte, harry.wentland
Cc: sunpeng.li, Zeal Robot, Xinhui.Pan, wenjing.liu, linux-kernel,
amd-gfx, meenakshikumar.somasundaram, airlied, Jerry.Zuo,
zhang songyi, dri-devel, alexander.deucher, hanghong.ma, Jun.Lei,
christian.koenig, Jimmy.Kizito
On 2022-09-02 03:54, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
> struct dc_state *state,
> struct pipe_ctx *pipe_ctx)
> {
> - enum dc_status status;
> -
> - status = enable_link_dp(state, pipe_ctx);
> -
> - return status;
> + return enable_link_dp(state, pipe_ctx);
> }
>
> static enum dc_status enable_link_dp_mst(
LGTM,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
@ 2022-09-06 15:44 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-06 15:44 UTC (permalink / raw)
To: cgel.zte, harry.wentland
Cc: sunpeng.li, alexander.deucher, christian.koenig, Xinhui.Pan,
airlied, daniel, wenjing.liu, Jun.Lei, Jimmy.Kizito, Jerry.Zuo,
meenakshikumar.somasundaram, hanghong.ma, amd-gfx, dri-devel,
linux-kernel, zhang songyi, Zeal Robot
On 2022-09-02 03:54, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
> struct dc_state *state,
> struct pipe_ctx *pipe_ctx)
> {
> - enum dc_status status;
> -
> - status = enable_link_dp(state, pipe_ctx);
> -
> - return status;
> + return enable_link_dp(state, pipe_ctx);
> }
>
> static enum dc_status enable_link_dp_mst(
LGTM,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable
@ 2022-09-06 15:44 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-06 15:44 UTC (permalink / raw)
To: cgel.zte, harry.wentland
Cc: sunpeng.li, Zeal Robot, Xinhui.Pan, wenjing.liu, linux-kernel,
amd-gfx, meenakshikumar.somasundaram, airlied, Jerry.Zuo,
zhang songyi, dri-devel, daniel, alexander.deucher, hanghong.ma,
Jun.Lei, christian.koenig, Jimmy.Kizito
On 2022-09-02 03:54, cgel.zte@gmail.com wrote:
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
> struct dc_state *state,
> struct pipe_ctx *pipe_ctx)
> {
> - enum dc_status status;
> -
> - status = enable_link_dp(state, pipe_ctx);
> -
> - return status;
> + return enable_link_dp(state, pipe_ctx);
> }
>
> static enum dc_status enable_link_dp_mst(
LGTM,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
and applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread