All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <t-kristo@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
	Sekhar Nori <nsekhar@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Device Tree Mailing List <devicetree@vger.kernel.org>
Subject: Re: [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: Update bindings to drop the usage of gic as parent
Date: Fri, 29 May 2020 16:43:24 +0530	[thread overview]
Message-ID: <df339bc8-f1ad-0056-b2be-9b4957cb63d8@ti.com> (raw)
In-Reply-To: <20200528221406.GA769073@bogus>

Hi Rob,

[..snip..]
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> index 1a8718f8855d..8b56b2de1c73 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> @@ -44,15 +44,17 @@ Required Properties:
>>  			4: If intr supports level triggered interrupts.
>>  - interrupt-controller:	Identifies the node as an interrupt controller
>>  - #interrupt-cells:	Specifies the number of cells needed to encode an
>> -			interrupt source. The value should be 2.
>> -			First cell should contain the TISCI device ID of source
>> -			Second cell should contain the interrupt source offset
>> -			within the device.
>> +			interrupt source. The value should be 1.
>> +			First cell should contain interrupt router input number
>> +			as specified by hardware.
>>  - ti,sci:		Phandle to TI-SCI compatible System controller node.
>> -- ti,sci-dst-id:	TISCI device ID of the destination IRQ controller.
>> -- ti,sci-rm-range-girq:	Array of TISCI subtype ids representing the host irqs
>> -			assigned to this interrupt router. Each subtype id
>> -			corresponds to a range of host irqs.
>> +- ti,sci-dev-id:	TISCI device id of interrupt controller.
>> +- ti,interrupt-ranges:	Set of triplets containing ranges that convert
>> +			the INTR output interrupt numbers to parent's
>> +			interrupt number. Each triplet has following entries:
>> +			- First entry specifies the base for intr output irq
>> +			- Second entry specifies the base for parent irqs
>> +			- Third entry specifies the limit
> 
> Humm, sounds like what interrupt-map does.

IIUC, for every irq translation there should be an entry in interrupt-map
property. These Controllers has interrupts ranging from 32, 256 and more. It
might be odd to have 256  entries in the interrupt map no? Also there are
multiple interrupt controllers which need such translations.

Thanks and regards,
Lokesh


WARNING: multiple messages have this Message-ID (diff)
From: Lokesh Vutla <lokeshvutla@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Nishanth Menon <nm@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Device Tree Mailing List <devicetree@vger.kernel.org>,
	Marc Zyngier <maz@kernel.org>, Sekhar Nori <nsekhar@ti.com>,
	Tero Kristo <t-kristo@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: Update bindings to drop the usage of gic as parent
Date: Fri, 29 May 2020 16:43:24 +0530	[thread overview]
Message-ID: <df339bc8-f1ad-0056-b2be-9b4957cb63d8@ti.com> (raw)
In-Reply-To: <20200528221406.GA769073@bogus>

Hi Rob,

[..snip..]
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> index 1a8718f8855d..8b56b2de1c73 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> @@ -44,15 +44,17 @@ Required Properties:
>>  			4: If intr supports level triggered interrupts.
>>  - interrupt-controller:	Identifies the node as an interrupt controller
>>  - #interrupt-cells:	Specifies the number of cells needed to encode an
>> -			interrupt source. The value should be 2.
>> -			First cell should contain the TISCI device ID of source
>> -			Second cell should contain the interrupt source offset
>> -			within the device.
>> +			interrupt source. The value should be 1.
>> +			First cell should contain interrupt router input number
>> +			as specified by hardware.
>>  - ti,sci:		Phandle to TI-SCI compatible System controller node.
>> -- ti,sci-dst-id:	TISCI device ID of the destination IRQ controller.
>> -- ti,sci-rm-range-girq:	Array of TISCI subtype ids representing the host irqs
>> -			assigned to this interrupt router. Each subtype id
>> -			corresponds to a range of host irqs.
>> +- ti,sci-dev-id:	TISCI device id of interrupt controller.
>> +- ti,interrupt-ranges:	Set of triplets containing ranges that convert
>> +			the INTR output interrupt numbers to parent's
>> +			interrupt number. Each triplet has following entries:
>> +			- First entry specifies the base for intr output irq
>> +			- Second entry specifies the base for parent irqs
>> +			- Third entry specifies the limit
> 
> Humm, sounds like what interrupt-map does.

IIUC, for every irq translation there should be an entry in interrupt-map
property. These Controllers has interrupts ranging from 32, 256 and more. It
might be odd to have 256  entries in the interrupt map no? Also there are
multiple interrupt controllers which need such translations.

Thanks and regards,
Lokesh


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-29 11:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 12:44 [PATCH 00/12] irqchip: ti,sci-intr/inta: Update the dt bindings to accept different interrupt parents Lokesh Vutla
2020-05-20 12:44 ` [PATCH 00/12] irqchip: ti, sci-intr/inta: " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 01/12] firmware: ti_sci: Drop the device id to resource type translation Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 02/12] firmware: ti_sci: Drop unused structure ti_sci_rm_type_map Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 03/12] firmware: ti_sci: Add support for getting resource with subtype Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: Update bindings to drop the usage of gic as parent Lokesh Vutla
2020-05-20 12:44   ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Lokesh Vutla
2020-05-28 22:14   ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Rob Herring
2020-05-28 22:14     ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Rob Herring
2020-05-29 10:14     ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Lokesh Vutla
2020-05-29 10:14       ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Lokesh Vutla
2020-05-29 10:18       ` [PATCH 04/12] dt-bindings: irqchip: ti,sci-intr: " Marc Zyngier
2020-05-29 10:18         ` [PATCH 04/12] dt-bindings: irqchip: ti, sci-intr: " Marc Zyngier
2020-06-01 11:36         ` Lokesh Vutla
2020-06-01 11:36           ` Lokesh Vutla
2020-06-15  8:03           ` Lokesh Vutla
2020-06-15  8:03             ` Lokesh Vutla
2020-06-15  8:34             ` Marc Zyngier
2020-06-15  8:34               ` Marc Zyngier
2020-07-09  9:40               ` Lokesh Vutla
2020-07-09  9:40                 ` Lokesh Vutla
2020-05-29 11:13     ` Lokesh Vutla [this message]
2020-05-29 11:13       ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 05/12] dt-bindings: irqchip: Convert ti,sci-intr bindings to yaml Lokesh Vutla
2020-05-20 12:44   ` [PATCH 05/12] dt-bindings: irqchip: Convert ti, sci-intr " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 06/12] irqchip/ti-sci-intr: Add support for INTR being a parent to INTR Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 07/12] dt-bindings: irqchip: ti,sci-inta: Update docs to support different parent Lokesh Vutla
2020-05-20 12:44   ` [PATCH 07/12] dt-bindings: irqchip: ti, sci-inta: " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 08/12] dt-bindings: irqchip: Convert ti,sci-inta bindings to yaml Lokesh Vutla
2020-05-20 12:44   ` [PATCH 08/12] dt-bindings: irqchip: Convert ti, sci-inta " Lokesh Vutla
2020-05-20 12:44 ` [PATCH 09/12] irqchip/ti-sci-inta: Add support for INTA directly connecting to GIC Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 10/12] arm64: dts: k3-j721e: ti-sci-inta/intr: Update to latest bindings Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 11/12] arm64: dts: k3-am65: " Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla
2020-05-20 12:44 ` [PATCH 12/12] arm64: dts: k3-am65: Update the RM resource types Lokesh Vutla
2020-05-20 12:44   ` Lokesh Vutla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df339bc8-f1ad-0056-b2be-9b4957cb63d8@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.