* [PATCH] glibc: fix path to place zdump in the tzcode package
@ 2021-06-17 19:06 Tony Battersby
2021-06-17 21:25 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Tony Battersby @ 2021-06-17 19:06 UTC (permalink / raw)
To: openembedded-core
zdump should be included in the tzcode package but is instead included
in the glibc-utils package due to an incorrect path in the recipe.
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14427
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
meta/recipes-core/glibc/glibc-package.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
index 8d0cc8047f..8841c5e3ca 100644
--- a/meta/recipes-core/glibc/glibc-package.inc
+++ b/meta/recipes-core/glibc/glibc-package.inc
@@ -43,7 +43,7 @@ FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
FILES_${PN}-mtrace = "${bindir}/mtrace"
-FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${sbindir}/zdump"
+FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${bindir}/zdump"
FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
FILES_catchsegv = "${bindir}/catchsegv"
RDEPENDS_catchsegv = "libsegfault"
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] glibc: fix path to place zdump in the tzcode package
2021-06-17 19:06 [PATCH] glibc: fix path to place zdump in the tzcode package Tony Battersby
@ 2021-06-17 21:25 ` Khem Raj
2021-06-17 22:16 ` Tony Battersby
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-06-17 21:25 UTC (permalink / raw)
To: Tony Battersby, openembedded-core
Thanks, I think this needs to be backported to dunfell and other
maintained releases too.
On 6/17/21 12:06 PM, Tony Battersby wrote:
> zdump should be included in the tzcode package but is instead included
> in the glibc-utils package due to an incorrect path in the recipe.
>
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=14427
>
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> ---
> meta/recipes-core/glibc/glibc-package.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
> index 8d0cc8047f..8841c5e3ca 100644
> --- a/meta/recipes-core/glibc/glibc-package.inc
> +++ b/meta/recipes-core/glibc/glibc-package.inc
> @@ -43,7 +43,7 @@ FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
> FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
> ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
> FILES_${PN}-mtrace = "${bindir}/mtrace"
> -FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${sbindir}/zdump"
> +FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${bindir}/zdump"
> FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
> FILES_catchsegv = "${bindir}/catchsegv"
> RDEPENDS_catchsegv = "libsegfault"
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] glibc: fix path to place zdump in the tzcode package
2021-06-17 21:25 ` [OE-core] " Khem Raj
@ 2021-06-17 22:16 ` Tony Battersby
2021-06-17 22:30 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Tony Battersby @ 2021-06-17 22:16 UTC (permalink / raw)
To: Khem Raj, openembedded-core
I just looked up the history to see if backporting is appropriate. This
patch should only be applied to glibc-2.33 and later. See glibc commit
b4f020c9b408fb3d1d3d4901c4a71839145f8791 ("timezone: Change zdump
installation to bin directory"). Applying the patch to glibc-2.32 and
older will introduce the bug rather than fixing it.
Tony Battersby
Cybernetics
On 6/17/21 5:25 PM, Khem Raj wrote:
> Thanks, I think this needs to be backported to dunfell and other
> maintained releases too.
>
> On 6/17/21 12:06 PM, Tony Battersby wrote:
>> zdump should be included in the tzcode package but is instead included
>> in the glibc-utils package due to an incorrect path in the recipe.
>>
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=14427
>>
>> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
>> ---
>> meta/recipes-core/glibc/glibc-package.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
>> index 8d0cc8047f..8841c5e3ca 100644
>> --- a/meta/recipes-core/glibc/glibc-package.inc
>> +++ b/meta/recipes-core/glibc/glibc-package.inc
>> @@ -43,7 +43,7 @@ FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
>> FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
>> ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
>> FILES_${PN}-mtrace = "${bindir}/mtrace"
>> -FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${sbindir}/zdump"
>> +FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${bindir}/zdump"
>> FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
>> FILES_catchsegv = "${bindir}/catchsegv"
>> RDEPENDS_catchsegv = "libsegfault"
>>
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] glibc: fix path to place zdump in the tzcode package
2021-06-17 22:16 ` Tony Battersby
@ 2021-06-17 22:30 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2021-06-17 22:30 UTC (permalink / raw)
To: Tony Battersby; +Cc: Patches and discussions about the oe-core layer
On Thu, Jun 17, 2021 at 3:16 PM Tony Battersby <tonyb@cybernetics.com> wrote:
>
> I just looked up the history to see if backporting is appropriate. This
> patch should only be applied to glibc-2.33 and later. See glibc commit
> b4f020c9b408fb3d1d3d4901c4a71839145f8791 ("timezone: Change zdump
> installation to bin directory"). Applying the patch to glibc-2.32 and
> older will introduce the bug rather than fixing it.
>
OK that makes it just hadknott then.
> Tony Battersby
> Cybernetics
>
>
> On 6/17/21 5:25 PM, Khem Raj wrote:
> > Thanks, I think this needs to be backported to dunfell and other
> > maintained releases too.
> >
> > On 6/17/21 12:06 PM, Tony Battersby wrote:
> >> zdump should be included in the tzcode package but is instead included
> >> in the glibc-utils package due to an incorrect path in the recipe.
> >>
> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=14427
> >>
> >> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> >> ---
> >> meta/recipes-core/glibc/glibc-package.inc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/glibc/glibc-package.inc b/meta/recipes-core/glibc/glibc-package.inc
> >> index 8d0cc8047f..8841c5e3ca 100644
> >> --- a/meta/recipes-core/glibc/glibc-package.inc
> >> +++ b/meta/recipes-core/glibc/glibc-package.inc
> >> @@ -43,7 +43,7 @@ FILES_${PN}-staticdev += "${libdir}/*.a ${base_libdir}/*.a"
> >> FILES_nscd = "${sbindir}/nscd* ${sysconfdir}/init.d/nscd ${systemd_unitdir}/system/nscd* ${sysconfdir}/tmpfiles.d/nscd.conf \
> >> ${sysconfdir}/nscd.conf ${sysconfdir}/default/volatiles/98_nscd ${localstatedir}/db/nscd"
> >> FILES_${PN}-mtrace = "${bindir}/mtrace"
> >> -FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${sbindir}/zdump"
> >> +FILES_tzcode = "${bindir}/tzselect ${sbindir}/zic ${bindir}/zdump"
> >> FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
> >> FILES_catchsegv = "${bindir}/catchsegv"
> >> RDEPENDS_catchsegv = "libsegfault"
> >>
> >>
> >>
> >>
> >>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-17 22:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 19:06 [PATCH] glibc: fix path to place zdump in the tzcode package Tony Battersby
2021-06-17 21:25 ` [OE-core] " Khem Raj
2021-06-17 22:16 ` Tony Battersby
2021-06-17 22:30 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.