* [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:37 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-04-12 16:37 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel
Cc: Markus Armbruster, Anthony Perard, Paul Durrant,
Stefano Stabellini, Gerd Hoffmann, Paolo Bonzini,
Philippe Mathieu-Daudé
Some VGA adapters do not contain an helpful description,
this can be confusing:
$ qemu-system-arm -M virt -vga help
none
std standard VGA
cirrus Cirrus VGA (default)
vmware VMWare SVGA
xenfb
Add a description to the missing adapters:
$ qemu-system-arm -M virt -vga help
none no graphic card
std standard VGA
cirrus Cirrus VGA (default)
vmware VMWare SVGA
xenfb Xen paravirtualized framebuffer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
---
vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vl.c b/vl.c
index 840c45c00fa..dfeda8bd7fc 100644
--- a/vl.c
+++ b/vl.c
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
[VGA_NONE] = {
.opt_name = "none",
+ .name = "no graphic card",
},
[VGA_STD] = {
.opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
},
[VGA_XENFB] = {
.opt_name = "xenfb",
+ .name = "Xen paravirtualized framebuffer",
},
};
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:37 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-04-12 16:37 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel
Cc: Stefano Stabellini, Markus Armbruster, Paul Durrant,
Gerd Hoffmann, Anthony Perard, Paolo Bonzini,
Philippe Mathieu-Daudé
Some VGA adapters do not contain an helpful description,
this can be confusing:
$ qemu-system-arm -M virt -vga help
none
std standard VGA
cirrus Cirrus VGA (default)
vmware VMWare SVGA
xenfb
Add a description to the missing adapters:
$ qemu-system-arm -M virt -vga help
none no graphic card
std standard VGA
cirrus Cirrus VGA (default)
vmware VMWare SVGA
xenfb Xen paravirtualized framebuffer
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
---
vl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/vl.c b/vl.c
index 840c45c00fa..dfeda8bd7fc 100644
--- a/vl.c
+++ b/vl.c
@@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
[VGA_NONE] = {
.opt_name = "none",
+ .name = "no graphic card",
},
[VGA_STD] = {
.opt_name = "std",
@@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
},
[VGA_XENFB] = {
.opt_name = "xenfb",
+ .name = "Xen paravirtualized framebuffer",
},
};
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:39 ` Paul Durrant
0 siblings, 0 replies; 8+ messages in thread
From: Paul Durrant @ 2019-04-12 16:39 UTC (permalink / raw)
To: 'Philippe Mathieu-Daudé',
Marc-André Lureau, qemu-devel
Cc: Markus Armbruster, Anthony Perard, Stefano Stabellini,
Gerd Hoffmann, Paolo Bonzini
> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> Sent: 12 April 2019 17:37
> To: Marc-André Lureau <marcandre.lureau@redhat.com>; qemu-devel@nongnu.org
> Cc: Markus Armbruster <armbru@redhat.com>; Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>; Gerd Hoffmann
> <kraxel@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: [PATCH] vl: Add missing descriptions to the VGA adapters list
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:39 ` Paul Durrant
0 siblings, 0 replies; 8+ messages in thread
From: Paul Durrant @ 2019-04-12 16:39 UTC (permalink / raw)
To: 'Philippe Mathieu-Daudé',
Marc-André Lureau, qemu-devel
Cc: Anthony Perard, Paolo Bonzini, Stefano Stabellini,
Markus Armbruster, Gerd Hoffmann
> -----Original Message-----
> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> Sent: 12 April 2019 17:37
> To: Marc-André Lureau <marcandre.lureau@redhat.com>; qemu-devel@nongnu.org
> Cc: Markus Armbruster <armbru@redhat.com>; Anthony Perard <anthony.perard@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>; Gerd Hoffmann
> <kraxel@redhat.com>; Paolo Bonzini <pbonzini@redhat.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
> Subject: [PATCH] vl: Add missing descriptions to the VGA adapters list
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:49 ` Marc-André Lureau
0 siblings, 0 replies; 8+ messages in thread
From: Marc-André Lureau @ 2019-04-12 16:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU, Stefano Stabellini, Markus Armbruster, Paul Durrant,
Gerd Hoffmann, Anthony Perard, Paolo Bonzini
Hi
On Fri, Apr 12, 2019 at 6:37 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
nice follow up, thanks
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
> --
> 2.20.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-12 16:49 ` Marc-André Lureau
0 siblings, 0 replies; 8+ messages in thread
From: Marc-André Lureau @ 2019-04-12 16:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Stefano Stabellini, QEMU, Markus Armbruster, Paul Durrant,
Gerd Hoffmann, Anthony Perard, Paolo Bonzini
Hi
On Fri, Apr 12, 2019 at 6:37 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
nice follow up, thanks
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
> --
> 2.20.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-16 15:18 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2019-04-16 15:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Marc-André Lureau, qemu-devel
Cc: Markus Armbruster, Anthony Perard, Paul Durrant,
Stefano Stabellini, Gerd Hoffmann
On 12/04/19 18:37, Philippe Mathieu-Daudé wrote:
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list
@ 2019-04-16 15:18 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2019-04-16 15:18 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Marc-André Lureau, qemu-devel
Cc: Anthony Perard, Paul Durrant, Stefano Stabellini,
Markus Armbruster, Gerd Hoffmann
On 12/04/19 18:37, Philippe Mathieu-Daudé wrote:
> Some VGA adapters do not contain an helpful description,
> this can be confusing:
>
> $ qemu-system-arm -M virt -vga help
> none
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb
>
> Add a description to the missing adapters:
>
> $ qemu-system-arm -M virt -vga help
> none no graphic card
> std standard VGA
> cirrus Cirrus VGA (default)
> vmware VMWare SVGA
> xenfb Xen paravirtualized framebuffer
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190412152713.16018-1-marcandre.lureau@redhat.com>
> ---
> vl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 840c45c00fa..dfeda8bd7fc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2029,6 +2029,7 @@ typedef struct VGAInterfaceInfo {
> static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> [VGA_NONE] = {
> .opt_name = "none",
> + .name = "no graphic card",
> },
> [VGA_STD] = {
> .opt_name = "std",
> @@ -2067,6 +2068,7 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = {
> },
> [VGA_XENFB] = {
> .opt_name = "xenfb",
> + .name = "Xen paravirtualized framebuffer",
> },
> };
>
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-16 15:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 16:37 [Qemu-devel] [PATCH] vl: Add missing descriptions to the VGA adapters list Philippe Mathieu-Daudé
2019-04-12 16:37 ` Philippe Mathieu-Daudé
2019-04-12 16:39 ` Paul Durrant
2019-04-12 16:39 ` Paul Durrant
2019-04-12 16:49 ` Marc-André Lureau
2019-04-12 16:49 ` Marc-André Lureau
2019-04-16 15:18 ` Paolo Bonzini
2019-04-16 15:18 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.