From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 2/7] clocksource: Add Tegra186 timers support Date: Fri, 20 Mar 2020 17:39:01 +0300 [thread overview] Message-ID: <df532fef-1533-9da7-d676-f4671746fde3@gmail.com> (raw) In-Reply-To: <20200320133452.3705040-3-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 20.03.2020 16:34, Thierry Reding пишет: > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > Currently this only supports a single watchdog, which uses a timer in > the background for countdown. Eventually the timers could be used for > various time-keeping tasks, but by default the architected timer will > already provide that functionality. > > Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > --- > drivers/clocksource/Kconfig | 8 + > drivers/clocksource/Makefile | 1 + > drivers/clocksource/timer-tegra186.c | 377 +++++++++++++++++++++++++++ > 3 files changed, 386 insertions(+) > create mode 100644 drivers/clocksource/timer-tegra186.c Hello Thierry, Shouldn't this driver reside in drivers/watchdog/? Like it's done in a case of the T30+ driver. ... > +static int __maybe_unused tegra186_timer_suspend(struct device *dev) > +{ > + return 0; > +} > + > +static int __maybe_unused tegra186_timer_resume(struct device *dev) > +{ > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(tegra186_timer_pm_ops, tegra186_timer_suspend, > + tegra186_timer_resume); Perhaps will be better to remove these OPS for now?
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de>, Rob Herring <robh+dt@kernel.org>, Jon Hunter <jonathanh@nvidia.com>, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] clocksource: Add Tegra186 timers support Date: Fri, 20 Mar 2020 17:39:01 +0300 [thread overview] Message-ID: <df532fef-1533-9da7-d676-f4671746fde3@gmail.com> (raw) In-Reply-To: <20200320133452.3705040-3-thierry.reding@gmail.com> 20.03.2020 16:34, Thierry Reding пишет: > From: Thierry Reding <treding@nvidia.com> > > Currently this only supports a single watchdog, which uses a timer in > the background for countdown. Eventually the timers could be used for > various time-keeping tasks, but by default the architected timer will > already provide that functionality. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/clocksource/Kconfig | 8 + > drivers/clocksource/Makefile | 1 + > drivers/clocksource/timer-tegra186.c | 377 +++++++++++++++++++++++++++ > 3 files changed, 386 insertions(+) > create mode 100644 drivers/clocksource/timer-tegra186.c Hello Thierry, Shouldn't this driver reside in drivers/watchdog/? Like it's done in a case of the T30+ driver. ... > +static int __maybe_unused tegra186_timer_suspend(struct device *dev) > +{ > + return 0; > +} > + > +static int __maybe_unused tegra186_timer_resume(struct device *dev) > +{ > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(tegra186_timer_pm_ops, tegra186_timer_suspend, > + tegra186_timer_resume); Perhaps will be better to remove these OPS for now?
next prev parent reply other threads:[~2020-03-20 14:39 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-20 13:34 [PATCH 0/7] clocksource: Add NVIDIA Tegra186 timers support Thierry Reding 2020-03-20 13:34 ` Thierry Reding [not found] ` <20200320133452.3705040-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-20 13:34 ` [PATCH 1/7] dt-bindings: timer: Add bindings for NVIDIA Tegra186 timers Thierry Reding 2020-03-20 13:34 ` Thierry Reding [not found] ` <20200320133452.3705040-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-30 23:28 ` Rob Herring 2020-03-30 23:28 ` Rob Herring 2020-03-20 13:34 ` [PATCH 2/7] clocksource: Add Tegra186 timers support Thierry Reding 2020-03-20 13:34 ` Thierry Reding [not found] ` <20200320133452.3705040-3-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-20 14:39 ` Dmitry Osipenko [this message] 2020-03-20 14:39 ` Dmitry Osipenko 2020-03-20 15:04 ` Thierry Reding 2020-03-20 15:23 ` Dmitry Osipenko 2020-03-20 15:23 ` Dmitry Osipenko 2020-03-23 13:38 ` Thierry Reding [not found] ` <5a559950-0497-b24f-6484-c2513375fe62-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-31 20:04 ` Thierry Reding 2020-03-31 20:04 ` Thierry Reding 2020-03-20 15:11 ` Dmitry Osipenko 2020-03-20 15:11 ` Dmitry Osipenko [not found] ` <48b2099c-dd83-d4dc-aab4-8c6f68a215cf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-20 15:38 ` Dmitry Osipenko 2020-03-20 15:38 ` Dmitry Osipenko [not found] ` <da2a0501-664a-c5d0-7b13-174e5347eaf7-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-23 13:42 ` Thierry Reding 2020-03-23 13:42 ` Thierry Reding 2020-03-23 13:45 ` Dmitry Osipenko 2020-03-23 16:10 ` Dmitry Osipenko [not found] ` <b3859b98-02a3-d197-735c-2c9a9fbe597c-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-03-31 19:58 ` Thierry Reding 2020-03-31 19:58 ` Thierry Reding 2020-03-20 13:34 ` [PATCH 3/7] arm64: tegra: Order nodes by unit-address on Tegra194 Thierry Reding 2020-03-20 13:34 ` Thierry Reding 2020-03-20 13:34 ` [PATCH 4/7] arm64: tegra: Add native timer support on Tegra186 Thierry Reding 2020-03-20 13:34 ` Thierry Reding 2020-03-20 13:34 ` [PATCH 6/7] arm64: tegra: Add native timer support on Tegra194 Thierry Reding 2020-03-20 13:34 ` Thierry Reding 2020-03-20 13:34 ` [PATCH 7/7] arm64: tegra: Enable native timers on Jetson AGX Xavier Thierry Reding 2020-03-20 13:34 ` Thierry Reding 2020-03-20 13:34 ` [PATCH 5/7] arm64: tegra: Enable native timers on Jetson TX2 Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=df532fef-1533-9da7-d676-f4671746fde3@gmail.com \ --to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.