* [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq()
@ 2018-07-20 9:29 Zhenzhong Duan
2018-07-20 10:13 ` Roger Pau Monné
0 siblings, 1 reply; 4+ messages in thread
From: Zhenzhong Duan @ 2018-07-20 9:29 UTC (permalink / raw)
To: Xen-Devel; +Cc: andrew.cooper3, jbeulich, roger.pau
No functional change.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
xen/arch/x86/irq.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index 87ef2e8..5253fd1 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -2701,8 +2701,6 @@ int allocate_and_map_msi_pirq(struct domain *d, int index, int *pirq_p,
return -EINVAL;
}
- msi->irq = irq;
-
pcidevs_lock();
/* Verify or get pirq. */
spin_lock(&d->event_lock);
--
1.7.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq()
2018-07-20 9:29 [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq() Zhenzhong Duan
@ 2018-07-20 10:13 ` Roger Pau Monné
2018-07-20 10:13 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Roger Pau Monné @ 2018-07-20 10:13 UTC (permalink / raw)
To: Zhenzhong Duan; +Cc: andrew.cooper3, jbeulich, Xen-Devel
On Fri, Jul 20, 2018 at 02:29:34AM -0700, Zhenzhong Duan wrote:
> No functional change.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> ---
> xen/arch/x86/irq.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> index 87ef2e8..5253fd1 100644
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -2701,8 +2701,6 @@ int allocate_and_map_msi_pirq(struct domain *d, int index, int *pirq_p,
> return -EINVAL;
> }
>
> - msi->irq = irq;
I would prefer to remove the assignment in the MAP_PIRQ_TYPE_MULTI_MSI
case rather than here. IMO this one makes it clearer that msi->irq is
always set. In any case:
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq()
2018-07-20 10:13 ` Roger Pau Monné
@ 2018-07-20 10:13 ` Andrew Cooper
2018-07-23 3:39 ` Zhenzhong Duan
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cooper @ 2018-07-20 10:13 UTC (permalink / raw)
To: Roger Pau Monné, Zhenzhong Duan; +Cc: jbeulich, Xen-Devel
On 20/07/18 11:13, Roger Pau Monné wrote:
> On Fri, Jul 20, 2018 at 02:29:34AM -0700, Zhenzhong Duan wrote:
>> No functional change.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>> ---
>> xen/arch/x86/irq.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
>> index 87ef2e8..5253fd1 100644
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -2701,8 +2701,6 @@ int allocate_and_map_msi_pirq(struct domain *d, int index, int *pirq_p,
>> return -EINVAL;
>> }
>>
>> - msi->irq = irq;
> I would prefer to remove the assignment in the MAP_PIRQ_TYPE_MULTI_MSI
> case rather than here. IMO this one makes it clearer that msi->irq is
> always set.
Me too. I can fix this up on commit.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq()
2018-07-20 10:13 ` Andrew Cooper
@ 2018-07-23 3:39 ` Zhenzhong Duan
0 siblings, 0 replies; 4+ messages in thread
From: Zhenzhong Duan @ 2018-07-23 3:39 UTC (permalink / raw)
To: Andrew Cooper, Roger Pau Monné; +Cc: Srinivas Eeda, jbeulich, Xen-Devel
在 2018/7/20 18:13, Andrew Cooper 写道:
> On 20/07/18 11:13, Roger Pau Monné wrote:
>> On Fri, Jul 20, 2018 at 02:29:34AM -0700, Zhenzhong Duan wrote:
>>> No functional change.
>>>
>>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>>> ---
>>> xen/arch/x86/irq.c | 2 --
>>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
>>> index 87ef2e8..5253fd1 100644
>>> --- a/xen/arch/x86/irq.c
>>> +++ b/xen/arch/x86/irq.c
>>> @@ -2701,8 +2701,6 @@ int allocate_and_map_msi_pirq(struct domain *d, int index, int *pirq_p,
>>> return -EINVAL;
>>> }
>>>
>>> - msi->irq = irq;
>> I would prefer to remove the assignment in the MAP_PIRQ_TYPE_MULTI_MSI
>> case rather than here. IMO this one makes it clearer that msi->irq is
>> always set.
>
> Me too. I can fix this up on commit.
Sure, go ahead, thanks Roger, Andrew for review.
Regards
Zhenzhong
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-23 3:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 9:29 [PATCH] x86/physdev: Remove redundant assignment in allocate_and_map_msi_pirq() Zhenzhong Duan
2018-07-20 10:13 ` Roger Pau Monné
2018-07-20 10:13 ` Andrew Cooper
2018-07-23 3:39 ` Zhenzhong Duan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.