* [PATCH v2] objtool: Move objtool_file struct off the stack
@ 2019-03-19 0:09 Josh Poimboeuf
2019-03-21 11:07 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
0 siblings, 1 reply; 2+ messages in thread
From: Josh Poimboeuf @ 2019-03-19 0:09 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, Peter Zijlstra, moosotc
Objtool uses over 512k of stack, thanks to the hash table embedded in
the objtool_file struct. This causes an unnecessarily large stack
allocation and breaks users with low stack limits.
Move the struct off the stack.
Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
Reported-by: Vassili Karpov <moosotc@gmail.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/check.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0414a0d52262..5dde107083c6 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2184,9 +2184,10 @@ static void cleanup(struct objtool_file *file)
elf_close(file->elf);
}
+static struct objtool_file file;
+
int check(const char *_objname, bool orc)
{
- struct objtool_file file;
int ret, warnings = 0;
objname = _objname;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:core/urgent] objtool: Move objtool_file struct off the stack
2019-03-19 0:09 [PATCH v2] objtool: Move objtool_file struct off the stack Josh Poimboeuf
@ 2019-03-21 11:07 ` tip-bot for Josh Poimboeuf
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Josh Poimboeuf @ 2019-03-21 11:07 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, hpa, peterz, linux-kernel, tglx, moosotc, jpoimboe
Commit-ID: 0c671812f152b628bd87c0af49da032cc2a2c319
Gitweb: https://git.kernel.org/tip/0c671812f152b628bd87c0af49da032cc2a2c319
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Mon, 18 Mar 2019 19:09:38 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 21 Mar 2019 12:02:19 +0100
objtool: Move objtool_file struct off the stack
Objtool uses over 512k of stack, thanks to the hash table embedded in
the objtool_file struct. This causes an unnecessarily large stack
allocation and breaks users with low stack limits.
Move the struct off the stack.
Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
Reported-by: Vassili Karpov <moosotc@gmail.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/df92dcbc4b84b02ffa252f46876df125fb56e2d7.1552954176.git.jpoimboe@redhat.com
---
tools/objtool/check.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0414a0d52262..5dde107083c6 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2184,9 +2184,10 @@ static void cleanup(struct objtool_file *file)
elf_close(file->elf);
}
+static struct objtool_file file;
+
int check(const char *_objname, bool orc)
{
- struct objtool_file file;
int ret, warnings = 0;
objname = _objname;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 11:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 0:09 [PATCH v2] objtool: Move objtool_file struct off the stack Josh Poimboeuf
2019-03-21 11:07 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.