* [PATCH] hostmem: don't use mbind() if host-nodes is epmty
@ 2020-04-30 15:46 Igor Mammedov
2020-04-30 16:42 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Igor Mammedov @ 2020-04-30 15:46 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, mhohmann, berrange, ehabkost, qemu-stable
Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
The backend however calls mbind() which is typically NOP
in case of default policy/absent host-nodes bitmap.
However when runing in container with black-listed mbind()
syscall, QEMU fails to start with error
"cannot bind memory to host NUMA nodes: Operation not permitted"
even when user hasn't provided host-nodes to pin to explictly
(which is the case with -m option)
To fix issue, call mbind() only in case when user has provided
host-nodes explicitly (i.e. host_nodes bitmap is not empty).
That should allow to run QEMU in containers with black-listed
mbind() without memory pinning. If QEMU provided memory-pinning
is required user still has to white-list mbind() in container
configuration.
Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
CC: berrange@redhat.com
CC: ehabkost@redhat.com
CC: pbonzini@redhat.com
CC: mhohmann@physnet.uni-hamburg.de
CC: qemu-stable@nongnu.org
---
backends/hostmem.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 327f9eebc3..0efd7b7bd6 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
assert(sizeof(backend->host_nodes) >=
BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long));
assert(maxnode <= MAX_NODES);
- if (mbind(ptr, sz, backend->policy,
- maxnode ? backend->host_nodes : NULL, maxnode + 1, flags)) {
+
+ if (maxnode &&
+ mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode + 1,
+ flags)) {
if (backend->policy != MPOL_DEFAULT || errno != ENOSYS) {
error_setg_errno(errp, errno,
"cannot bind memory to host NUMA nodes");
--
2.18.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-04-30 15:46 [PATCH] hostmem: don't use mbind() if host-nodes is epmty Igor Mammedov
@ 2020-04-30 16:42 ` Philippe Mathieu-Daudé
2020-05-01 7:28 ` Manuel Hohmann
2020-05-01 8:57 ` Daniel P. Berrangé
2020-05-04 15:44 ` Eduardo Habkost
2 siblings, 1 reply; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-30 16:42 UTC (permalink / raw)
To: Igor Mammedov, qemu-devel
Cc: pbonzini, mhohmann, berrange, ehabkost, qemu-stable
Typo "empty" in patch subject.
On 4/30/20 5:46 PM, Igor Mammedov wrote:
> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
> The backend however calls mbind() which is typically NOP
> in case of default policy/absent host-nodes bitmap.
> However when runing in container with black-listed mbind()
> syscall, QEMU fails to start with error
> "cannot bind memory to host NUMA nodes: Operation not permitted"
> even when user hasn't provided host-nodes to pin to explictly
> (which is the case with -m option)
>
> To fix issue, call mbind() only in case when user has provided
> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
> That should allow to run QEMU in containers with black-listed
> mbind() without memory pinning. If QEMU provided memory-pinning
> is required user still has to white-list mbind() in container
> configuration.
>
> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: berrange@redhat.com
> CC: ehabkost@redhat.com
> CC: pbonzini@redhat.com
> CC: mhohmann@physnet.uni-hamburg.de
> CC: qemu-stable@nongnu.org
> ---
> backends/hostmem.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/backends/hostmem.c b/backends/hostmem.c
> index 327f9eebc3..0efd7b7bd6 100644
> --- a/backends/hostmem.c
> +++ b/backends/hostmem.c
> @@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
> assert(sizeof(backend->host_nodes) >=
> BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long));
> assert(maxnode <= MAX_NODES);
> - if (mbind(ptr, sz, backend->policy,
> - maxnode ? backend->host_nodes : NULL, maxnode + 1, flags)) {
> +
> + if (maxnode &&
> + mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode + 1,
> + flags)) {
> if (backend->policy != MPOL_DEFAULT || errno != ENOSYS) {
> error_setg_errno(errp, errno,
> "cannot bind memory to host NUMA nodes");
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-04-30 16:42 ` Philippe Mathieu-Daudé
@ 2020-05-01 7:28 ` Manuel Hohmann
0 siblings, 0 replies; 9+ messages in thread
From: Manuel Hohmann @ 2020-05-01 7:28 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Igor Mammedov, qemu-devel
Cc: pbonzini, berrange, ehabkost, qemu-stable
[-- Attachment #1.1: Type: text/plain, Size: 2813 bytes --]
Thanks! I applied the patch, and now it works also inside the docker container, for all architectures (i386, x86_64, arm, aarch64) for which I have test cases at hand.
Indeed, since the container is configured by a public cloud service, there is no possibility to change any security settings. Disabling mbind unless explicitly requested seems to be the best way to go here.
On 30.04.20 19:42, Philippe Mathieu-Daudé wrote:
> Typo "empty" in patch subject.
>
> On 4/30/20 5:46 PM, Igor Mammedov wrote:
>> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
>> The backend however calls mbind() which is typically NOP
>> in case of default policy/absent host-nodes bitmap.
>> However when runing in container with black-listed mbind()
>> syscall, QEMU fails to start with error
>> "cannot bind memory to host NUMA nodes: Operation not permitted"
>> even when user hasn't provided host-nodes to pin to explictly
>> (which is the case with -m option)
>>
>> To fix issue, call mbind() only in case when user has provided
>> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
>> That should allow to run QEMU in containers with black-listed
>> mbind() without memory pinning. If QEMU provided memory-pinning
>> is required user still has to white-list mbind() in container
>> configuration.
>>
>> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>> CC: berrange@redhat.com
>> CC: ehabkost@redhat.com
>> CC: pbonzini@redhat.com
>> CC: mhohmann@physnet.uni-hamburg.de
>> CC: qemu-stable@nongnu.org
>> ---
>> backends/hostmem.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/backends/hostmem.c b/backends/hostmem.c
>> index 327f9eebc3..0efd7b7bd6 100644
>> --- a/backends/hostmem.c
>> +++ b/backends/hostmem.c
>> @@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
>> assert(sizeof(backend->host_nodes) >=
>> BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long));
>> assert(maxnode <= MAX_NODES);
>> - if (mbind(ptr, sz, backend->policy,
>> - maxnode ? backend->host_nodes : NULL, maxnode + 1, flags)) {
>> +
>> + if (maxnode &&
>> + mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode + 1,
>> + flags)) {
>> if (backend->policy != MPOL_DEFAULT || errno != ENOSYS) {
>> error_setg_errno(errp, errno,
>> "cannot bind memory to host NUMA nodes");
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-04-30 15:46 [PATCH] hostmem: don't use mbind() if host-nodes is epmty Igor Mammedov
2020-04-30 16:42 ` Philippe Mathieu-Daudé
@ 2020-05-01 8:57 ` Daniel P. Berrangé
2020-05-04 14:31 ` Philippe Mathieu-Daudé
2020-05-04 15:44 ` Eduardo Habkost
2 siblings, 1 reply; 9+ messages in thread
From: Daniel P. Berrangé @ 2020-05-01 8:57 UTC (permalink / raw)
To: Igor Mammedov; +Cc: pbonzini, mhohmann, qemu-stable, qemu-devel, ehabkost
On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
> The backend however calls mbind() which is typically NOP
> in case of default policy/absent host-nodes bitmap.
> However when runing in container with black-listed mbind()
> syscall, QEMU fails to start with error
> "cannot bind memory to host NUMA nodes: Operation not permitted"
> even when user hasn't provided host-nodes to pin to explictly
> (which is the case with -m option)
>
> To fix issue, call mbind() only in case when user has provided
> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
> That should allow to run QEMU in containers with black-listed
> mbind() without memory pinning. If QEMU provided memory-pinning
> is required user still has to white-list mbind() in container
> configuration.
>
> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CC: berrange@redhat.com
> CC: ehabkost@redhat.com
> CC: pbonzini@redhat.com
> CC: mhohmann@physnet.uni-hamburg.de
> CC: qemu-stable@nongnu.org
> ---
> backends/hostmem.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/backends/hostmem.c b/backends/hostmem.c
> index 327f9eebc3..0efd7b7bd6 100644
> --- a/backends/hostmem.c
> +++ b/backends/hostmem.c
> @@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
> assert(sizeof(backend->host_nodes) >=
> BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long));
> assert(maxnode <= MAX_NODES);
> - if (mbind(ptr, sz, backend->policy,
> - maxnode ? backend->host_nodes : NULL, maxnode + 1, flags)) {
> +
> + if (maxnode &&
> + mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode + 1,
> + flags)) {
> if (backend->policy != MPOL_DEFAULT || errno != ENOSYS) {
> error_setg_errno(errp, errno,
> "cannot bind memory to host NUMA nodes");
personally I would have found this code clearer if the
check had been "if (backend->policy != MPOL_DEFAULT && ..."
as I had to read quite a few lines to understand that the
'maxnode' is zero if-and-only-if policy == MPOL_DEFAULT
Regardless though, this is functionally correct so
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-05-01 8:57 ` Daniel P. Berrangé
@ 2020-05-04 14:31 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-04 14:31 UTC (permalink / raw)
To: Daniel P. Berrangé, Igor Mammedov
Cc: pbonzini, mhohmann, qemu-stable, ehabkost, qemu-devel
On 5/1/20 10:57 AM, Daniel P. Berrangé wrote:
> On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
>> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
>> The backend however calls mbind() which is typically NOP
>> in case of default policy/absent host-nodes bitmap.
>> However when runing in container with black-listed mbind()
>> syscall, QEMU fails to start with error
>> "cannot bind memory to host NUMA nodes: Operation not permitted"
>> even when user hasn't provided host-nodes to pin to explictly
>> (which is the case with -m option)
>>
>> To fix issue, call mbind() only in case when user has provided
>> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
>> That should allow to run QEMU in containers with black-listed
>> mbind() without memory pinning. If QEMU provided memory-pinning
>> is required user still has to white-list mbind() in container
>> configuration.
>>
>> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> ---
>> CC: berrange@redhat.com
>> CC: ehabkost@redhat.com
>> CC: pbonzini@redhat.com
>> CC: mhohmann@physnet.uni-hamburg.de
>> CC: qemu-stable@nongnu.org
>> ---
>> backends/hostmem.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/backends/hostmem.c b/backends/hostmem.c
>> index 327f9eebc3..0efd7b7bd6 100644
>> --- a/backends/hostmem.c
>> +++ b/backends/hostmem.c
>> @@ -383,8 +383,10 @@ host_memory_backend_memory_complete(UserCreatable *uc, Error **errp)
>> assert(sizeof(backend->host_nodes) >=
>> BITS_TO_LONGS(MAX_NODES + 1) * sizeof(unsigned long));
>> assert(maxnode <= MAX_NODES);
>> - if (mbind(ptr, sz, backend->policy,
>> - maxnode ? backend->host_nodes : NULL, maxnode + 1, flags)) {
>> +
>> + if (maxnode &&
>> + mbind(ptr, sz, backend->policy, backend->host_nodes, maxnode + 1,
>> + flags)) {
>> if (backend->policy != MPOL_DEFAULT || errno != ENOSYS) {
>> error_setg_errno(errp, errno,
>> "cannot bind memory to host NUMA nodes");
>
> personally I would have found this code clearer if the
> check had been "if (backend->policy != MPOL_DEFAULT && ..."
> as I had to read quite a few lines to understand that the
> 'maxnode' is zero if-and-only-if policy == MPOL_DEFAULT
>
> Regardless though, this is functionally correct so
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
I could reproduce running 'make check-qtest-hppa' on the qemu:fedora image:
TEST check-qtest-hppa: tests/qtest/boot-serial-test
qemu-system-hppa: cannot bind memory to host NUMA nodes: Operation not
permitted
Broken pipe
tests/qtest/libqtest.c:166: kill_qemu() tried to terminate QEMU process
but encountered exit status 1 (expected 0)
ERROR - too few tests run (expected 1, got 0)
make: *** [tests/Makefile.include:637: check-qtest-hppa] Error 1
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Regards,
> Daniel
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-04-30 15:46 [PATCH] hostmem: don't use mbind() if host-nodes is epmty Igor Mammedov
2020-04-30 16:42 ` Philippe Mathieu-Daudé
2020-05-01 8:57 ` Daniel P. Berrangé
@ 2020-05-04 15:44 ` Eduardo Habkost
2020-05-11 16:00 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 9+ messages in thread
From: Eduardo Habkost @ 2020-05-04 15:44 UTC (permalink / raw)
To: Igor Mammedov; +Cc: pbonzini, mhohmann, berrange, qemu-devel, qemu-stable
On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
> The backend however calls mbind() which is typically NOP
> in case of default policy/absent host-nodes bitmap.
> However when runing in container with black-listed mbind()
> syscall, QEMU fails to start with error
> "cannot bind memory to host NUMA nodes: Operation not permitted"
> even when user hasn't provided host-nodes to pin to explictly
> (which is the case with -m option)
>
> To fix issue, call mbind() only in case when user has provided
> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
> That should allow to run QEMU in containers with black-listed
> mbind() without memory pinning. If QEMU provided memory-pinning
> is required user still has to white-list mbind() in container
> configuration.
>
> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Queued on machine-next, thanks!
--
Eduardo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-05-04 15:44 ` Eduardo Habkost
@ 2020-05-11 16:00 ` Philippe Mathieu-Daudé
2020-05-11 19:24 ` Igor Mammedov
0 siblings, 1 reply; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-11 16:00 UTC (permalink / raw)
To: Eduardo Habkost, Igor Mammedov
Cc: pbonzini, mhohmann, berrange, qemu-devel, qemu-stable
Hi Eduardo,
On 5/4/20 5:44 PM, Eduardo Habkost wrote:
> On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
>> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
>> The backend however calls mbind() which is typically NOP
>> in case of default policy/absent host-nodes bitmap.
>> However when runing in container with black-listed mbind()
>> syscall, QEMU fails to start with error
>> "cannot bind memory to host NUMA nodes: Operation not permitted"
>> even when user hasn't provided host-nodes to pin to explictly
>> (which is the case with -m option)
>>
>> To fix issue, call mbind() only in case when user has provided
>> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
>> That should allow to run QEMU in containers with black-listed
>> mbind() without memory pinning. If QEMU provided memory-pinning
>> is required user still has to white-list mbind() in container
>> configuration.
>>
>> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Queued on machine-next, thanks!
I've been debugging this issue again today and figured it was not
merged, if possible can you add the "Cc: qemu-stable@nongnu.org" tag
before sending your pull request?
Thanks,
Phil.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-05-11 16:00 ` Philippe Mathieu-Daudé
@ 2020-05-11 19:24 ` Igor Mammedov
2020-05-11 20:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 9+ messages in thread
From: Igor Mammedov @ 2020-05-11 19:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: berrange, Eduardo Habkost, qemu-stable, qemu-devel, mhohmann, pbonzini
On Mon, 11 May 2020 18:00:01 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Hi Eduardo,
>
> On 5/4/20 5:44 PM, Eduardo Habkost wrote:
> > On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
> >> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
> >> The backend however calls mbind() which is typically NOP
> >> in case of default policy/absent host-nodes bitmap.
> >> However when runing in container with black-listed mbind()
> >> syscall, QEMU fails to start with error
> >> "cannot bind memory to host NUMA nodes: Operation not permitted"
> >> even when user hasn't provided host-nodes to pin to explictly
> >> (which is the case with -m option)
> >>
> >> To fix issue, call mbind() only in case when user has provided
> >> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
> >> That should allow to run QEMU in containers with black-listed
> >> mbind() without memory pinning. If QEMU provided memory-pinning
> >> is required user still has to white-list mbind() in container
> >> configuration.
> >>
> >> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
> >> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Queued on machine-next, thanks!
>
> I've been debugging this issue again today and figured it was not
> merged, if possible can you add the "Cc: qemu-stable@nongnu.org" tag
> before sending your pull request?
it's CCed already, so my impression was that will should picked up once it was reviewed.
>
> Thanks,
>
> Phil.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty
2020-05-11 19:24 ` Igor Mammedov
@ 2020-05-11 20:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-11 20:03 UTC (permalink / raw)
To: Igor Mammedov
Cc: berrange, Eduardo Habkost, qemu-stable, qemu-devel, mhohmann, pbonzini
On 5/11/20 9:24 PM, Igor Mammedov wrote:
> On Mon, 11 May 2020 18:00:01 +0200
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
>> Hi Eduardo,
>>
>> On 5/4/20 5:44 PM, Eduardo Habkost wrote:
>>> On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote:
>>>> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM.
>>>> The backend however calls mbind() which is typically NOP
>>>> in case of default policy/absent host-nodes bitmap.
>>>> However when runing in container with black-listed mbind()
>>>> syscall, QEMU fails to start with error
>>>> "cannot bind memory to host NUMA nodes: Operation not permitted"
>>>> even when user hasn't provided host-nodes to pin to explictly
>>>> (which is the case with -m option)
>>>>
>>>> To fix issue, call mbind() only in case when user has provided
>>>> host-nodes explicitly (i.e. host_nodes bitmap is not empty).
>>>> That should allow to run QEMU in containers with black-listed
>>>> mbind() without memory pinning. If QEMU provided memory-pinning
>>>> is required user still has to white-list mbind() in container
>>>> configuration.
>>>>
>>>> Reported-by: Manuel Hohmann <mhohmann@physnet.uni-hamburg.de>
>>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>>
>>> Queued on machine-next, thanks!
>>
>> I've been debugging this issue again today and figured it was not
>> merged, if possible can you add the "Cc: qemu-stable@nongnu.org" tag
>> before sending your pull request?
> it's CCed already, so my impression was that will should picked up once it was reviewed.
Correct, however some distributions find easier to grep for the 'Cc:
qemu-stable@nongnu.org' merged tag before qemu-stable is released.
>
>>
>> Thanks,
>>
>> Phil.
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-11 20:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 15:46 [PATCH] hostmem: don't use mbind() if host-nodes is epmty Igor Mammedov
2020-04-30 16:42 ` Philippe Mathieu-Daudé
2020-05-01 7:28 ` Manuel Hohmann
2020-05-01 8:57 ` Daniel P. Berrangé
2020-05-04 14:31 ` Philippe Mathieu-Daudé
2020-05-04 15:44 ` Eduardo Habkost
2020-05-11 16:00 ` Philippe Mathieu-Daudé
2020-05-11 19:24 ` Igor Mammedov
2020-05-11 20:03 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.