All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
@ 2019-04-24  7:53 ` Yue Haibing
  0 siblings, 0 replies; 8+ messages in thread
From: Yue Haibing @ 2019-04-24  7:53 UTC (permalink / raw)
  To: herbert, davem, nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: linux-kernel, linux-arm-kernel, linux-crypto, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]

It is not used any more since
commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/crypto/atmel-tdes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 12492d9..fa76620 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
 			   unsigned int keylen)
 {
 	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
-	const char *alg_name;
 	u32 flags;
 	int err;
 
-	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
-
 	flags = crypto_ablkcipher_get_flags(tfm);
 	err = __des3_verify_key(&flags, key);
 	if (unlikely(err)) {
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
@ 2019-04-24  7:53 ` Yue Haibing
  0 siblings, 0 replies; 8+ messages in thread
From: Yue Haibing @ 2019-04-24  7:53 UTC (permalink / raw)
  To: herbert, davem, nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: YueHaibing, linux-kernel, linux-arm-kernel, linux-crypto

From: YueHaibing <yuehaibing@huawei.com>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]

It is not used any more since
commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/crypto/atmel-tdes.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 12492d9..fa76620 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
 			   unsigned int keylen)
 {
 	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
-	const char *alg_name;
 	u32 flags;
 	int err;
 
-	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
-
 	flags = crypto_ablkcipher_get_flags(tfm);
 	err = __des3_verify_key(&flags, key);
 	if (unlikely(err)) {
-- 
2.7.4



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
  2019-04-24  7:53 ` Yue Haibing
@ 2019-04-24  8:55   ` Nicolas.Ferre
  -1 siblings, 0 replies; 8+ messages in thread
From: Nicolas.Ferre @ 2019-04-24  8:55 UTC (permalink / raw)
  To: yuehaibing, herbert, davem, alexandre.belloni, Ludovic.Desroches,
	Tudor.Ambarus
  Cc: linux-kernel, linux-arm-kernel, linux-crypto

On 24/04/2019 at 09:53, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Looks good to me:
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/crypto/atmel-tdes.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 12492d9..fa76620 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
>   			   unsigned int keylen)
>   {
>   	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
> -	const char *alg_name;
>   	u32 flags;
>   	int err;
>   
> -	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
> -
>   	flags = crypto_ablkcipher_get_flags(tfm);
>   	err = __des3_verify_key(&flags, key);
>   	if (unlikely(err)) {
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
@ 2019-04-24  8:55   ` Nicolas.Ferre
  0 siblings, 0 replies; 8+ messages in thread
From: Nicolas.Ferre @ 2019-04-24  8:55 UTC (permalink / raw)
  To: yuehaibing, herbert, davem, alexandre.belloni, Ludovic.Desroches,
	Tudor.Ambarus
  Cc: linux-kernel, linux-arm-kernel, linux-crypto

On 24/04/2019 at 09:53, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Looks good to me:
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   drivers/crypto/atmel-tdes.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 12492d9..fa76620 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
>   			   unsigned int keylen)
>   {
>   	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
> -	const char *alg_name;
>   	u32 flags;
>   	int err;
>   
> -	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
> -
>   	flags = crypto_ablkcipher_get_flags(tfm);
>   	err = __des3_verify_key(&flags, key);
>   	if (unlikely(err)) {
> 


-- 
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
  2019-04-24  7:53 ` Yue Haibing
@ 2019-04-25  7:18   ` Tudor.Ambarus
  -1 siblings, 0 replies; 8+ messages in thread
From: Tudor.Ambarus @ 2019-04-25  7:18 UTC (permalink / raw)
  To: yuehaibing, herbert, davem, Nicolas.Ferre, alexandre.belloni,
	Ludovic.Desroches
  Cc: linux-kernel, linux-arm-kernel, linux-crypto



On 04/24/2019 10:53 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/crypto/atmel-tdes.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 12492d9..fa76620 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
>  			   unsigned int keylen)
>  {
>  	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
> -	const char *alg_name;
>  	u32 flags;
>  	int err;
>  
> -	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
> -
>  	flags = crypto_ablkcipher_get_flags(tfm);
>  	err = __des3_verify_key(&flags, key);
>  	if (unlikely(err)) {
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
@ 2019-04-25  7:18   ` Tudor.Ambarus
  0 siblings, 0 replies; 8+ messages in thread
From: Tudor.Ambarus @ 2019-04-25  7:18 UTC (permalink / raw)
  To: yuehaibing, herbert, davem, Nicolas.Ferre, alexandre.belloni,
	Ludovic.Desroches
  Cc: linux-kernel, linux-arm-kernel, linux-crypto



On 04/24/2019 10:53 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/crypto/atmel-tdes.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 12492d9..fa76620 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -800,12 +800,9 @@ static int atmel_tdes_setkey(struct crypto_ablkcipher *tfm, const u8 *key,
>  			   unsigned int keylen)
>  {
>  	struct atmel_tdes_ctx *ctx = crypto_ablkcipher_ctx(tfm);
> -	const char *alg_name;
>  	u32 flags;
>  	int err;
>  
> -	alg_name = crypto_tfm_alg_name(crypto_ablkcipher_tfm(tfm));
> -
>  	flags = crypto_ablkcipher_get_flags(tfm);
>  	err = __des3_verify_key(&flags, key);
>  	if (unlikely(err)) {
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
  2019-04-24  7:53 ` Yue Haibing
@ 2019-05-03  6:09   ` Herbert Xu
  -1 siblings, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2019-05-03  6:09 UTC (permalink / raw)
  To: Yue Haibing
  Cc: davem, nicolas.ferre, alexandre.belloni, ludovic.desroches,
	linux-kernel, linux-arm-kernel, linux-crypto

On Wed, Apr 24, 2019 at 03:53:52PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/crypto/atmel-tdes.c | 3 ---
>  1 file changed, 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'
@ 2019-05-03  6:09   ` Herbert Xu
  0 siblings, 0 replies; 8+ messages in thread
From: Herbert Xu @ 2019-05-03  6:09 UTC (permalink / raw)
  To: Yue Haibing
  Cc: alexandre.belloni, linux-kernel, ludovic.desroches, linux-crypto,
	davem, linux-arm-kernel

On Wed, Apr 24, 2019 at 03:53:52PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey':
> drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not used [-Wunused-but-set-variable]
> 
> It is not used any more since
> commit 52ea3cd2917b ("crypto: atmel - Forbid 2-key 3DES in FIPS mode")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/crypto/atmel-tdes.c | 3 ---
>  1 file changed, 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-03 13:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24  7:53 [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name' Yue Haibing
2019-04-24  7:53 ` Yue Haibing
2019-04-24  8:55 ` Nicolas.Ferre
2019-04-24  8:55   ` Nicolas.Ferre
2019-04-25  7:18 ` Tudor.Ambarus
2019-04-25  7:18   ` Tudor.Ambarus
2019-05-03  6:09 ` Herbert Xu
2019-05-03  6:09   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.