* [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ...
@ 2021-08-19 8:03 Jan Beulich
2021-08-19 18:55 ` Paul Durrant
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2021-08-19 8:03 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Paul Durrant
... an already not mapped page. With all other exit paths doing the
unmap, I have no idea how I managed to miss that aspect at the time.
Fixes: ad591454f069 ("AMD/IOMMU: don't needlessly trigger errors/crashes when unmapping a page")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_map.c 2021-07-22 08:07:12.501229386 +0200
+++ b/xen/drivers/passthrough/amd/iommu_map.c 2021-07-22 08:08:02.360893418 +0200
@@ -243,7 +243,10 @@ static int iommu_pde_from_dfn(struct dom
else if ( !pde->pr )
{
if ( !map )
+ {
+ unmap_domain_page(next_table_vaddr);
return 0;
+ }
if ( next_table_mfn == 0 )
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping ...
2021-08-19 8:03 [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping Jan Beulich
@ 2021-08-19 18:55 ` Paul Durrant
0 siblings, 0 replies; 2+ messages in thread
From: Paul Durrant @ 2021-08-19 18:55 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Andrew Cooper
On 19/08/2021 09:03, Jan Beulich wrote:
> ... an already not mapped page. With all other exit paths doing the
> unmap, I have no idea how I managed to miss that aspect at the time.
>
> Fixes: ad591454f069 ("AMD/IOMMU: don't needlessly trigger errors/crashes when unmapping a page")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
Reviewed-by: Paul Durrant <paul@xen.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-19 18:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 8:03 [PATCH] AMD/IOMMU: don't leave page table mapped when unmapping Jan Beulich
2021-08-19 18:55 ` Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.