All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device
Date: Tue, 7 May 2019 15:32:03 +0200	[thread overview]
Message-ID: <dfeead63-ac78-4c65-2e05-9a2efb91971d@redhat.com> (raw)
In-Reply-To: <20190507122748.18506-1-philmd@redhat.com>

On 5/7/19 2:27 PM, Philippe Mathieu-Daudé wrote:
> The Q35 machine uses the ICH9 chipset which is composed of various
> sub-devices. There is currently no generic Kconfig selector that
> selects all the required devices. Meanwhile, force the Q35 machine
> to select the 'ich9-ahci' device.
> 
> This fixes:
> 
>   $ ./configure --without-default-devices && \
>     ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
>   qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
>   Aborted (core dumped)
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
I forgot:

Based-on: <20190430071405.16714-3-thuth@redhat.com>
"hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device"

>  hw/i386/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index a6aed7c1313..98178882169 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -80,7 +80,7 @@ config Q35
>      select PC_ACPI
>      select PCI_EXPRESS_Q35
>      select LPC_ICH9
> -    select AHCI
> +    select AHCI_ICH9
>      select DIMM
>      select SMBIOS
>      select VMPORT
> 


      reply	other threads:[~2019-05-07 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 12:27 [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device Philippe Mathieu-Daudé
2019-05-07 13:32 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfeead63-ac78-4c65-2e05-9a2efb91971d@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.