All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device
@ 2019-05-07 12:27 Philippe Mathieu-Daudé
  2019-05-07 13:32 ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-07 12:27 UTC (permalink / raw)
  To: qemu-devel, Thomas Huth
  Cc: Peter Maydell, Eduardo Habkost, Michael S. Tsirkin,
	Paolo Bonzini, Philippe Mathieu-Daudé,
	Richard Henderson

The Q35 machine uses the ICH9 chipset which is composed of various
sub-devices. There is currently no generic Kconfig selector that
selects all the required devices. Meanwhile, force the Q35 machine
to select the 'ich9-ahci' device.

This fixes:

  $ ./configure --without-default-devices && \
    ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
  qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
  Aborted (core dumped)

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index a6aed7c1313..98178882169 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -80,7 +80,7 @@ config Q35
     select PC_ACPI
     select PCI_EXPRESS_Q35
     select LPC_ICH9
-    select AHCI
+    select AHCI_ICH9
     select DIMM
     select SMBIOS
     select VMPORT
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device
  2019-05-07 12:27 [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device Philippe Mathieu-Daudé
@ 2019-05-07 13:32 ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-07 13:32 UTC (permalink / raw)
  To: qemu-devel, Thomas Huth
  Cc: Peter Maydell, Eduardo Habkost, Michael S. Tsirkin,
	Paolo Bonzini, Richard Henderson

On 5/7/19 2:27 PM, Philippe Mathieu-Daudé wrote:
> The Q35 machine uses the ICH9 chipset which is composed of various
> sub-devices. There is currently no generic Kconfig selector that
> selects all the required devices. Meanwhile, force the Q35 machine
> to select the 'ich9-ahci' device.
> 
> This fixes:
> 
>   $ ./configure --without-default-devices && \
>     ./i386-softmmu/qemu-system-i386 -nodefaults -M q35
>   qemu-system-i386: Unknown device 'ich9-ahci' for bus 'PCIE'
>   Aborted (core dumped)
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
I forgot:

Based-on: <20190430071405.16714-3-thuth@redhat.com>
"hw/ide/ahci: Add a Kconfig switch for the AHCI-ICH9 device"

>  hw/i386/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index a6aed7c1313..98178882169 100644
> --- a/hw/i386/Kconfig
> +++ b/hw/i386/Kconfig
> @@ -80,7 +80,7 @@ config Q35
>      select PC_ACPI
>      select PCI_EXPRESS_Q35
>      select LPC_ICH9
> -    select AHCI
> +    select AHCI_ICH9
>      select DIMM
>      select SMBIOS
>      select VMPORT
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-07 13:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 12:27 [Qemu-devel] [PATCH] hw/i386/Kconfig: The Q35 machine requires the ICH9_AHCI device Philippe Mathieu-Daudé
2019-05-07 13:32 ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.