Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding

From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: <krzysztof.kozlowski@canonical.com>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-crypto@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
Date: Tue, 25 May 2021 16:43:28 +0200	[thread overview]
Message-ID: <dleftjcztezxf3.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <1621857218-28590-1-git-send-email-tiantao6@hisilicon.com> (Tian Tao's message of "Mon, 24 May 2021 19:53:38 +0800")

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

It was <2021-05-24 pon 19:53>, when Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: drop unnecessary change about if condition.
> ---
>  drivers/char/hw_random/exynos-trng.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>

Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index c8db62b..9cc3d54 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev)
>  {
>  	int ret;
>  
> -	ret = pm_runtime_get_sync(dev);
> +	ret = pm_runtime_resume_and_get(dev);
>  	if (ret < 0) {
>  		dev_err(dev, "Could not get runtime PM.\n");
> -		pm_runtime_put_noidle(dev);
>  		return ret;
>  	}

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]