* [PATCH] unix.7: Add a description for ENFILE.
@ 2021-09-29 1:38 Kuniyuki Iwashima
2021-10-02 17:44 ` Alejandro Colomar (man-pages)
2021-10-02 18:12 ` Alejandro Colomar (man-pages)
0 siblings, 2 replies; 6+ messages in thread
From: Kuniyuki Iwashima @ 2021-09-29 1:38 UTC (permalink / raw)
To: Michael Kerrisk, Alejandro Colomar
Cc: Benjamin Herrenschmidt, Kuniyuki Iwashima, Kuniyuki Iwashima,
linux-man, netdev
When creating UNIX domain sockets, the kernel used to return -ENOMEM on
error where it should return -ENFILE. The behaviour has been wrong since
2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
instead of NULL in unix_create1().").
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
---
Note to maintainers of man-pages, the commit is merged in the net tree [0]
but not in the Linus' tree yet.
[0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
---
man7/unix.7 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/man7/unix.7 b/man7/unix.7
index 6d30b25cd..2dc96fea1 100644
--- a/man7/unix.7
+++ b/man7/unix.7
@@ -721,6 +721,9 @@ invalid state for the applied operation.
called on an already connected socket or a target address was
specified on a connected socket.
.TP
+.B ENFILE
+The system-wide limit on the total number of open files has been reached.
+.TP
.B ENOENT
The pathname in the remote address specified to
.BR connect (2)
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] unix.7: Add a description for ENFILE.
2021-09-29 1:38 [PATCH] unix.7: Add a description for ENFILE Kuniyuki Iwashima
@ 2021-10-02 17:44 ` Alejandro Colomar (man-pages)
2021-10-02 17:56 ` Kuniyuki Iwashima
2021-10-02 18:12 ` Alejandro Colomar (man-pages)
1 sibling, 1 reply; 6+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-10-02 17:44 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: Benjamin Herrenschmidt, Kuniyuki Iwashima, linux-man, netdev,
Michael Kerrisk
Hello Kuniyuki,
On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
> When creating UNIX domain sockets, the kernel used to return -ENOMEM on
> error where it should return -ENFILE. The behaviour has been wrong since
> 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
> instead of NULL in unix_create1().").
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> ---
> Note to maintainers of man-pages, the commit is merged in the net tree [0]
> but not in the Linus' tree yet.
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
Thanks!
The patch looks good to me, so could you ping back when this is merged
in Linus's tree?
Cheers,
Alex
> ---
> man7/unix.7 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/man7/unix.7 b/man7/unix.7
> index 6d30b25cd..2dc96fea1 100644
> --- a/man7/unix.7
> +++ b/man7/unix.7
> @@ -721,6 +721,9 @@ invalid state for the applied operation.
> called on an already connected socket or a target address was
> specified on a connected socket.
> .TP
> +.B ENFILE
> +The system-wide limit on the total number of open files has been reached.
> +.TP
> .B ENOENT
> The pathname in the remote address specified to
> .BR connect (2)
>
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unix.7: Add a description for ENFILE.
2021-10-02 17:44 ` Alejandro Colomar (man-pages)
@ 2021-10-02 17:56 ` Kuniyuki Iwashima
2021-10-02 18:10 ` Alejandro Colomar (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Kuniyuki Iwashima @ 2021-10-02 17:56 UTC (permalink / raw)
To: alx.manpages; +Cc: benh, kuni1840, kuniyu, linux-man, mtk.manpages, netdev
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Date: Sat, 2 Oct 2021 19:44:52 +0200
> Hello Kuniyuki,
>
> On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
> > When creating UNIX domain sockets, the kernel used to return -ENOMEM on
> > error where it should return -ENFILE. The behaviour has been wrong since
> > 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
> > instead of NULL in unix_create1().").
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> > ---
> > Note to maintainers of man-pages, the commit is merged in the net tree [0]
> > but not in the Linus' tree yet.
> >
> > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
>
> Thanks!
>
> The patch looks good to me, so could you ping back when this is merged
> in Linus's tree?
Thanks, sure!
Is that -stable?
The pull-request from net-next hit the Linus' 5.14-rc4 tree few days ago.
https://lore.kernel.org/linux-kernel/20210930163002.4159171-1-kuba@kernel.org/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4de593fb965fc2bd11a0b767e0c65ff43540a6e4
Best regards,
Kuniyuki
>
> Cheers,
>
> Alex
>
> > ---
> > man7/unix.7 | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/man7/unix.7 b/man7/unix.7
> > index 6d30b25cd..2dc96fea1 100644
> > --- a/man7/unix.7
> > +++ b/man7/unix.7
> > @@ -721,6 +721,9 @@ invalid state for the applied operation.
> > called on an already connected socket or a target address was
> > specified on a connected socket.
> > .TP
> > +.B ENFILE
> > +The system-wide limit on the total number of open files has been reached.
> > +.TP
> > .B ENOENT
> > The pathname in the remote address specified to
> > .BR connect (2)
> >
>
>
> --
> Alejandro Colomar
> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
> http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unix.7: Add a description for ENFILE.
2021-10-02 17:56 ` Kuniyuki Iwashima
@ 2021-10-02 18:10 ` Alejandro Colomar (man-pages)
0 siblings, 0 replies; 6+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-10-02 18:10 UTC (permalink / raw)
To: Kuniyuki Iwashima; +Cc: benh, kuni1840, linux-man, mtk.manpages, netdev
Hi, Kuniyuki!
On 10/2/21 7:56 PM, Kuniyuki Iwashima wrote:
> From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
> Date: Sat, 2 Oct 2021 19:44:52 +0200
>> Hello Kuniyuki,
>>
>> On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
>>> When creating UNIX domain sockets, the kernel used to return -ENOMEM on
>>> error where it should return -ENFILE. The behaviour has been wrong since
>>> 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
>>> instead of NULL in unix_create1().").
>>>
>>> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
>>> ---
>>> Note to maintainers of man-pages, the commit is merged in the net tree [0]
>>> but not in the Linus' tree yet.
>>>
>>> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
>>
>> Thanks!
>>
>> The patch looks good to me, so could you ping back when this is merged
>> in Linus's tree?
>
> Thanks, sure!
> Is that -stable?
> The pull-request from net-next hit the Linus' 5.14-rc4 tree few days ago.
> https://lore.kernel.org/linux-kernel/20210930163002.4159171-1-kuba@kernel.org/
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4de593fb965fc2bd11a0b767e0c65ff43540a6e4
Ahh, if it already is in Linus's tree, I'll merge your patch.
Thanks,
Alex
>
> Best regards,
> Kuniyuki
>
>
>>
>> Cheers,
>>
>> Alex
>>
>>> ---
>>> man7/unix.7 | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/man7/unix.7 b/man7/unix.7
>>> index 6d30b25cd..2dc96fea1 100644
>>> --- a/man7/unix.7
>>> +++ b/man7/unix.7
>>> @@ -721,6 +721,9 @@ invalid state for the applied operation.
>>> called on an already connected socket or a target address was
>>> specified on a connected socket.
>>> .TP
>>> +.B ENFILE
>>> +The system-wide limit on the total number of open files has been reached.
>>> +.TP
>>> .B ENOENT
>>> The pathname in the remote address specified to
>>> .BR connect (2)
>>>
>>
>>
>> --
>> Alejandro Colomar
>> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
>> http://www.alejandro-colomar.es/
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] unix.7: Add a description for ENFILE.
2021-09-29 1:38 [PATCH] unix.7: Add a description for ENFILE Kuniyuki Iwashima
2021-10-02 17:44 ` Alejandro Colomar (man-pages)
@ 2021-10-02 18:12 ` Alejandro Colomar (man-pages)
2021-10-02 18:47 ` Kuniyuki Iwashima
1 sibling, 1 reply; 6+ messages in thread
From: Alejandro Colomar (man-pages) @ 2021-10-02 18:12 UTC (permalink / raw)
To: Kuniyuki Iwashima
Cc: Benjamin Herrenschmidt, Kuniyuki Iwashima, linux-man, netdev,
Michael Kerrisk
On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
> When creating UNIX domain sockets, the kernel used to return -ENOMEM on
> error where it should return -ENFILE. The behaviour has been wrong since
> 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
> instead of NULL in unix_create1().").
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> ---
> Note to maintainers of man-pages, the commit is merged in the net tree [0]
> but not in the Linus' tree yet.
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
Patch applied!
Thanks,
Alex
> ---
> man7/unix.7 | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/man7/unix.7 b/man7/unix.7
> index 6d30b25cd..2dc96fea1 100644
> --- a/man7/unix.7
> +++ b/man7/unix.7
> @@ -721,6 +721,9 @@ invalid state for the applied operation.
> called on an already connected socket or a target address was
> specified on a connected socket.
> .TP
> +.B ENFILE
> +The system-wide limit on the total number of open files has been reached.
> +.TP
> .B ENOENT
> The pathname in the remote address specified to
> .BR connect (2)
>
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] unix.7: Add a description for ENFILE.
2021-10-02 18:12 ` Alejandro Colomar (man-pages)
@ 2021-10-02 18:47 ` Kuniyuki Iwashima
0 siblings, 0 replies; 6+ messages in thread
From: Kuniyuki Iwashima @ 2021-10-02 18:47 UTC (permalink / raw)
To: alx.manpages; +Cc: benh, kuni1840, kuniyu, linux-man, mtk.manpages, netdev
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Date: Sat, 2 Oct 2021 20:12:48 +0200
> On 9/29/21 3:38 AM, Kuniyuki Iwashima wrote:
> > When creating UNIX domain sockets, the kernel used to return -ENOMEM on
> > error where it should return -ENFILE. The behaviour has been wrong since
> > 2.2.4 and fixed in the recent commit f4bd73b5a950 ("af_unix: Return errno
> > instead of NULL in unix_create1().").
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
> > ---
> > Note to maintainers of man-pages, the commit is merged in the net tree [0]
> > but not in the Linus' tree yet.
> >
> > [0]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=f4bd73b5a950
>
> Patch applied!
Thank you!
Best regards,
Kuniyuki
>
> Thanks,
>
> Alex
>
> > ---
> > man7/unix.7 | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/man7/unix.7 b/man7/unix.7
> > index 6d30b25cd..2dc96fea1 100644
> > --- a/man7/unix.7
> > +++ b/man7/unix.7
> > @@ -721,6 +721,9 @@ invalid state for the applied operation.
> > called on an already connected socket or a target address was
> > specified on a connected socket.
> > .TP
> > +.B ENFILE
> > +The system-wide limit on the total number of open files has been reached.
> > +.TP
> > .B ENOENT
> > The pathname in the remote address specified to
> > .BR connect (2)
> >
>
>
> --
> Alejandro Colomar
> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
> http://www.alejandro-colomar.es/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-02 18:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 1:38 [PATCH] unix.7: Add a description for ENFILE Kuniyuki Iwashima
2021-10-02 17:44 ` Alejandro Colomar (man-pages)
2021-10-02 17:56 ` Kuniyuki Iwashima
2021-10-02 18:10 ` Alejandro Colomar (man-pages)
2021-10-02 18:12 ` Alejandro Colomar (man-pages)
2021-10-02 18:47 ` Kuniyuki Iwashima
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.