* Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()
@ 2020-07-25 12:02 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-07-25 12:02 UTC (permalink / raw)
To: Yi Wang, Liao Pingfang, linux-arm-kernel
Cc: linux-kernel, kernel-janitors, Russell King, Wang Liang, Xue Zhihong
> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.
Such information is useful.
> If this node is not put it may cause a memory leak.
Is the reference management generally improvable for this function implementation?
Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init()
@ 2020-07-25 12:02 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-07-25 12:02 UTC (permalink / raw)
To: Yi Wang, Liao Pingfang, linux-arm-kernel
Cc: linux-kernel, kernel-janitors, Russell King, Wang Liang, Xue Zhihong
> The variable np in function m10v_smp_init takes the return value
> of of_find_compatible_node, which gets a node but does not put it.
Such information is useful.
> If this node is not put it may cause a memory leak.
Is the reference management generally improvable for this function implementation?
Will the tag “Fixes” become helpful for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 12:02 [PATCH v2] ARM: milbeaut: Add missing of_node_put() call in m10v_smp_init() Markus Elfring
2020-07-25 12:02 ` Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.