All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barret Rhoden <brho@google.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
	Liran Alon <liran.alon@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files
Date: Mon, 16 Dec 2019 11:05:26 -0500	[thread overview]
Message-ID: <e012696f-f13e-5af1-2b14-084607d69bfa@google.com> (raw)
In-Reply-To: <20191213171950.GA31552@linux.intel.com>

On 12/13/19 12:19 PM, Sean Christopherson wrote:
> Teaching thp_adjust() how to handle 1GB wouldn't be a bad thing.  It's
> unlikely THP itself will support 1GB pages any time soon, but having the
> logic there wouldn't hurt anything.
> 

Cool.  This was my main concern - I didn't want to break THP.

I'll rework the series based on all of your comments.

Thanks,

Barret

_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Barret Rhoden <brho@google.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
	Liran Alon <liran.alon@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	David Hildenbrand <david@redhat.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files
Date: Mon, 16 Dec 2019 11:05:26 -0500	[thread overview]
Message-ID: <e012696f-f13e-5af1-2b14-084607d69bfa@google.com> (raw)
In-Reply-To: <20191213171950.GA31552@linux.intel.com>

On 12/13/19 12:19 PM, Sean Christopherson wrote:
> Teaching thp_adjust() how to handle 1GB wouldn't be a bad thing.  It's
> unlikely THP itself will support 1GB pages any time soon, but having the
> logic there wouldn't hurt anything.
> 

Cool.  This was my main concern - I didn't want to break THP.

I'll rework the series based on all of your comments.

Thanks,

Barret



  parent reply	other threads:[~2019-12-16 16:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 18:22 [PATCH v5 0/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-12 18:22 ` Barret Rhoden
2019-12-12 18:22 ` [PATCH v5 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2019-12-12 18:22   ` Barret Rhoden
2019-12-13 17:47   ` Sean Christopherson
2019-12-13 17:47     ` Sean Christopherson
2019-12-13 18:13     ` Dan Williams
2019-12-13 18:13       ` Dan Williams
2019-12-16 17:59     ` Barret Rhoden
2019-12-16 17:59       ` Barret Rhoden
2019-12-18  0:18       ` Sean Christopherson
2019-12-18  0:18         ` Sean Christopherson
2020-01-15 18:33       ` Paolo Bonzini
2020-01-15 18:33         ` Paolo Bonzini
2019-12-12 18:22 ` [PATCH v5 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-12 18:22   ` Barret Rhoden
2019-12-12 18:47   ` Liran Alon
2019-12-12 18:47     ` Liran Alon
2019-12-12 18:49     ` Liran Alon
2019-12-12 18:49       ` Liran Alon
2019-12-12 19:55       ` Barret Rhoden
2019-12-12 19:55         ` Barret Rhoden
2019-12-13  1:07         ` Liran Alon
2019-12-13  1:07           ` Liran Alon
2019-12-13 14:13           ` Barret Rhoden
2019-12-13 14:13             ` Barret Rhoden
2019-12-13 17:19           ` Sean Christopherson
2019-12-13 17:19             ` Sean Christopherson
2019-12-13 17:31             ` Liran Alon
2019-12-13 17:31               ` Liran Alon
2019-12-13 17:50               ` Sean Christopherson
2019-12-13 17:50                 ` Sean Christopherson
2019-12-13 18:08                 ` Liran Alon
2019-12-13 18:08                   ` Liran Alon
2019-12-16 16:05             ` Barret Rhoden [this message]
2019-12-16 16:05               ` Barret Rhoden
2020-01-07 19:05               ` Sean Christopherson
2020-01-07 19:05                 ` Sean Christopherson
2020-01-07 19:19                 ` Barret Rhoden
2020-01-07 19:19                   ` Barret Rhoden
2020-01-08  1:20                   ` Sean Christopherson
2020-01-08  1:20                     ` Sean Christopherson
2020-01-08  1:39                     ` Dan Williams
2020-01-08  1:39                       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e012696f-f13e-5af1-2b14-084607d69bfa@google.com \
    --to=brho@google.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=david@redhat.com \
    --cc=jason.zeng@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=liran.alon@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.