[PATCH] power: supply: axp288_fuel_gauge: Broaden vendor check for Intel Compute Sticks.

[PATCH] power: supply: axp288_fuel_gauge: Broaden vendor check for Intel Compute Sticks.

[Jeffery Miller]

The Intel Compute Stick `STK1A32SC` can have a system vendor of
"Intel(R) Client Systems".
Broaden the Intel Compute Stick DMI checks so that they match "Intel
Corporation" as well as "Intel(R) Client Systems".

This fixes an issue where the STK1A32SC compute sticks were still
exposing a battery with the existing blacklist entry.

Signed-off-by: Jeffery Miller <jmiller@neverware.com>
---

I've tested this primarily with a 4.19 kernel on Intel Compute Sticks
with the "Intel(R) Client Systems" vendor.

 drivers/power/supply/axp288_fuel_gauge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index e1bc4e6e6f30..f40fa0e63b6e 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -706,14 +706,14 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
 	{
 		/* Intel Cherry Trail Compute Stick, Windows version */
 		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "STK1AW32SC"),
 		},
 	},
 	{
 		/* Intel Cherry Trail Compute Stick, version without an OS */
 		.matches = {
-			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
+			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
 		},
 	},
-- 
2.24.1

Re: [PATCH] power: supply: axp288_fuel_gauge: Broaden vendor check for Intel Compute Sticks.

[Hans de Goede]

Hi,

On 2/25/20 11:59 PM, Jeffery Miller wrote:
> The Intel Compute Stick `STK1A32SC` can have a system vendor of
> "Intel(R) Client Systems".
> Broaden the Intel Compute Stick DMI checks so that they match "Intel
> Corporation" as well as "Intel(R) Client Systems".
> 
> This fixes an issue where the STK1A32SC compute sticks were still
> exposing a battery with the existing blacklist entry.
> 
> Signed-off-by: Jeffery Miller <jmiller@neverware.com>

Thank you for the patch. The patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans





> ---
> 
> I've tested this primarily with a 4.19 kernel on Intel Compute Sticks
> with the "Intel(R) Client Systems" vendor.
> 
>   drivers/power/supply/axp288_fuel_gauge.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index e1bc4e6e6f30..f40fa0e63b6e 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -706,14 +706,14 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
>   	{
>   		/* Intel Cherry Trail Compute Stick, Windows version */
>   		.matches = {
> -			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> +			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
>   			DMI_MATCH(DMI_PRODUCT_NAME, "STK1AW32SC"),
>   		},
>   	},
>   	{
>   		/* Intel Cherry Trail Compute Stick, version without an OS */
>   		.matches = {
> -			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> +			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
>   			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
>   		},
>   	},
> 

Re: [PATCH] power: supply: axp288_fuel_gauge: Broaden vendor check for Intel Compute Sticks.

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

Hi,

On Wed, Feb 26, 2020 at 01:36:53PM +0100, Hans de Goede wrote:
> On 2/25/20 11:59 PM, Jeffery Miller wrote:
> > The Intel Compute Stick `STK1A32SC` can have a system vendor of
> > "Intel(R) Client Systems".
> > Broaden the Intel Compute Stick DMI checks so that they match "Intel
> > Corporation" as well as "Intel(R) Client Systems".
> > 
> > This fixes an issue where the STK1A32SC compute sticks were still
> > exposing a battery with the existing blacklist entry.
> > 
> > Signed-off-by: Jeffery Miller <jmiller@neverware.com>
> 
> Thank you for the patch. The patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Thanks, queued.

-- Sebastian

> > ---
> > 
> > I've tested this primarily with a 4.19 kernel on Intel Compute Sticks
> > with the "Intel(R) Client Systems" vendor.
> > 
> >   drivers/power/supply/axp288_fuel_gauge.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> > index e1bc4e6e6f30..f40fa0e63b6e 100644
> > --- a/drivers/power/supply/axp288_fuel_gauge.c
> > +++ b/drivers/power/supply/axp288_fuel_gauge.c
> > @@ -706,14 +706,14 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
> >   	{
> >   		/* Intel Cherry Trail Compute Stick, Windows version */
> >   		.matches = {
> > -			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
> >   			DMI_MATCH(DMI_PRODUCT_NAME, "STK1AW32SC"),
> >   		},
> >   	},
> >   	{
> >   		/* Intel Cherry Trail Compute Stick, version without an OS */
> >   		.matches = {
> > -			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Intel"),
> >   			DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
> >   		},
> >   	},
> > 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]