From: Mike Christie <michael.christie@oracle.com>
To: Juergen Gross <jgross@suse.com>,
njavali@marvell.com, pbonzini@redhat.com, jasowang@redhat.com,
mst@redhat.com, stefanha@redhat.com, oneukum@suse.com,
manoj@linux.ibm.com, mrochs@linux.ibm.com, ukrishn@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH 01/10] scsi: xen: Drop use of internal host codes.
Date: Thu, 4 Aug 2022 11:28:35 -0500 [thread overview]
Message-ID: <e037decf-26d1-e60b-2815-9e330d0b6c47@oracle.com> (raw)
In-Reply-To: <b4b91e8b-d6c7-fb5e-6a96-f2b6780dbfe3@suse.com>
On 8/4/22 1:18 AM, Juergen Gross wrote:
> On 04.08.22 05:40, Mike Christie wrote:
>> The error codes:
>>
>> DID_TARGET_FAILURE
>> DID_NEXUS_FAILURE
>> DID_ALLOC_FAILURE
>> DID_MEDIUM_ERROR
>>
>> are internal to the SCSI layer. Drivers must not use them because:
>>
>> 1. They are not propagated upwards, so SG IO/passthrough users will not
>> see an error and think a command was successful.
>>
>> xen-scsiback will never see this error and should not try to send it.
>>
>> 2. There is no handling for them in scsi_decide_disposition so if
>> xen-scsifront were to return the error to scsi-ml then it kicks off the
>> error handler which is definitely not what we want.
>>
>> This patch remove the use from xen-scsifront/back.
>>
>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
>> ---
>> drivers/scsi/xen-scsifront.c | 8 --------
>> drivers/xen/xen-scsiback.c | 12 ------------
>> include/xen/interface/io/vscsiif.h | 10 +---------
>> 3 files changed, 1 insertion(+), 29 deletions(-)
>>
>
> ...
>
>> diff --git a/include/xen/interface/io/vscsiif.h b/include/xen/interface/io/vscsiif.h
>> index 7ea4dc9611c4..44eb1f34f1a0 100644
>> --- a/include/xen/interface/io/vscsiif.h
>> +++ b/include/xen/interface/io/vscsiif.h
>> @@ -316,16 +316,8 @@ struct vscsiif_response {
>> #define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_DISRUPTED 14
>> /* Transport class fastfailed */
>> #define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_FAILFAST 15
>> -/* Permanent target failure */
>> -#define XEN_VSCSIIF_RSLT_HOST_TARGET_FAILURE 16
>> -/* Permanent nexus failure on path */
>> -#define XEN_VSCSIIF_RSLT_HOST_NEXUS_FAILURE 17
>> -/* Space allocation on device failed */
>> -#define XEN_VSCSIIF_RSLT_HOST_ALLOC_FAILURE 18
>> -/* Medium error */
>> -#define XEN_VSCSIIF_RSLT_HOST_MEDIUM_ERROR 19
>> /* Transport marginal errors */
>> -#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL 20
>> +#define XEN_VSCSIIF_RSLT_HOST_TRANSPORT_MARGINAL 16
>
> Please drop the modifications of this header.
>
> This is a copy of the master from the Xen repository. It might be used
> in multiple OS'es across many releases, so it needs to be regarded as ABI.
>
How do you want to handle scsifront_host_byte?
xen-scsiback.c will never return those error codes, but can some other
implementation? Do you want me to add translation from the XEN_VSCSIIF
to some other DID codes?
next prev parent reply other threads:[~2022-08-04 16:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 3:40 [PATCH 00/10] scsi: Fix internal host code use Mike Christie
2022-08-04 3:40 ` [PATCH 01/10] scsi: xen: Drop use of internal host codes Mike Christie
2022-08-04 6:18 ` Juergen Gross
2022-08-04 16:28 ` Mike Christie [this message]
2022-08-04 17:00 ` Juergen Gross
2022-08-04 3:40 ` [PATCH 02/10] scsi: storvsc: Drop DID_TARGET_FAILURE use Mike Christie
2022-08-04 3:40 ` [PATCH 03/10] scsi: uas: " Mike Christie
2022-08-04 18:59 ` Mike Christie
2022-08-04 21:07 ` Hans de Goede
2022-08-04 3:40 ` [PATCH 04/10] scsi: virtio_scsi: " Mike Christie
2022-08-04 18:25 ` Paolo Bonzini
2022-08-09 19:40 ` Michael S. Tsirkin
2022-08-04 3:40 ` [PATCH 05/10] scsi: virtio_scsi: Drop DID_NEXUS_FAILURE use Mike Christie
2022-08-04 18:25 ` Paolo Bonzini
2022-08-09 19:40 ` Michael S. Tsirkin
2022-08-04 3:40 ` [PATCH 06/10] scsi: qla2xxx: Drop DID_TARGET_FAILURE use Mike Christie
2022-08-04 3:40 ` [PATCH 07/10] scsi: cxlflash: Drop DID_ALLOC_FAILURE use Mike Christie
2022-08-04 3:40 ` [PATCH 08/10] scsi: Add error codes for internal scsi-ml use Mike Christie
2022-08-09 20:13 ` Bart Van Assche
2022-08-10 3:18 ` Mike Christie
2022-08-04 3:40 ` [PATCH 09/10] scsi: Convert scsi_decide_disposition to use SCSIML_STAT Mike Christie
2022-08-09 20:14 ` Bart Van Assche
2022-08-04 3:41 ` [PATCH 10/10] scsi: Remove useless host error codes Mike Christie
2022-08-09 20:08 ` Bart Van Assche
2022-08-04 6:55 ` [PATCH 00/10] scsi: Fix internal host code use Oliver Neukum
2022-08-04 17:04 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e037decf-26d1-e60b-2815-9e330d0b6c47@oracle.com \
--to=michael.christie@oracle.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manoj@linux.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.ibm.com \
--cc=mst@redhat.com \
--cc=njavali@marvell.com \
--cc=oneukum@suse.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=ukrishn@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.