All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-03 14:21 ` Tom Rix
  0 siblings, 0 replies; 11+ messages in thread
From: Tom Rix @ 2022-04-03 14:21 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix

Smatch reports this issue
hdcp1_execution.c:500:29: warning: function
  'mod_hdcp_hdcp1_dp_execution' with external linkage
  has definition

The storage-class-specifier extern is not needed in a
definition, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
index 6ec918af3bff..1ddb4f5eac8e 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
@@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
 	return status;
 }
 
-extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
-		struct mod_hdcp_event_context *event_ctx,
-		struct mod_hdcp_transition_input_hdcp1 *input)
+enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
+						 struct mod_hdcp_event_context *event_ctx,
+						 struct mod_hdcp_transition_input_hdcp1 *input)
 {
 	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-03 14:21 ` Tom Rix
  0 siblings, 0 replies; 11+ messages in thread
From: Tom Rix @ 2022-04-03 14:21 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel

Smatch reports this issue
hdcp1_execution.c:500:29: warning: function
  'mod_hdcp_hdcp1_dp_execution' with external linkage
  has definition

The storage-class-specifier extern is not needed in a
definition, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
index 6ec918af3bff..1ddb4f5eac8e 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
@@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
 	return status;
 }
 
-extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
-		struct mod_hdcp_event_context *event_ctx,
-		struct mod_hdcp_transition_input_hdcp1 *input)
+enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
+						 struct mod_hdcp_event_context *event_ctx,
+						 struct mod_hdcp_transition_input_hdcp1 *input)
 {
 	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
 
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
  2022-04-03 14:21 ` Tom Rix
@ 2022-04-04 15:22   ` Harry Wentland
  -1 siblings, 0 replies; 11+ messages in thread
From: Harry Wentland @ 2022-04-04 15:22 UTC (permalink / raw)
  To: Tom Rix, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: amd-gfx, dri-devel, linux-kernel



On 2022-04-03 10:21, Tom Rix wrote:
> Smatch reports this issue
> hdcp1_execution.c:500:29: warning: function
>   'mod_hdcp_hdcp1_dp_execution' with external linkage
>   has definition
> 

Which branch are you using?

I don't see the 'extern' on
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c

Harry


> The storage-class-specifier extern is not needed in a
> definition, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> index 6ec918af3bff..1ddb4f5eac8e 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>  	return status;
>  }
>  
> -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> -		struct mod_hdcp_event_context *event_ctx,
> -		struct mod_hdcp_transition_input_hdcp1 *input)
> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> +						 struct mod_hdcp_event_context *event_ctx,
> +						 struct mod_hdcp_transition_input_hdcp1 *input)
>  {
>  	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>  


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-04 15:22   ` Harry Wentland
  0 siblings, 0 replies; 11+ messages in thread
From: Harry Wentland @ 2022-04-04 15:22 UTC (permalink / raw)
  To: Tom Rix, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: dri-devel, amd-gfx, linux-kernel



On 2022-04-03 10:21, Tom Rix wrote:
> Smatch reports this issue
> hdcp1_execution.c:500:29: warning: function
>   'mod_hdcp_hdcp1_dp_execution' with external linkage
>   has definition
> 

Which branch are you using?

I don't see the 'extern' on
https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c

Harry


> The storage-class-specifier extern is not needed in a
> definition, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> index 6ec918af3bff..1ddb4f5eac8e 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>  	return status;
>  }
>  
> -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> -		struct mod_hdcp_event_context *event_ctx,
> -		struct mod_hdcp_transition_input_hdcp1 *input)
> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> +						 struct mod_hdcp_event_context *event_ctx,
> +						 struct mod_hdcp_transition_input_hdcp1 *input)
>  {
>  	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>  


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
  2022-04-04 15:22   ` Harry Wentland
@ 2022-04-04 15:43     ` Tom Rix
  -1 siblings, 0 replies; 11+ messages in thread
From: Tom Rix @ 2022-04-04 15:43 UTC (permalink / raw)
  To: Harry Wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: amd-gfx, dri-devel, linux-kernel


On 4/4/22 8:22 AM, Harry Wentland wrote:
>
> On 2022-04-03 10:21, Tom Rix wrote:
>> Smatch reports this issue
>> hdcp1_execution.c:500:29: warning: function
>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
>>    has definition
>>
> Which branch are you using?

linux-next from 4/1

Tom

>
> I don't see the 'extern' on
> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>
> Harry
>
>
>> The storage-class-specifier extern is not needed in a
>> definition, so remove it.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> index 6ec918af3bff..1ddb4f5eac8e 100644
>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>>   	return status;
>>   }
>>   
>> -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>> -		struct mod_hdcp_event_context *event_ctx,
>> -		struct mod_hdcp_transition_input_hdcp1 *input)
>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>> +						 struct mod_hdcp_event_context *event_ctx,
>> +						 struct mod_hdcp_transition_input_hdcp1 *input)
>>   {
>>   	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>>   


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-04 15:43     ` Tom Rix
  0 siblings, 0 replies; 11+ messages in thread
From: Tom Rix @ 2022-04-04 15:43 UTC (permalink / raw)
  To: Harry Wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: dri-devel, amd-gfx, linux-kernel


On 4/4/22 8:22 AM, Harry Wentland wrote:
>
> On 2022-04-03 10:21, Tom Rix wrote:
>> Smatch reports this issue
>> hdcp1_execution.c:500:29: warning: function
>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
>>    has definition
>>
> Which branch are you using?

linux-next from 4/1

Tom

>
> I don't see the 'extern' on
> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>
> Harry
>
>
>> The storage-class-specifier extern is not needed in a
>> definition, so remove it.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> index 6ec918af3bff..1ddb4f5eac8e 100644
>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>>   	return status;
>>   }
>>   
>> -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>> -		struct mod_hdcp_event_context *event_ctx,
>> -		struct mod_hdcp_transition_input_hdcp1 *input)
>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>> +						 struct mod_hdcp_event_context *event_ctx,
>> +						 struct mod_hdcp_transition_input_hdcp1 *input)
>>   {
>>   	enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>>   


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
  2022-04-04 15:43     ` Tom Rix
@ 2022-04-04 15:57       ` Harry Wentland
  -1 siblings, 0 replies; 11+ messages in thread
From: Harry Wentland @ 2022-04-04 15:57 UTC (permalink / raw)
  To: Tom Rix, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: amd-gfx, dri-devel, linux-kernel



On 2022-04-04 11:43, Tom Rix wrote:
> 
> On 4/4/22 8:22 AM, Harry Wentland wrote:
>>
>> On 2022-04-03 10:21, Tom Rix wrote:
>>> Smatch reports this issue
>>> hdcp1_execution.c:500:29: warning: function
>>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
>>>    has definition
>>>
>> Which branch are you using?
> 
> linux-next from 4/1
> 

Apologies. I was looking at the wrong function.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> Tom
> 
>>
>> I don't see the 'extern' on
>> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
>> Harry
>>
>>
>>> The storage-class-specifier extern is not needed in a
>>> definition, so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> index 6ec918af3bff..1ddb4f5eac8e 100644
>>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>>>       return status;
>>>   }
>>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> -        struct mod_hdcp_event_context *event_ctx,
>>> -        struct mod_hdcp_transition_input_hdcp1 *input)
>>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> +                         struct mod_hdcp_event_context *event_ctx,
>>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
>>>   {
>>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>>>   
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-04 15:57       ` Harry Wentland
  0 siblings, 0 replies; 11+ messages in thread
From: Harry Wentland @ 2022-04-04 15:57 UTC (permalink / raw)
  To: Tom Rix, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
	christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
	waynelin, Anson.Jacob, Yu-ting.Shen, keescook,
	nicholas.kazlauskas
  Cc: dri-devel, amd-gfx, linux-kernel



On 2022-04-04 11:43, Tom Rix wrote:
> 
> On 4/4/22 8:22 AM, Harry Wentland wrote:
>>
>> On 2022-04-03 10:21, Tom Rix wrote:
>>> Smatch reports this issue
>>> hdcp1_execution.c:500:29: warning: function
>>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
>>>    has definition
>>>
>> Which branch are you using?
> 
> linux-next from 4/1
> 

Apologies. I was looking at the wrong function.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> Tom
> 
>>
>> I don't see the 'extern' on
>> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
>> Harry
>>
>>
>>> The storage-class-specifier extern is not needed in a
>>> definition, so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> index 6ec918af3bff..1ddb4f5eac8e 100644
>>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
>>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
>>>       return status;
>>>   }
>>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> -        struct mod_hdcp_event_context *event_ctx,
>>> -        struct mod_hdcp_transition_input_hdcp1 *input)
>>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
>>> +                         struct mod_hdcp_event_context *event_ctx,
>>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
>>>   {
>>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
>>>   
> 


^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
  2022-04-04 15:57       ` Harry Wentland
  (?)
@ 2022-04-07 17:28         ` Alex Deucher
  -1 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2022-04-07 17:28 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Anson Jacob, Kees Cook, Yu-ting.Shen, Leo (Sunpeng) Li, Tom Rix,
	xinhui pan, Siqueira, Rodrigo, LKML,
	Maling list - DRI developers, Wenjing Liu, Dave Airlie, waynelin,
	amd-gfx list, Deucher, Alexander, Kazlauskas, Nicholas,
	Christian Koenig

Applied.  Thanks!

Alex

On Mon, Apr 4, 2022 at 11:57 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-04-04 11:43, Tom Rix wrote:
> >
> > On 4/4/22 8:22 AM, Harry Wentland wrote:
> >>
> >> On 2022-04-03 10:21, Tom Rix wrote:
> >>> Smatch reports this issue
> >>> hdcp1_execution.c:500:29: warning: function
> >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
> >>>    has definition
> >>>
> >> Which branch are you using?
> >
> > linux-next from 4/1
> >
>
> Apologies. I was looking at the wrong function.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > Tom
> >
> >>
> >> I don't see the 'extern' on
> >> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
> >> Harry
> >>
> >>
> >>> The storage-class-specifier extern is not needed in a
> >>> definition, so remove it.
> >>>
> >>> Signed-off-by: Tom Rix <trix@redhat.com>
> >>> ---
> >>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
> >>>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> index 6ec918af3bff..1ddb4f5eac8e 100644
> >>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
> >>>       return status;
> >>>   }
> >>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> -        struct mod_hdcp_event_context *event_ctx,
> >>> -        struct mod_hdcp_transition_input_hdcp1 *input)
> >>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> +                         struct mod_hdcp_event_context *event_ctx,
> >>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
> >>>   {
> >>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
> >>>
> >
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-07 17:28         ` Alex Deucher
  0 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2022-04-07 17:28 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Anson Jacob, Kees Cook, Yu-ting.Shen, Leo (Sunpeng) Li, Tom Rix,
	xinhui pan, Siqueira, Rodrigo, LKML,
	Maling list - DRI developers, Wenjing Liu, Dave Airlie, waynelin,
	amd-gfx list, Daniel Vetter, Deucher, Alexander, Kazlauskas,
	Nicholas, Christian Koenig

Applied.  Thanks!

Alex

On Mon, Apr 4, 2022 at 11:57 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-04-04 11:43, Tom Rix wrote:
> >
> > On 4/4/22 8:22 AM, Harry Wentland wrote:
> >>
> >> On 2022-04-03 10:21, Tom Rix wrote:
> >>> Smatch reports this issue
> >>> hdcp1_execution.c:500:29: warning: function
> >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
> >>>    has definition
> >>>
> >> Which branch are you using?
> >
> > linux-next from 4/1
> >
>
> Apologies. I was looking at the wrong function.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > Tom
> >
> >>
> >> I don't see the 'extern' on
> >> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
> >> Harry
> >>
> >>
> >>> The storage-class-specifier extern is not needed in a
> >>> definition, so remove it.
> >>>
> >>> Signed-off-by: Tom Rix <trix@redhat.com>
> >>> ---
> >>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
> >>>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> index 6ec918af3bff..1ddb4f5eac8e 100644
> >>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
> >>>       return status;
> >>>   }
> >>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> -        struct mod_hdcp_event_context *event_ctx,
> >>> -        struct mod_hdcp_transition_input_hdcp1 *input)
> >>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> +                         struct mod_hdcp_event_context *event_ctx,
> >>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
> >>>   {
> >>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
> >>>
> >
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [PATCH] drm/amd/display: cleanup extern usage in function definition
@ 2022-04-07 17:28         ` Alex Deucher
  0 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2022-04-07 17:28 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Tom Rix, Leo (Sunpeng) Li, Siqueira, Rodrigo, Deucher, Alexander,
	Christian Koenig, xinhui pan, Dave Airlie, Daniel Vetter,
	Wenjing Liu, waynelin, Anson Jacob, Yu-ting.Shen, Kees Cook,
	Kazlauskas, Nicholas, Maling list - DRI developers, amd-gfx list,
	LKML

Applied.  Thanks!

Alex

On Mon, Apr 4, 2022 at 11:57 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-04-04 11:43, Tom Rix wrote:
> >
> > On 4/4/22 8:22 AM, Harry Wentland wrote:
> >>
> >> On 2022-04-03 10:21, Tom Rix wrote:
> >>> Smatch reports this issue
> >>> hdcp1_execution.c:500:29: warning: function
> >>>    'mod_hdcp_hdcp1_dp_execution' with external linkage
> >>>    has definition
> >>>
> >> Which branch are you using?
> >
> > linux-next from 4/1
> >
>
> Apologies. I was looking at the wrong function.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > Tom
> >
> >>
> >> I don't see the 'extern' on
> >> https://gitlab.freedesktop.org/agd5f/linux/-/blob/amd-staging-drm-next/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c>>>
> >> Harry
> >>
> >>
> >>> The storage-class-specifier extern is not needed in a
> >>> definition, so remove it.
> >>>
> >>> Signed-off-by: Tom Rix <trix@redhat.com>
> >>> ---
> >>>   drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c | 6 +++---
> >>>   1 file changed, 3 insertions(+), 3 deletions(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> index 6ec918af3bff..1ddb4f5eac8e 100644
> >>> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c
> >>> @@ -497,9 +497,9 @@ enum mod_hdcp_status mod_hdcp_hdcp1_execution(struct mod_hdcp *hdcp,
> >>>       return status;
> >>>   }
> >>>   -extern enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> -        struct mod_hdcp_event_context *event_ctx,
> >>> -        struct mod_hdcp_transition_input_hdcp1 *input)
> >>> +enum mod_hdcp_status mod_hdcp_hdcp1_dp_execution(struct mod_hdcp *hdcp,
> >>> +                         struct mod_hdcp_event_context *event_ctx,
> >>> +                         struct mod_hdcp_transition_input_hdcp1 *input)
> >>>   {
> >>>       enum mod_hdcp_status status = MOD_HDCP_STATUS_SUCCESS;
> >>>
> >
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-04-07 17:30 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-03 14:21 [PATCH] drm/amd/display: cleanup extern usage in function definition Tom Rix
2022-04-03 14:21 ` Tom Rix
2022-04-04 15:22 ` Harry Wentland
2022-04-04 15:22   ` Harry Wentland
2022-04-04 15:43   ` Tom Rix
2022-04-04 15:43     ` Tom Rix
2022-04-04 15:57     ` Harry Wentland
2022-04-04 15:57       ` Harry Wentland
2022-04-07 17:28       ` Alex Deucher
2022-04-07 17:28         ` Alex Deucher
2022-04-07 17:28         ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.