From: Florian Fainelli <f.fainelli@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Kevin Hilman <khilman@baylibre.com>
Cc: netdev@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: phy: meson-gxl: clean-up gxl variant driver
Date: Thu, 4 Apr 2019 09:33:17 -0700 [thread overview]
Message-ID: <e043e430-362e-1d5e-af43-a95ec2bd27d2@gmail.com> (raw)
In-Reply-To: <20190404131147.31156-5-jbrunet@baylibre.com>
On 4/4/19 6:11 AM, Jerome Brunet wrote:
> The purpose of this change is to align the gxl and g12a driver
> declaration.
>
> Like on the g12a variant, remove genphy_aneg_done() from the driver
> declaration as the net phy framework will default to it anyway.
>
> Also, the gxl phy id should be an exact match as well, so let's change
> this and use the macro provided.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Kevin Hilman <khilman@baylibre.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH net-next v3 4/4] net: phy: meson-gxl: clean-up gxl variant driver
Date: Thu, 4 Apr 2019 09:33:17 -0700 [thread overview]
Message-ID: <e043e430-362e-1d5e-af43-a95ec2bd27d2@gmail.com> (raw)
In-Reply-To: <20190404131147.31156-5-jbrunet@baylibre.com>
On 4/4/19 6:11 AM, Jerome Brunet wrote:
> The purpose of this change is to align the gxl and g12a driver
> declaration.
>
> Like on the g12a variant, remove genphy_aneg_done() from the driver
> declaration as the net phy framework will default to it anyway.
>
> Also, the gxl phy id should be an exact match as well, so let's change
> this and use the macro provided.
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-04-04 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 13:11 [PATCH net-next v3 0/4] net: phy: add Amlogic g12a support Jerome Brunet
2019-04-04 13:11 ` Jerome Brunet
2019-04-04 13:11 ` [PATCH net-next v3 1/4] dt-bindings: net: phy: add g12a mdio mux documentation Jerome Brunet
2019-04-04 13:11 ` Jerome Brunet
2019-04-04 13:11 ` [PATCH net-next v3 2/4] net: phy: add amlogic g12a mdio mux support Jerome Brunet
2019-04-04 13:11 ` Jerome Brunet
2019-04-04 13:11 ` [PATCH net-next v3 3/4] net: phy: meson-gxl: add g12a support Jerome Brunet
2019-04-04 13:11 ` Jerome Brunet
2019-04-04 16:33 ` Florian Fainelli
2019-04-04 16:33 ` Florian Fainelli
2019-04-04 13:11 ` [PATCH net-next v3 4/4] net: phy: meson-gxl: clean-up gxl variant driver Jerome Brunet
2019-04-04 13:11 ` Jerome Brunet
2019-04-04 16:33 ` Florian Fainelli [this message]
2019-04-04 16:33 ` Florian Fainelli
2019-04-07 1:17 ` [PATCH net-next v3 0/4] net: phy: add Amlogic g12a support David Miller
2019-04-07 1:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e043e430-362e-1d5e-af43-a95ec2bd27d2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.