* [PATCH -next] drm/amd/display: Fix the Wunused-function warning
@ 2021-04-08 12:41 ` Shaokun Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Shaokun Zhang @ 2021-04-08 12:41 UTC (permalink / raw)
To: amd-gfx, dri-devel
Cc: Shaokun Zhang, Solomon Chiu, Daniel Wheeler, Alex Deucher, Leo Ma
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
| ^~~~~~~~~~~~~~~~~~~~~~
Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <Harry.Wentland@amd.com>
Cc: Solomon Chiu <solomon.chiu@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index daacc5cc8d51..5298e5d4075b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
return 0;
}
+#if defined(CONFIG_DRM_AMD_DC_DCN)
#define DMUB_TRACE_MAX_READ 64
static void dm_dmub_trace_high_irq(void *interrupt_params)
{
@@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
ASSERT(count <= DMUB_TRACE_MAX_READ);
}
-#if defined(CONFIG_DRM_AMD_DC_DCN)
static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
{
uint64_t pt_base;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] drm/amd/display: Fix the Wunused-function warning
@ 2021-04-08 12:41 ` Shaokun Zhang
0 siblings, 0 replies; 6+ messages in thread
From: Shaokun Zhang @ 2021-04-08 12:41 UTC (permalink / raw)
To: amd-gfx, dri-devel
Cc: Shaokun Zhang, Solomon Chiu, Daniel Wheeler, Alex Deucher,
Leo Ma, Harry Wentland
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
| ^~~~~~~~~~~~~~~~~~~~~~
Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
Cc: Daniel Wheeler <daniel.wheeler@amd.com>
Cc: Harry Wentland <Harry.Wentland@amd.com>
Cc: Solomon Chiu <solomon.chiu@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index daacc5cc8d51..5298e5d4075b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
return 0;
}
+#if defined(CONFIG_DRM_AMD_DC_DCN)
#define DMUB_TRACE_MAX_READ 64
static void dm_dmub_trace_high_irq(void *interrupt_params)
{
@@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
ASSERT(count <= DMUB_TRACE_MAX_READ);
}
-#if defined(CONFIG_DRM_AMD_DC_DCN)
static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
{
uint64_t pt_base;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning
2021-04-08 12:41 ` Shaokun Zhang
@ 2021-04-08 15:09 ` Harry Wentland
-1 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-08 15:09 UTC (permalink / raw)
To: Shaokun Zhang, amd-gfx, dri-devel
Cc: Alex Deucher, Solomon Chiu, Leo Ma, Daniel Wheeler
On 2021-04-08 8:41 a.m., Shaokun Zhang wrote:
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
> 941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
> Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Solomon Chiu <solomon.chiu@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index daacc5cc8d51..5298e5d4075b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
> return 0;
> }
>
> +#if defined(CONFIG_DRM_AMD_DC_DCN)
> #define DMUB_TRACE_MAX_READ 64
> static void dm_dmub_trace_high_irq(void *interrupt_params)
> {
> @@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
> ASSERT(count <= DMUB_TRACE_MAX_READ);
> }
>
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
> static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
> {
> uint64_t pt_base;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning
@ 2021-04-08 15:09 ` Harry Wentland
0 siblings, 0 replies; 6+ messages in thread
From: Harry Wentland @ 2021-04-08 15:09 UTC (permalink / raw)
To: Shaokun Zhang, amd-gfx, dri-devel
Cc: Alex Deucher, Solomon Chiu, Leo Ma, Daniel Wheeler
On 2021-04-08 8:41 a.m., Shaokun Zhang wrote:
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
> 941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
> Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
> Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> Cc: Harry Wentland <Harry.Wentland@amd.com>
> Cc: Solomon Chiu <solomon.chiu@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index daacc5cc8d51..5298e5d4075b 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
> return 0;
> }
>
> +#if defined(CONFIG_DRM_AMD_DC_DCN)
> #define DMUB_TRACE_MAX_READ 64
> static void dm_dmub_trace_high_irq(void *interrupt_params)
> {
> @@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
> ASSERT(count <= DMUB_TRACE_MAX_READ);
> }
>
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
> static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
> {
> uint64_t pt_base;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning
2021-04-08 15:09 ` Harry Wentland
@ 2021-04-08 20:14 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-04-08 20:14 UTC (permalink / raw)
To: Harry Wentland
Cc: Maling list - DRI developers, Shaokun Zhang, Solomon Chiu,
Daniel Wheeler, amd-gfx list, Alex Deucher, Leo Ma
Applied. Thanks.
Alex
On Thu, Apr 8, 2021 at 11:09 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2021-04-08 8:41 a.m., Shaokun Zhang wrote:
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
> > 941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
> > | ^~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
> > Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
> > Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> > Cc: Harry Wentland <Harry.Wentland@amd.com>
> > Cc: Solomon Chiu <solomon.chiu@amd.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index daacc5cc8d51..5298e5d4075b 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
> > return 0;
> > }
> >
> > +#if defined(CONFIG_DRM_AMD_DC_DCN)
> > #define DMUB_TRACE_MAX_READ 64
> > static void dm_dmub_trace_high_irq(void *interrupt_params)
> > {
> > @@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
> > ASSERT(count <= DMUB_TRACE_MAX_READ);
> > }
> >
> > -#if defined(CONFIG_DRM_AMD_DC_DCN)
> > static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
> > {
> > uint64_t pt_base;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/amd/display: Fix the Wunused-function warning
@ 2021-04-08 20:14 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-04-08 20:14 UTC (permalink / raw)
To: Harry Wentland
Cc: Maling list - DRI developers, Shaokun Zhang, Solomon Chiu,
Daniel Wheeler, amd-gfx list, Alex Deucher, Leo Ma
Applied. Thanks.
Alex
On Thu, Apr 8, 2021 at 11:09 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2021-04-08 8:41 a.m., Shaokun Zhang wrote:
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:941:13: warning: ‘dm_dmub_trace_high_irq’ defined but not used [-Wunused-function]
> > 941 | static void dm_dmub_trace_high_irq(void *interrupt_params)
> > | ^~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 83b39e1fc3ea ("drm/amd/display: Log DMCUB trace buffer events")
> > Cc: Leo (Hanghong) Ma <hanghong.ma@amd.com>
> > Cc: Daniel Wheeler <daniel.wheeler@amd.com>
> > Cc: Harry Wentland <Harry.Wentland@amd.com>
> > Cc: Solomon Chiu <solomon.chiu@amd.com>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index daacc5cc8d51..5298e5d4075b 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -937,6 +937,7 @@ static int dm_dmub_hw_init(struct amdgpu_device *adev)
> > return 0;
> > }
> >
> > +#if defined(CONFIG_DRM_AMD_DC_DCN)
> > #define DMUB_TRACE_MAX_READ 64
> > static void dm_dmub_trace_high_irq(void *interrupt_params)
> > {
> > @@ -963,7 +964,6 @@ static void dm_dmub_trace_high_irq(void *interrupt_params)
> > ASSERT(count <= DMUB_TRACE_MAX_READ);
> > }
> >
> > -#if defined(CONFIG_DRM_AMD_DC_DCN)
> > static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_addr_space_config *pa_config)
> > {
> > uint64_t pt_base;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-08 20:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 12:41 [PATCH -next] drm/amd/display: Fix the Wunused-function warning Shaokun Zhang
2021-04-08 12:41 ` Shaokun Zhang
2021-04-08 15:09 ` Harry Wentland
2021-04-08 15:09 ` Harry Wentland
2021-04-08 20:14 ` Alex Deucher
2021-04-08 20:14 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.