All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-nvme@lists.infradead.org>, <kbusch@kernel.org>,
	<axboe@fb.com>, <sagi@grimberg.me>, <linux-block@vger.kernel.org>,
	<axboe@kernel.dk>
Subject: Re: [PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete
Date: Fri, 22 Jan 2021 09:46:15 +0800	[thread overview]
Message-ID: <e053944e-e8de-187e-78f2-21974fb97dbf@huawei.com> (raw)
In-Reply-To: <20210121084059.GA25963@lst.de>



On 2021/1/21 16:40, Christoph Hellwig wrote:
> On Thu, Jan 21, 2021 at 03:03:26PM +0800, Chao Leng wrote:
>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
>> directly complete request in queue_rq.
>> So add blk_mq_set_request_complete.
> 
> So I'm not happy with this helper.  It should at least:
> 
>   a) be named and documented to only apply for the ->queue_rq faіlure case
Although blk_mq_complete_request_remote can set the markup directly,
blk_mq_complete_request_remote can also use this helper. This helper do
not need special processing for ->queue_rq failure.
>   b) check that the request is in MQ_RQ_IDLE state
No, the request may also be in MQ_RQ_IN_FLIGHT state. Do not need to
care whether the original state is MQ_RQ_IDLE or MQ_RQ_IN_FLIGHT.
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org
Subject: Re: [PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete
Date: Fri, 22 Jan 2021 09:46:15 +0800	[thread overview]
Message-ID: <e053944e-e8de-187e-78f2-21974fb97dbf@huawei.com> (raw)
In-Reply-To: <20210121084059.GA25963@lst.de>



On 2021/1/21 16:40, Christoph Hellwig wrote:
> On Thu, Jan 21, 2021 at 03:03:26PM +0800, Chao Leng wrote:
>> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
>> directly complete request in queue_rq.
>> So add blk_mq_set_request_complete.
> 
> So I'm not happy with this helper.  It should at least:
> 
>   a) be named and documented to only apply for the ->queue_rq faіlure case
Although blk_mq_complete_request_remote can set the markup directly,
blk_mq_complete_request_remote can also use this helper. This helper do
not need special processing for ->queue_rq failure.
>   b) check that the request is in MQ_RQ_IDLE state
No, the request may also be in MQ_RQ_IN_FLIGHT state. Do not need to
care whether the original state is MQ_RQ_IDLE or MQ_RQ_IN_FLIGHT.
> .
> 

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-01-22  1:47 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  7:03 [PATCH v3 0/5] avoid double request completion and IO error Chao Leng
2021-01-21  7:03 ` Chao Leng
2021-01-21  7:03 ` [PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-21  7:03   ` Chao Leng
2021-01-21  8:40   ` Christoph Hellwig
2021-01-21  8:40     ` Christoph Hellwig
2021-01-22  1:46     ` Chao Leng [this message]
2021-01-22  1:46       ` Chao Leng
2021-01-21  7:03 ` [PATCH v3 2/5] nvme-core: introduce complete failed request Chao Leng
2021-01-21  7:03   ` Chao Leng
2021-01-21  8:41   ` Christoph Hellwig
2021-01-21  8:41     ` Christoph Hellwig
2021-01-22  1:46     ` Chao Leng
2021-01-22  1:46       ` Chao Leng
2021-01-21  7:03 ` [PATCH v3 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-01-21  7:03   ` Chao Leng
2021-01-21  8:58   ` Hannes Reinecke
2021-01-21  8:58     ` Hannes Reinecke
2021-01-21  9:00     ` Christoph Hellwig
2021-01-21  9:00       ` Christoph Hellwig
2021-01-21  9:27       ` Hannes Reinecke
2021-01-21  9:27         ` Hannes Reinecke
2021-01-22  1:50         ` Chao Leng
2021-01-22  1:50           ` Chao Leng
2021-01-22  1:48     ` Chao Leng
2021-01-22  1:48       ` Chao Leng
2021-01-21  7:03 ` [PATCH v3 4/5] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-01-21  7:03   ` Chao Leng
2021-01-21  7:03 ` [PATCH v3 5/5] nvme-fc: " Chao Leng
2021-01-21  7:03   ` Chao Leng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e053944e-e8de-187e-78f2-21974fb97dbf@huawei.com \
    --to=lengchao@huawei.com \
    --cc=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.