All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sven Peter" <sven@svenpeter.dev>
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: "Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	"Hector Martin" <marcan@marcan.st>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
	"Stan Skowronek" <stan@corellium.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Mark Kettenis" <mark.kettenis@xs4all.nl>,
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings
Date: Sun, 28 Mar 2021 11:22:47 +0200	[thread overview]
Message-ID: <e05aa388-e1dd-4b94-b427-69cf0d14b7f6@www.fastmail.com> (raw)
In-Reply-To: <CAK8P3a3a1k9SyrRLammX8dGF3GjojUVUEZ4cMfb2+g6CXkBNCA@mail.gmail.com>



On Sun, Mar 28, 2021, at 10:16, Arnd Bergmann wrote:
> On Sun, Mar 28, 2021 at 9:40 AM Sven Peter <sven@svenpeter.dev> wrote:
> 
> I noticed only one detail here:
> 
> > +  - |+
> > +    dart2a: dart2a@82f00000 {
> > +      compatible = "apple,t8103-dart";
> > +      reg = <0x82f00000 0x4000>;
> > +      interrupts = <1 781 4>;
> > +      #iommu-cells = <1>;
> > +    };
> 
> The name of the iommu should be iommu@82f00000, not dart2a@82f00000.
> 
>        Arnd
>

Thanks, fixed for v3. I've also just noticed that I forgot to update
the filename in MAINTAINERS after I renamed it from apple,t8103-dart.yaml
which I've fixed as well.


Sven


WARNING: multiple messages have this Message-ID (diff)
From: Sven Peter via iommu <iommu@lists.linux-foundation.org>
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>, Will Deacon <will@kernel.org>,
	Hector Martin <marcan@marcan.st>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
	Rob Herring <robh+dt@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Mohamed Mediouni <mohamed.mediouni@caramail.com>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	Robin Murphy <robin.murphy@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Stan Skowronek <stan@corellium.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings
Date: Sun, 28 Mar 2021 11:22:47 +0200	[thread overview]
Message-ID: <e05aa388-e1dd-4b94-b427-69cf0d14b7f6@www.fastmail.com> (raw)
In-Reply-To: <CAK8P3a3a1k9SyrRLammX8dGF3GjojUVUEZ4cMfb2+g6CXkBNCA@mail.gmail.com>



On Sun, Mar 28, 2021, at 10:16, Arnd Bergmann wrote:
> On Sun, Mar 28, 2021 at 9:40 AM Sven Peter <sven@svenpeter.dev> wrote:
> 
> I noticed only one detail here:
> 
> > +  - |+
> > +    dart2a: dart2a@82f00000 {
> > +      compatible = "apple,t8103-dart";
> > +      reg = <0x82f00000 0x4000>;
> > +      interrupts = <1 781 4>;
> > +      #iommu-cells = <1>;
> > +    };
> 
> The name of the iommu should be iommu@82f00000, not dart2a@82f00000.
> 
>        Arnd
>

Thanks, fixed for v3. I've also just noticed that I forgot to update
the filename in MAINTAINERS after I renamed it from apple,t8103-dart.yaml
which I've fixed as well.


Sven

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: "Sven Peter" <sven@svenpeter.dev>
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: "Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	DTML <devicetree@vger.kernel.org>,
	"Hector Martin" <marcan@marcan.st>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
	"Stan Skowronek" <stan@corellium.com>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Mark Kettenis" <mark.kettenis@xs4all.nl>,
	"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings
Date: Sun, 28 Mar 2021 11:22:47 +0200	[thread overview]
Message-ID: <e05aa388-e1dd-4b94-b427-69cf0d14b7f6@www.fastmail.com> (raw)
In-Reply-To: <CAK8P3a3a1k9SyrRLammX8dGF3GjojUVUEZ4cMfb2+g6CXkBNCA@mail.gmail.com>



On Sun, Mar 28, 2021, at 10:16, Arnd Bergmann wrote:
> On Sun, Mar 28, 2021 at 9:40 AM Sven Peter <sven@svenpeter.dev> wrote:
> 
> I noticed only one detail here:
> 
> > +  - |+
> > +    dart2a: dart2a@82f00000 {
> > +      compatible = "apple,t8103-dart";
> > +      reg = <0x82f00000 0x4000>;
> > +      interrupts = <1 781 4>;
> > +      #iommu-cells = <1>;
> > +    };
> 
> The name of the iommu should be iommu@82f00000, not dart2a@82f00000.
> 
>        Arnd
>

Thanks, fixed for v3. I've also just noticed that I forgot to update
the filename in MAINTAINERS after I renamed it from apple,t8103-dart.yaml
which I've fixed as well.


Sven


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-28  9:24 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28  7:40 [PATCH v2 0/3] Apple M1 DART IOMMU driver Sven Peter
2021-03-28  7:40 ` Sven Peter
2021-03-28  7:40 ` Sven Peter via iommu
2021-03-28  7:40 ` [PATCH v2 1/3] iommu: io-pgtable: add DART pagetable format Sven Peter
2021-03-28  7:40   ` Sven Peter
2021-03-28  7:40   ` Sven Peter via iommu
2021-03-28  9:42   ` kernel test robot
2021-03-28  9:42     ` kernel test robot
2021-03-28 10:13     ` Sven Peter
2021-03-28 10:13       ` Sven Peter
2021-03-28 10:04   ` kernel test robot
2021-03-28 10:04     ` kernel test robot
2021-04-07 10:44   ` Will Deacon
2021-04-07 10:44     ` Will Deacon
2021-04-07 10:44     ` Will Deacon
2021-04-09 16:55     ` Sven Peter
2021-04-09 16:55       ` Sven Peter
2021-04-09 16:55       ` Sven Peter via iommu
2021-04-09 19:38       ` Arnd Bergmann
2021-04-09 19:38         ` Arnd Bergmann
2021-04-09 19:38         ` Arnd Bergmann
2021-04-19 16:31         ` Will Deacon
2021-04-19 16:31           ` Will Deacon
2021-04-19 16:31           ` Will Deacon
2021-03-28  7:40 ` [PATCH v2 2/3] dt-bindings: iommu: add DART iommu bindings Sven Peter
2021-03-28  7:40   ` Sven Peter
2021-03-28  7:40   ` Sven Peter via iommu
2021-03-28  8:16   ` Arnd Bergmann
2021-03-28  8:16     ` Arnd Bergmann
2021-03-28  8:16     ` Arnd Bergmann
2021-03-28  9:22     ` Sven Peter [this message]
2021-03-28  9:22       ` Sven Peter
2021-03-28  9:22       ` Sven Peter via iommu
2021-03-28  7:40 ` [PATCH v2 3/3] iommu: dart: Add DART iommu driver Sven Peter
2021-03-28  7:40   ` Sven Peter
2021-03-28  7:40   ` Sven Peter via iommu
2021-03-28  9:34   ` kernel test robot
2021-03-28  9:34     ` kernel test robot
2021-03-28 10:11     ` Sven Peter
2021-03-28 10:11       ` Sven Peter
2021-04-07 10:42   ` Will Deacon
2021-04-07 10:42     ` Will Deacon
2021-04-07 10:42     ` Will Deacon
2021-04-09 16:50     ` Sven Peter
2021-04-09 16:50       ` Sven Peter
2021-04-09 16:50       ` Sven Peter via iommu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e05aa388-e1dd-4b94-b427-69cf0d14b7f6@www.fastmail.com \
    --to=sven@svenpeter.dev \
    --cc=arnd@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=maz@kernel.org \
    --cc=mohamed.mediouni@caramail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=stan@corellium.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.