From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: yu kuai <yukuai3@huawei.com>
Cc: benh@kernel.crashing.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'
Date: Mon, 2 Mar 2020 16:42:30 +0100 [thread overview]
Message-ID: <e060e0a0-1861-20f0-d1ef-6a8137949659@samsung.com> (raw)
In-Reply-To: <20200119121730.10701-5-yukuai3@huawei.com>
On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/aty/radeon_base.c: In function
> ‘radeonfb_set_par’:
> drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
> variable ‘bytpp’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/aty/radeon_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 7d2ee889ffcd..22b3ee4f2ffa 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info)
> int i, freq;
> int format = 0;
> int nopllcalc = 0;
> - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid;
> + int hsync_start, hsync_fudge, hsync_wid, vsync_wid;
> int primary_mon = PRIMARY_MONITOR(rinfo);
> int depth = var_to_depth(mode);
> int use_rmx = 0;
> @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info)
> vsync_wid = 0x1f;
>
> format = radeon_get_dstbpp(depth);
> - bytpp = mode->bits_per_pixel >> 3;
>
> if ((primary_mon == MT_DFP) || (primary_mon == MT_LCD))
> hsync_fudge = hsync_fudge_fp[format-1];
>
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: yu kuai <yukuai3@huawei.com>
Cc: linux-fbdev@vger.kernel.org, yi.zhang@huawei.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
zhengbin13@huawei.com
Subject: Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'
Date: Mon, 02 Mar 2020 15:42:30 +0000 [thread overview]
Message-ID: <e060e0a0-1861-20f0-d1ef-6a8137949659@samsung.com> (raw)
In-Reply-To: <20200119121730.10701-5-yukuai3@huawei.com>
On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/aty/radeon_base.c: In function
> ‘radeonfb_set_par’:
> drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
> variable ‘bytpp’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/aty/radeon_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 7d2ee889ffcd..22b3ee4f2ffa 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info)
> int i, freq;
> int format = 0;
> int nopllcalc = 0;
> - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid;
> + int hsync_start, hsync_fudge, hsync_wid, vsync_wid;
> int primary_mon = PRIMARY_MONITOR(rinfo);
> int depth = var_to_depth(mode);
> int use_rmx = 0;
> @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info)
> vsync_wid = 0x1f;
>
> format = radeon_get_dstbpp(depth);
> - bytpp = mode->bits_per_pixel >> 3;
>
> if ((primary_mon = MT_DFP) || (primary_mon = MT_LCD))
> hsync_fudge = hsync_fudge_fp[format-1];
>
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: yu kuai <yukuai3@huawei.com>
Cc: linux-fbdev@vger.kernel.org, yi.zhang@huawei.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
zhengbin13@huawei.com
Subject: Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'
Date: Mon, 2 Mar 2020 16:42:30 +0100 [thread overview]
Message-ID: <e060e0a0-1861-20f0-d1ef-6a8137949659@samsung.com> (raw)
In-Reply-To: <20200119121730.10701-5-yukuai3@huawei.com>
On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/video/fbdev/aty/radeon_base.c: In function
> ‘radeonfb_set_par’:
> drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
> variable ‘bytpp’ set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
>
> Signed-off-by: yu kuai <yukuai3@huawei.com>
Patch queued for v5.7, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/video/fbdev/aty/radeon_base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 7d2ee889ffcd..22b3ee4f2ffa 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info)
> int i, freq;
> int format = 0;
> int nopllcalc = 0;
> - int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid;
> + int hsync_start, hsync_fudge, hsync_wid, vsync_wid;
> int primary_mon = PRIMARY_MONITOR(rinfo);
> int depth = var_to_depth(mode);
> int use_rmx = 0;
> @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info)
> vsync_wid = 0x1f;
>
> format = radeon_get_dstbpp(depth);
> - bytpp = mode->bits_per_pixel >> 3;
>
> if ((primary_mon == MT_DFP) || (primary_mon == MT_LCD))
> hsync_fudge = hsync_fudge_fp[format-1];
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-02 15:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:17 [PATCH 0/4] cleanup patches for unused variables yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` [PATCH 1/4] video: fbdev: remove set but not used variable 'hSyncPol' yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-01-19 12:17 ` [PATCH 2/4] video: fbdev: remove set but not used variable 'vSyncPol' yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-01-19 12:17 ` [PATCH 3/4] " yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-01-19 12:17 ` [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp' yu kuai
2020-01-19 12:17 ` yu kuai
2020-01-19 12:17 ` yu kuai
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz [this message]
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
2020-03-02 15:42 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e060e0a0-1861-20f0-d1ef-6a8137949659@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.