All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] svm: bitwise vs logical AND typo
@ 2016-05-23 10:20 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-05-23 10:20 UTC (permalink / raw)
  To: Joerg Roedel, Suravee Suthikulpanit
  Cc: Paolo Bonzini, Radim Krčmář,
	Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm,
	kernel-janitors

This was supposed to be a bitwise AND but there is a typo.

Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 2214214..2eb615e 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
 	u32 icrh = svm->vmcb->control.exit_info_1 >> 32;
 	u32 icrl = svm->vmcb->control.exit_info_1;
 	u32 id = svm->vmcb->control.exit_info_2 >> 32;
-	u32 index = svm->vmcb->control.exit_info_2 && 0xFF;
+	u32 index = svm->vmcb->control.exit_info_2 & 0xFF;
 	struct kvm_lapic *apic = svm->vcpu.arch.apic;
 
 	trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [patch] svm: bitwise vs logical AND typo
@ 2016-05-23 10:20 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-05-23 10:20 UTC (permalink / raw)
  To: Joerg Roedel, Suravee Suthikulpanit
  Cc: Paolo Bonzini, Radim Krčmář,
	Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm,
	kernel-janitors

This was supposed to be a bitwise AND but there is a typo.

Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 2214214..2eb615e 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
 	u32 icrh = svm->vmcb->control.exit_info_1 >> 32;
 	u32 icrl = svm->vmcb->control.exit_info_1;
 	u32 id = svm->vmcb->control.exit_info_2 >> 32;
-	u32 index = svm->vmcb->control.exit_info_2 && 0xFF;
+	u32 index = svm->vmcb->control.exit_info_2 & 0xFF;
 	struct kvm_lapic *apic = svm->vcpu.arch.apic;
 
 	trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [patch] svm: bitwise vs logical AND typo
  2016-05-23 10:20 ` Dan Carpenter
@ 2016-05-23 12:27   ` Paolo Bonzini
  -1 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-05-23 12:27 UTC (permalink / raw)
  To: Dan Carpenter, Joerg Roedel, Suravee Suthikulpanit
  Cc: Radim Krčmář,
	Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm,
	kernel-janitors



On 23/05/2016 12:20, Dan Carpenter wrote:
> This was supposed to be a bitwise AND but there is a typo.
> 
> Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 2214214..2eb615e 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
>  	u32 icrh = svm->vmcb->control.exit_info_1 >> 32;
>  	u32 icrl = svm->vmcb->control.exit_info_1;
>  	u32 id = svm->vmcb->control.exit_info_2 >> 32;
> -	u32 index = svm->vmcb->control.exit_info_2 && 0xFF;
> +	u32 index = svm->vmcb->control.exit_info_2 & 0xFF;
>  	struct kvm_lapic *apic = svm->vcpu.arch.apic;
>  
>  	trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Looks good, thanks.

Paolo

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [patch] svm: bitwise vs logical AND typo
@ 2016-05-23 12:27   ` Paolo Bonzini
  0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2016-05-23 12:27 UTC (permalink / raw)
  To: Dan Carpenter, Joerg Roedel, Suravee Suthikulpanit
  Cc: Radim Krčmář,
	Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86, kvm,
	kernel-janitors



On 23/05/2016 12:20, Dan Carpenter wrote:
> This was supposed to be a bitwise AND but there is a typo.
> 
> Fixes: 18f40c53e10f ('svm: Add VMEXIT handlers for AVIC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 2214214..2eb615e 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -3597,7 +3597,7 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
>  	u32 icrh = svm->vmcb->control.exit_info_1 >> 32;
>  	u32 icrl = svm->vmcb->control.exit_info_1;
>  	u32 id = svm->vmcb->control.exit_info_2 >> 32;
> -	u32 index = svm->vmcb->control.exit_info_2 && 0xFF;
> +	u32 index = svm->vmcb->control.exit_info_2 & 0xFF;
>  	struct kvm_lapic *apic = svm->vcpu.arch.apic;
>  
>  	trace_kvm_avic_incomplete_ipi(svm->vcpu.vcpu_id, icrh, icrl, id, index);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Looks good, thanks.

Paolo

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-23 12:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-23 10:20 [patch] svm: bitwise vs logical AND typo Dan Carpenter
2016-05-23 10:20 ` Dan Carpenter
2016-05-23 12:27 ` Paolo Bonzini
2016-05-23 12:27   ` Paolo Bonzini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.