From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Roger Pau Monne <roger.pau@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 8/9] x86/vmx: Support removing MSRs from the host/guest load/save lists
Date: Tue, 12 Jun 2018 19:23:13 +0100 [thread overview]
Message-ID: <e07908e9-aa7b-5ff8-696b-1a96b495c93e@citrix.com> (raw)
In-Reply-To: <ba237035-ce91-f068-238f-f37c4d12820b@citrix.com>
On 12/06/18 18:40, Andrew Cooper wrote:
> On 12/06/18 09:27, Jan Beulich wrote:
>>> + end = start + total;
>>> + ent = locate_msr_entry(start + substart, start + subend, msr);
>>> +
>>> + if ( (ent == end) || (ent->index != msr) )
>>> + return -ESRCH;
>>> +
>>> + memmove(ent, ent + 1, sizeof(*ent) * (end - ent));
>> Aren't you running over the end of the array by 1 entry here?
> ent == end is an error condition above. By this point, ent is
> guaranteed to be < end.
Although on further consideration, the size parameter should be (end -
ent - 1) to avoid moving the entry beyond the end of the array.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-06-12 18:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 18:48 [PATCH v2 0/9] x86/vmx: Don't leak EFER.NXE into guest context Andrew Cooper
2018-06-08 18:48 ` [PATCH v2 1/9] x86/vmx: API improvements for MSR load/save infrastructure Andrew Cooper
2018-06-08 18:48 ` [PATCH v2 2/9] x86/vmx: Internal cleanup " Andrew Cooper
2018-06-08 18:48 ` [PATCH v2 3/9] x86/vmx: Factor locate_msr_entry() out of vmx_find_msr() and vmx_add_msr() Andrew Cooper
2018-06-08 18:48 ` [PATCH v2 4/9] x86/vmx: Support remote access to the MSR lists Andrew Cooper
2018-06-12 2:49 ` Tian, Kevin
2018-06-12 8:06 ` Jan Beulich
2018-06-08 18:48 ` [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling Andrew Cooper
2018-06-12 2:58 ` Tian, Kevin
2018-06-12 8:15 ` Jan Beulich
2018-06-12 8:51 ` Andrew Cooper
2018-06-12 9:00 ` Jan Beulich
2018-06-12 16:33 ` Andrew Cooper
2018-06-13 6:30 ` Jan Beulich
2018-06-13 10:37 ` Andrew Cooper
2018-06-27 8:43 ` [PATCH v3 " Andrew Cooper
2018-06-27 9:12 ` Jan Beulich
2018-06-27 9:50 ` Andrew Cooper
2018-06-27 9:58 ` Jan Beulich
2018-06-27 9:59 ` Andrew Cooper
2018-06-08 18:48 ` [PATCH v2 6/9] x86/vmx: Pass an MSR value into vmx_msr_add() Andrew Cooper
2018-06-12 3:11 ` Tian, Kevin
2018-06-12 8:19 ` Jan Beulich
2018-06-08 18:48 ` [PATCH v2 7/9] x86/vmx: Support load-only guest MSR list entries Andrew Cooper
2018-06-12 3:22 ` Tian, Kevin
2018-06-08 18:48 ` [PATCH v2 8/9] x86/vmx: Support removing MSRs from the host/guest load/save lists Andrew Cooper
2018-06-12 3:24 ` Tian, Kevin
2018-06-12 8:27 ` Jan Beulich
2018-06-12 17:40 ` Andrew Cooper
2018-06-12 18:23 ` Andrew Cooper [this message]
2018-06-13 6:33 ` Jan Beulich
2018-06-08 18:48 ` [PATCH v2 9/9] x86/vmx: Don't leak EFER.NXE into guest context Andrew Cooper
2018-06-12 6:04 ` Tian, Kevin
2018-06-12 8:54 ` Jan Beulich
2018-06-13 10:19 ` Andrew Cooper
2018-06-13 11:19 ` [PATCH v3 " Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e07908e9-aa7b-5ff8-696b-1a96b495c93e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.