All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas
@ 2021-01-05  4:07 Thinh Nguyen
  2021-01-05 10:28 ` Hans de Goede
  2021-01-05 12:49 ` Oliver Neukum
  0 siblings, 2 replies; 3+ messages in thread
From: Thinh Nguyen @ 2021-01-05  4:07 UTC (permalink / raw)
  To: Hans de Goede, Greg Kroah-Hartman, Alan Stern, usb-storage
  Cc: stable, linux-usb

Here's another variant PNY Pro Elite USB 3.1 Gen 2 portable SSD that
hangs and doesn't respond to ATA_1x pass-through commands. If it doesn't
support these commands, it should respond properly to the host. Add it
to the unusual uas list to be able to move forward with other
operations.

Cc: stable@vger.kernel.org
Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 870e9cf3d5dc..f9677a5ec31b 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -90,6 +90,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_BROKEN_FUA),
 
+/* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
+UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
+		"PNY",
+		"Pro Elite SSD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_NO_ATA_1X),
+
 /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
 UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999,
 		"PNY",

base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas
  2021-01-05  4:07 [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas Thinh Nguyen
@ 2021-01-05 10:28 ` Hans de Goede
  2021-01-05 12:49 ` Oliver Neukum
  1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-01-05 10:28 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Alan Stern, usb-storage
  Cc: stable, linux-usb

Hi,

On 1/5/21 5:07 AM, Thinh Nguyen wrote:
> Here's another variant PNY Pro Elite USB 3.1 Gen 2 portable SSD that
> hangs and doesn't respond to ATA_1x pass-through commands. If it doesn't
> support these commands, it should respond properly to the host. Add it
> to the unusual uas list to be able to move forward with other
> operations.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 870e9cf3d5dc..f9677a5ec31b 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -90,6 +90,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA),
>  
> +/* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
> +UNUSUAL_DEV(0x154b, 0xf00b, 0x0000, 0x9999,
> +		"PNY",
> +		"Pro Elite SSD",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_NO_ATA_1X),
> +
>  /* Reported-by: Thinh Nguyen <thinhn@synopsys.com> */
>  UNUSUAL_DEV(0x154b, 0xf00d, 0x0000, 0x9999,
>  		"PNY",
> 
> base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas
  2021-01-05  4:07 [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas Thinh Nguyen
  2021-01-05 10:28 ` Hans de Goede
@ 2021-01-05 12:49 ` Oliver Neukum
  1 sibling, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2021-01-05 12:49 UTC (permalink / raw)
  To: Thinh Nguyen, Hans de Goede, Greg Kroah-Hartman, Alan Stern, usb-storage
  Cc: stable, linux-usb

Am Montag, den 04.01.2021, 20:07 -0800 schrieb Thinh Nguyen:
> Here's another variant PNY Pro Elite USB 3.1 Gen 2 portable SSD that
> hangs and doesn't respond to ATA_1x pass-through commands. If it doesn't
> support these commands, it should respond properly to the host. Add it
> to the unusual uas list to be able to move forward with other
> operations.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Acked-by: Oliver Neukum <oneukum@suse.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-05 12:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05  4:07 [PATCH] usb: uas: Add PNY USB Portable SSD to unusual_uas Thinh Nguyen
2021-01-05 10:28 ` Hans de Goede
2021-01-05 12:49 ` Oliver Neukum

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.