Inline comments and the line length

Inline comments and the line length

[Karolina Drobnik]

Hi,

I'm working on tidying up the vt6655 driver and I can see warnings
about lines with inline comments that are too long, for example:

```
CHECK: line length of 129 exceeds 100 columns
#171: FILE: drivers/staging/vt6655/rf.c:171:
    0x08031B00 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* init
0x080B1B00 => 0x080F1B00 for 3 wire control TxGain(D10) */ 
```

Is this something that should be addressed or is it ok to leave it as
it is?


Thanks,
Karolina

Re: [Outreachy kernel] Inline comments and the line length

[Praveen Kumar]

On 19-10-2021 17:06, Karolina Drobnik wrote:
> Hi,
> 
> I'm working on tidying up the vt6655 driver and I can see warnings
> about lines with inline comments that are too long, for example:
> 
> ```
> CHECK: line length of 129 exceeds 100 columns
> #171: FILE: drivers/staging/vt6655/rf.c:171:
>     0x08031B00 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW, /* init
> 0x080B1B00 => 0x080F1B00 for 3 wire control TxGain(D10) */

I think you can put the comment above this statement.

/* init 0x080B1B00 => 0x080F1B00 for 3 wire control TxGain(D10) */
0x08031B00 + (BY_AL7230_REG_LEN << 3) + IFREGCTL_REGW,

However, I do see other entries are not in 80 column boundary.
So, lets wait for more comments.

> ```
> 
> Is this something that should be addressed or is it ok to leave it as
> it is?
> 
> 
> Thanks,
> Karolina
> 

Regards,

~Praveen.