From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: Kamal Heib <kamalheib1@gmail.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>
Subject: RE: [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp
Date: Mon, 7 Jun 2021 22:31:34 +0000 [thread overview]
Message-ID: <e0c4178e7a7f460dae43abd767761155@intel.com> (raw)
In-Reply-To: <20210607221543.254144-1-kamalheib1@gmail.com>
> Subject: [PATCH for-next] RDMA/irdma: Fix return error sign from
> irdma_modify_qp
>
> There is a typo in the returned error code sign from irdma_modify_qp() when the
> attr_mask is not supported - Fix it.
>
> Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/hw/irdma/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 294155293243..154ca25e7e32 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -1472,7 +1472,7 @@ int irdma_modify_qp(struct ib_qp *ibqp, struct
> ib_qp_attr *attr, int attr_mask,
> unsigned long flags;
>
> if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS)
> - return ~EOPNOTSUPP;
> + return -EOPNOTSUPP;
>
Oops. That's a bad one. Thanks!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
next prev parent reply other threads:[~2021-06-07 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 22:15 [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp Kamal Heib
2021-06-07 22:31 ` Saleem, Shiraz [this message]
2021-06-07 23:46 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0c4178e7a7f460dae43abd767761155@intel.com \
--to=shiraz.saleem@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.