* [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp
@ 2021-06-07 22:15 Kamal Heib
2021-06-07 22:31 ` Saleem, Shiraz
2021-06-07 23:46 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Heib @ 2021-06-07 22:15 UTC (permalink / raw)
To: linux-rdma
Cc: Doug Ledford, Jason Gunthorpe, Mustafa Ismail, Shiraz Saleem, Kamal Heib
There is a typo in the returned error code sign from irdma_modify_qp()
when the attr_mask is not supported - Fix it.
Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/hw/irdma/verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index 294155293243..154ca25e7e32 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -1472,7 +1472,7 @@ int irdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask,
unsigned long flags;
if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS)
- return ~EOPNOTSUPP;
+ return -EOPNOTSUPP;
ctx_info = &iwqp->ctx_info;
offload_info = &iwqp->iwarp_info;
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp
2021-06-07 22:15 [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp Kamal Heib
@ 2021-06-07 22:31 ` Saleem, Shiraz
2021-06-07 23:46 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Saleem, Shiraz @ 2021-06-07 22:31 UTC (permalink / raw)
To: Kamal Heib, linux-rdma; +Cc: Doug Ledford, Jason Gunthorpe, Ismail, Mustafa
> Subject: [PATCH for-next] RDMA/irdma: Fix return error sign from
> irdma_modify_qp
>
> There is a typo in the returned error code sign from irdma_modify_qp() when the
> attr_mask is not supported - Fix it.
>
> Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/hw/irdma/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 294155293243..154ca25e7e32 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -1472,7 +1472,7 @@ int irdma_modify_qp(struct ib_qp *ibqp, struct
> ib_qp_attr *attr, int attr_mask,
> unsigned long flags;
>
> if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS)
> - return ~EOPNOTSUPP;
> + return -EOPNOTSUPP;
>
Oops. That's a bad one. Thanks!
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp
2021-06-07 22:15 [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp Kamal Heib
2021-06-07 22:31 ` Saleem, Shiraz
@ 2021-06-07 23:46 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-06-07 23:46 UTC (permalink / raw)
To: Kamal Heib; +Cc: linux-rdma, Doug Ledford, Mustafa Ismail, Shiraz Saleem
On Tue, Jun 08, 2021 at 01:15:43AM +0300, Kamal Heib wrote:
> There is a typo in the returned error code sign from irdma_modify_qp()
> when the attr_mask is not supported - Fix it.
>
> Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> ---
> drivers/infiniband/hw/irdma/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 22:15 [PATCH for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp Kamal Heib
2021-06-07 22:31 ` Saleem, Shiraz
2021-06-07 23:46 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.