* [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-04-07 6:50 Tian Tao
2021-04-07 8:22 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Tian Tao @ 2021-04-07 6:50 UTC (permalink / raw)
To: hvaibhav.linux, johan, elder, gregkh; +Cc: greybus-dev, linux-staging, Tian Tao
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/staging/greybus/arche-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index e374dfc..be27ace 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -500,13 +500,13 @@ static int arche_platform_probe(struct platform_device *pdev)
arche_platform_wd_irq,
arche_platform_wd_irq_thread,
IRQF_TRIGGER_FALLING |
- IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT |
+ IRQF_NO_AUTOEN,
dev_name(dev), arche_pdata);
if (ret) {
dev_err(dev, "failed to request wake detect IRQ %d\n", ret);
return ret;
}
- disable_irq(arche_pdata->wake_detect_irq);
ret = device_create_file(dev, &dev_attr_state);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-07 6:50 [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-04-07 8:22 ` Greg KH
2021-04-07 8:29 ` tiantao (H)
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2021-04-07 8:22 UTC (permalink / raw)
To: Tian Tao; +Cc: hvaibhav.linux, johan, elder, greybus-dev, linux-staging
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we
can't do anything until then.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-07 8:22 ` Greg KH
@ 2021-04-07 8:29 ` tiantao (H)
2021-04-07 8:40 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: tiantao (H) @ 2021-04-07 8:29 UTC (permalink / raw)
To: Greg KH, Tian Tao
Cc: hvaibhav.linux, johan, elder, greybus-dev, linux-staging
在 2021/4/7 16:22, Greg KH 写道:
> On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
>> disable_irq() after request_irq() still has a time gap in which
>> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
>> disable IRQ auto-enable because of requesting.
>>
>> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
>> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> Can you wait until that is merged before sending this out to us as we
> can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
>
> thanks,
>
> greg k-h
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-07 8:29 ` tiantao (H)
@ 2021-04-07 8:40 ` Greg KH
2021-04-07 8:43 ` tiantao (H)
2021-04-08 0:51 ` tiantao (H)
0 siblings, 2 replies; 7+ messages in thread
From: Greg KH @ 2021-04-07 8:40 UTC (permalink / raw)
To: tiantao (H)
Cc: Tian Tao, hvaibhav.linux, johan, elder, greybus-dev, linux-staging
On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
>
> 在 2021/4/7 16:22, Greg KH 写道:
> > On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
> > > disable_irq() after request_irq() still has a time gap in which
> > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > disable IRQ auto-enable because of requesting.
> > >
> > > this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> > > is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> > Can you wait until that is merged before sending this out to us as we
> > can't do anything until then.
>
> this is already in linux-next.git.
>
> cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
That's great, but note that linux-next is a combined tree of all
subsystem trees. It's impossible for a subsystem tree to include
linux-next :)
So how about we wait until this gets into Linus's tree so that we do not
all suddenly get problems in our individual subsystem trees.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-07 8:40 ` Greg KH
@ 2021-04-07 8:43 ` tiantao (H)
2021-04-08 0:51 ` tiantao (H)
1 sibling, 0 replies; 7+ messages in thread
From: tiantao (H) @ 2021-04-07 8:43 UTC (permalink / raw)
To: Greg KH
Cc: Tian Tao, hvaibhav.linux, johan, elder, greybus-dev, linux-staging
在 2021/4/7 16:40, Greg KH 写道:
> On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
>> 在 2021/4/7 16:22, Greg KH 写道:
>>> On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
>>>> disable_irq() after request_irq() still has a time gap in which
>>>> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
>>>> disable IRQ auto-enable because of requesting.
>>>>
>>>> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
>>>> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>>> Can you wait until that is merged before sending this out to us as we
>>> can't do anything until then.
>> this is already in linux-next.git.
>>
>> cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
> That's great, but note that linux-next is a combined tree of all
> subsystem trees. It's impossible for a subsystem tree to include
> linux-next :)
>
> So how about we wait until this gets into Linus's tree so that we do not
> all suddenly get problems in our individual subsystem trees.
>
> thanks,
ok,I will resend later.
>
> greg k-h
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-07 8:40 ` Greg KH
2021-04-07 8:43 ` tiantao (H)
@ 2021-04-08 0:51 ` tiantao (H)
2021-04-08 6:25 ` Greg KH
1 sibling, 1 reply; 7+ messages in thread
From: tiantao (H) @ 2021-04-08 0:51 UTC (permalink / raw)
To: Greg KH
Cc: Tian Tao, hvaibhav.linux, johan, elder, greybus-dev, linux-staging
在 2021/4/7 16:40, Greg KH 写道:
> On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
>> 在 2021/4/7 16:22, Greg KH 写道:
>>> On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
>>>> disable_irq() after request_irq() still has a time gap in which
>>>> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
>>>> disable IRQ auto-enable because of requesting.
>>>>
>>>> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
>>>> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>>> Can you wait until that is merged before sending this out to us as we
>>> can't do anything until then.
>> this is already in linux-next.git.
>>
>> cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
> That's great, but note that linux-next is a combined tree of all
> subsystem trees. It's impossible for a subsystem tree to include
> linux-next :)
Maybe you can referencethis tag
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-autoen-2021-03-25
>
> So how about we wait until this gets into Linus's tree so that we do not
> all suddenly get problems in our individual subsystem trees.
>
> thanks,
>
> greg k-h
> .
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag
2021-04-08 0:51 ` tiantao (H)
@ 2021-04-08 6:25 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2021-04-08 6:25 UTC (permalink / raw)
To: tiantao (H)
Cc: Tian Tao, hvaibhav.linux, johan, elder, greybus-dev, linux-staging
On Thu, Apr 08, 2021 at 08:51:09AM +0800, tiantao (H) wrote:
>
> 在 2021/4/7 16:40, Greg KH 写道:
> > On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
> > > 在 2021/4/7 16:22, Greg KH 写道:
> > > > On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
> > > > > disable_irq() after request_irq() still has a time gap in which
> > > > > interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> > > > > disable IRQ auto-enable because of requesting.
> > > > >
> > > > > this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> > > > > is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> > > > Can you wait until that is merged before sending this out to us as we
> > > > can't do anything until then.
> > > this is already in linux-next.git.
> > >
> > > cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
> > That's great, but note that linux-next is a combined tree of all
> > subsystem trees. It's impossible for a subsystem tree to include
> > linux-next :)
> Maybe you can referencethis tag https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-autoen-2021-03-25
In what way?
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-08 6:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 6:50 [PATCH] staging: greybus: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-04-07 8:22 ` Greg KH
2021-04-07 8:29 ` tiantao (H)
2021-04-07 8:40 ` Greg KH
2021-04-07 8:43 ` tiantao (H)
2021-04-08 0:51 ` tiantao (H)
2021-04-08 6:25 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.