* [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module
2021-09-20 12:53 [PATCH 0/4] ARM: dts: dra7: enable BB2D module Neil Armstrong
@ 2021-09-20 12:53 ` Neil Armstrong
2021-09-20 13:37 ` Tony Lindgren
2021-09-20 12:53 ` [PATCH 2/4] ARM: dts: dra7-evm: Enable BB2D node Neil Armstrong
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2021-09-20 12:53 UTC (permalink / raw)
To: tony
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana,
Jyri Sarha, Neil Armstrong
From: Gowtham Tammana <g-tammana@ti.com>
BB2D is a Vivante GC 2D Accelerator.
This adds the node to the dts file within a target module node.
Crossbar index number is used for interrupt mapping.
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/boot/dts/dra7.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index dfc1ef8ef6ae..8a9df5ed5439 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -965,6 +965,26 @@ hdmi: encoder@0 {
};
};
+ target-module@59000000 {
+ compatible = "ti,sysc-omap4", "ti,sysc";
+ reg = <0x59000020 0x4>;
+ reg-names = "rev";
+ clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
+ clock-names = "fck";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x59000000 0x1000>;
+
+ bb2d: gpu@0 {
+ compatible = "vivante,gc";
+ reg = <0x0 0x0700>;
+ interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
+ clock-names = "core";
+ status = "disabled";
+ };
+ };
+
aes1_target: target-module@4b500000 {
compatible = "ti,sysc-omap2", "ti,sysc";
reg = <0x4b500080 0x4>,
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module
2021-09-20 12:53 ` [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module Neil Armstrong
@ 2021-09-20 13:37 ` Tony Lindgren
2021-09-20 14:13 ` Neil Armstrong
0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2021-09-20 13:37 UTC (permalink / raw)
To: Neil Armstrong
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana, Jyri Sarha
Hi,
* Neil Armstrong <narmstrong@baylibre.com> [210920 12:53]:
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
> };
> };
>
> + target-module@59000000 {
> + compatible = "ti,sysc-omap4", "ti,sysc";
> + reg = <0x59000020 0x4>;
> + reg-names = "rev";
> + clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
> + clock-names = "fck";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x59000000 0x1000>;
> +
> + bb2d: gpu@0 {
> + compatible = "vivante,gc";
> + reg = <0x0 0x0700>;
> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
> + clock-names = "core";
> + status = "disabled";
> + };
> + };
> +
> aes1_target: target-module@4b500000 {
> compatible = "ti,sysc-omap2", "ti,sysc";
> reg = <0x4b500080 0x4>,
How about just use the default for the bb2d node with is "okay"?
That way there's no need set status = "okay" for each board file.
If there is no driver loaded, we idle the target-module anyways.
Regards,
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module
2021-09-20 13:37 ` Tony Lindgren
@ 2021-09-20 14:13 ` Neil Armstrong
0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2021-09-20 14:13 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana, Jyri Sarha
On 20/09/2021 15:37, Tony Lindgren wrote:
> Hi,
>
> * Neil Armstrong <narmstrong@baylibre.com> [210920 12:53]:
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
>> };
>> };
>>
>> + target-module@59000000 {
>> + compatible = "ti,sysc-omap4", "ti,sysc";
>> + reg = <0x59000020 0x4>;
>> + reg-names = "rev";
>> + clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
>> + clock-names = "fck";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x59000000 0x1000>;
>> +
>> + bb2d: gpu@0 {
>> + compatible = "vivante,gc";
>> + reg = <0x0 0x0700>;
>> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
>> + clock-names = "core";
>> + status = "disabled";
>> + };
>> + };
>> +
>> aes1_target: target-module@4b500000 {
>> compatible = "ti,sysc-omap2", "ti,sysc";
>> reg = <0x4b500080 0x4>,
>
> How about just use the default for the bb2d node with is "okay"?
> That way there's no need set status = "okay" for each board file.
>
> If there is no driver loaded, we idle the target-module anyways.
Yes you're right, I'll resend only this patch with no status property on bb2d node.
thanks,
Neil
>
> Regards,
>
> Tony
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/4] ARM: dts: dra7-evm: Enable BB2D node
2021-09-20 12:53 [PATCH 0/4] ARM: dts: dra7: enable BB2D module Neil Armstrong
2021-09-20 12:53 ` [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module Neil Armstrong
@ 2021-09-20 12:53 ` Neil Armstrong
2021-09-20 12:53 ` [PATCH 3/4] ARM: dts: dra72-evm-common: " Neil Armstrong
2021-09-20 12:53 ` [PATCH 4/4] ARM: dts: am57xx-evm: " Neil Armstrong
3 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2021-09-20 12:53 UTC (permalink / raw)
To: tony
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana,
Jyri Sarha, Neil Armstrong
From: Gowtham Tammana <g-tammana@ti.com>
This enables the BB2D graphics accelerator for DRA7 EVM board.
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/boot/dts/dra7-evm.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index 87deb6a76eff..63a29caa4c8c 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -590,3 +590,7 @@ &dsp2 {
status = "okay";
memory-region = <&dsp2_memory_region>;
};
+
+&bb2d {
+ status = "okay";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/4] ARM: dts: dra72-evm-common: Enable BB2D node
2021-09-20 12:53 [PATCH 0/4] ARM: dts: dra7: enable BB2D module Neil Armstrong
2021-09-20 12:53 ` [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module Neil Armstrong
2021-09-20 12:53 ` [PATCH 2/4] ARM: dts: dra7-evm: Enable BB2D node Neil Armstrong
@ 2021-09-20 12:53 ` Neil Armstrong
2021-09-20 12:53 ` [PATCH 4/4] ARM: dts: am57xx-evm: " Neil Armstrong
3 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2021-09-20 12:53 UTC (permalink / raw)
To: tony
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana,
Jyri Sarha, Neil Armstrong
From: Gowtham Tammana <g-tammana@ti.com>
This enables the BB2D graphics accelerator for DRA72 EVM family boards.
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/boot/dts/dra72-evm-common.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
index f12825268188..6f1236b80b40 100644
--- a/arch/arm/boot/dts/dra72-evm-common.dtsi
+++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
@@ -535,6 +535,10 @@ &dss {
status = "okay";
};
+&bb2d {
+ status = "okay";
+};
+
&hdmi {
status = "okay";
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/4] ARM: dts: am57xx-evm: Enable BB2D node
2021-09-20 12:53 [PATCH 0/4] ARM: dts: dra7: enable BB2D module Neil Armstrong
` (2 preceding siblings ...)
2021-09-20 12:53 ` [PATCH 3/4] ARM: dts: dra72-evm-common: " Neil Armstrong
@ 2021-09-20 12:53 ` Neil Armstrong
3 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2021-09-20 12:53 UTC (permalink / raw)
To: tony
Cc: linux-omap, devicetree, linux-kernel, Gowtham Tammana, Eric Ruei,
Jacob Stiffler, Jyri Sarha, Neil Armstrong
From: Gowtham Tammana <g-tammana@ti.com>
This enables the BB2D graphics accelerator for the AM57x based
Beagle-X15 (GPEVM) and IDK platforms.
Signed-off-by: Eric Ruei <e-ruei1@ti.com>
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi | 4 ++++
arch/arm/boot/dts/am57xx-idk-common.dtsi | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi b/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi
index 994e69ab38d7..151b3d5775cc 100644
--- a/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi
+++ b/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi
@@ -645,3 +645,7 @@ &pruss1_mdio {
&pruss2_mdio {
status = "disabled";
};
+
+&bb2d {
+ status = "okay";
+};
diff --git a/arch/arm/boot/dts/am57xx-idk-common.dtsi b/arch/arm/boot/dts/am57xx-idk-common.dtsi
index 9fcb8944aa3e..cbab72a4c8b6 100644
--- a/arch/arm/boot/dts/am57xx-idk-common.dtsi
+++ b/arch/arm/boot/dts/am57xx-idk-common.dtsi
@@ -606,3 +606,7 @@ dpi_out: endpoint {
};
};
};
+
+&bb2d {
+ status = "ok";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread