From: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> To: Oliver O'Halloran <oohall@gmail.com> Cc: <linux-pci@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, Bjorn Helgaas <helgaas@kernel.org>, <linux@yadro.com> Subject: Re: [PATCH v5 16/23] PCI: hotplug: movable BARs: Don't reserve IO/mem bus space Date: Wed, 4 Sep 2019 14:22:54 +0300 [thread overview] Message-ID: <e11fa8c6-4892-82a9-78ad-bc6bdb6f4037@yadro.com> (raw) In-Reply-To: <1edd23fd93386d8a69bc9280329b2d7c819155d4.camel@gmail.com> On 9/4/19 8:42 AM, Oliver O'Halloran wrote: > On Fri, 2019-08-16 at 19:50 +0300, Sergey Miroshnichenko wrote: >> A hotplugged bridge with many hotplug-capable ports may request >> reserving more IO space than the machine has. This could be overridden >> with the "hpiosize=" kernel argument though. >> >> But when BARs are movable, there are no need to reserve space anymore: >> new BARs are allocated not from reserved gaps, but via rearranging the >> existing BARs. Requesting a precise amount of space for bridge windows >> increases the chances of adding the new bridge successfully. > > It wouldn't hurt to reserve some memory space to prevent unnecessary > BAR shuffling at runtime. If it turns out that we need more space then > we can always fall back to re-assigning the whole tree. > Hi Oliver, Thank you for your comments! We had an issue on a x86_64 PC with a small amount of IO space: after hotplugging an empty bridge of 32 ports even a DEFAULT_HOTPLUG_IO_SIZE (which is 256) was enough to exhaust the space. So another patch of this series ("Don't allow added devices to steal resources") had disabled the BAR allocating for this bridge. It took some time for me to guess that "hpiosize=0" can solve that. For MEM and MEM64 spaces it will be harder to reproduce the same, but there can be a similar problem when fitting between two immovable BARs. To implement a fallback it would need to add some flag indicating that allocating this bridge with reserved spaces has failed, so its windows should be recalculated without reserved spaces - and try again. Maybe even two types of retrials: with and without the full re-assignment. We've tried to avoid adding execution paths and code complicatedness. Serge >> Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> >> --- >> drivers/pci/setup-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c >> index c7b7e30c6284..7d64ec8e7088 100644 >> --- a/drivers/pci/setup-bus.c >> +++ b/drivers/pci/setup-bus.c >> @@ -1287,7 +1287,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) >> >> case PCI_HEADER_TYPE_BRIDGE: >> pci_bridge_check_ranges(bus); >> - if (bus->self->is_hotplug_bridge) { >> + if (bus->self->is_hotplug_bridge && !pci_movable_bars_enabled()) { >> additional_io_size = pci_hotplug_io_size; >> additional_mem_size = pci_hotplug_mem_size; >> } >
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> To: Oliver O'Halloran <oohall@gmail.com> Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>, linuxppc-dev@lists.ozlabs.org, linux@yadro.com Subject: Re: [PATCH v5 16/23] PCI: hotplug: movable BARs: Don't reserve IO/mem bus space Date: Wed, 4 Sep 2019 14:22:54 +0300 [thread overview] Message-ID: <e11fa8c6-4892-82a9-78ad-bc6bdb6f4037@yadro.com> (raw) In-Reply-To: <1edd23fd93386d8a69bc9280329b2d7c819155d4.camel@gmail.com> On 9/4/19 8:42 AM, Oliver O'Halloran wrote: > On Fri, 2019-08-16 at 19:50 +0300, Sergey Miroshnichenko wrote: >> A hotplugged bridge with many hotplug-capable ports may request >> reserving more IO space than the machine has. This could be overridden >> with the "hpiosize=" kernel argument though. >> >> But when BARs are movable, there are no need to reserve space anymore: >> new BARs are allocated not from reserved gaps, but via rearranging the >> existing BARs. Requesting a precise amount of space for bridge windows >> increases the chances of adding the new bridge successfully. > > It wouldn't hurt to reserve some memory space to prevent unnecessary > BAR shuffling at runtime. If it turns out that we need more space then > we can always fall back to re-assigning the whole tree. > Hi Oliver, Thank you for your comments! We had an issue on a x86_64 PC with a small amount of IO space: after hotplugging an empty bridge of 32 ports even a DEFAULT_HOTPLUG_IO_SIZE (which is 256) was enough to exhaust the space. So another patch of this series ("Don't allow added devices to steal resources") had disabled the BAR allocating for this bridge. It took some time for me to guess that "hpiosize=0" can solve that. For MEM and MEM64 spaces it will be harder to reproduce the same, but there can be a similar problem when fitting between two immovable BARs. To implement a fallback it would need to add some flag indicating that allocating this bridge with reserved spaces has failed, so its windows should be recalculated without reserved spaces - and try again. Maybe even two types of retrials: with and without the full re-assignment. We've tried to avoid adding execution paths and code complicatedness. Serge >> Signed-off-by: Sergey Miroshnichenko <s.miroshnichenko@yadro.com> >> --- >> drivers/pci/setup-bus.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c >> index c7b7e30c6284..7d64ec8e7088 100644 >> --- a/drivers/pci/setup-bus.c >> +++ b/drivers/pci/setup-bus.c >> @@ -1287,7 +1287,7 @@ void __pci_bus_size_bridges(struct pci_bus *bus, struct list_head *realloc_head) >> >> case PCI_HEADER_TYPE_BRIDGE: >> pci_bridge_check_ranges(bus); >> - if (bus->self->is_hotplug_bridge) { >> + if (bus->self->is_hotplug_bridge && !pci_movable_bars_enabled()) { >> additional_io_size = pci_hotplug_io_size; >> additional_mem_size = pci_hotplug_mem_size; >> } >
next prev parent reply other threads:[~2019-09-04 11:22 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-16 16:50 [PATCH v5 00/23] PCI: Allow BAR movement during hotplug Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 01/23] PCI: Fix race condition in pci_enable/disable_device() Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-22 12:37 ` Marta Rybczynska 2019-08-22 12:37 ` Marta Rybczynska 2019-09-27 21:59 ` Bjorn Helgaas 2019-09-27 21:59 ` Bjorn Helgaas 2019-09-30 8:53 ` Sergey Miroshnichenko 2019-09-30 8:53 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 02/23] PCI: Enable bridge's I/O and MEM access for hotplugged devices Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-09-27 22:01 ` Bjorn Helgaas 2019-08-16 16:50 ` [PATCH v5 03/23] PCI: hotplug: Add a flag for the movable BARs feature Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-09-27 22:02 ` Bjorn Helgaas 2019-09-27 22:02 ` Bjorn Helgaas 2019-09-30 8:44 ` David Laight 2019-09-30 16:17 ` Sergey Miroshnichenko 2019-09-30 12:59 ` Sergey Miroshnichenko 2019-09-30 12:59 ` Sergey Miroshnichenko 2019-10-15 22:14 ` Bjorn Helgaas 2019-10-15 22:14 ` Bjorn Helgaas 2019-10-16 15:50 ` Sergey Miroshnichenko 2019-10-16 15:50 ` Sergey Miroshnichenko 2019-10-16 17:29 ` Bjorn Helgaas 2019-10-16 17:29 ` Bjorn Helgaas 2019-08-16 16:50 ` [PATCH v5 04/23] PCI: Define PCI-specific version of the release_child_resources() Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 05/23] PCI: hotplug: movable BARs: Fix reassigning the released bridge windows Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 06/23] PCI: hotplug: movable BARs: Recalculate all bridge windows during rescan Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 07/23] PCI: hotplug: movable BARs: Don't allow added devices to steal resources Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 08/23] PCI: Include fixed and immovable BARs into the bus size calculating Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 09/23] PCI: Prohibit assigning BARs and bridge windows to non-direct parents Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 10/23] PCI: hotplug: movable BARs: Try to assign unassigned resources only once Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 11/23] PCI: hotplug: movable BARs: Calculate immovable parts of bridge windows Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 12/23] PCI: hotplug: movable BARs: Compute limits for relocated " Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 13/23] PCI: Make sure bridge windows include their fixed BARs Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 14/23] PCI: Fix assigning the fixed prefetchable resources Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 15/23] PCI: hotplug: movable BARs: Assign fixed and immovable BARs before others Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 16/23] PCI: hotplug: movable BARs: Don't reserve IO/mem bus space Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-09-04 5:42 ` Oliver O'Halloran 2019-09-04 5:42 ` Oliver O'Halloran 2019-09-04 11:22 ` Sergey Miroshnichenko [this message] 2019-09-04 11:22 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 17/23] powerpc/pci: Fix crash with enabled movable BARs Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 18/23] powerpc/pci: Handle BAR movement Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-09-04 5:37 ` Oliver O'Halloran 2019-09-04 5:37 ` Oliver O'Halloran 2019-09-06 16:24 ` Sergey Miroshnichenko 2019-09-06 16:24 ` Sergey Miroshnichenko 2019-09-09 14:02 ` Oliver O'Halloran 2019-09-09 14:02 ` Oliver O'Halloran 2019-08-16 16:50 ` [PATCH v5 19/23] PCI: hotplug: Configure MPS for hot-added bridges during bus rescan Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 20/23] PCI: hotplug: movable BARs: Enable the feature by default Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` [PATCH v5 21/23] nvme-pci: Handle movable BARs Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:50 ` Sergey Miroshnichenko 2019-08-16 16:51 ` [PATCH v5 22/23] PCI/portdrv: Declare support of " Sergey Miroshnichenko 2019-08-16 16:51 ` Sergey Miroshnichenko 2019-08-16 16:51 ` [PATCH v5 23/23] PCI: pciehp: movable BARs: Trigger a domain rescan on hp events Sergey Miroshnichenko 2019-08-16 16:51 ` Sergey Miroshnichenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e11fa8c6-4892-82a9-78ad-bc6bdb6f4037@yadro.com \ --to=s.miroshnichenko@yadro.com \ --cc=helgaas@kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux@yadro.com \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=oohall@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.