* [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking
@ 2020-03-23 11:41 Laurent Vivier
2020-03-23 11:45 ` Philippe Mathieu-Daudé
2020-03-23 15:38 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-03-23 11:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier
This is mostly a fix for in-tree build.
It removes errors on .d directories:
grep: ./.gitlab-ci.d: Is a directory
grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory
and improves performance by only checking <ARCH>-linux-user directories.
Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
configure | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 4f12cd01777e..da09c3589572 100755
--- a/configure
+++ b/configure
@@ -1910,9 +1910,9 @@ for arch in alpha hppa m68k xtensa sh4 microblaze arm ppc s390x sparc sparc64 \
# remove the file if it has been generated in the source directory
rm -f "${source_path}/linux-user/${arch}/syscall_nr.h"
# remove the dependency files
- find . -name "*.d" \
- -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} \; \
- -exec rm {} \;
+ test -d ${arch}-linux-user && find ${arch}-linux-user -type f -name "*.d" \
+ -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} \; \
+ -exec rm {} \;
done
if test -z "$python"
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking
2020-03-23 11:41 [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking Laurent Vivier
@ 2020-03-23 11:45 ` Philippe Mathieu-Daudé
2020-03-23 15:38 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-03-23 11:45 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
On 3/23/20 12:41 PM, Laurent Vivier wrote:
> This is mostly a fix for in-tree build.
>
> It removes errors on .d directories:
>
> grep: ./.gitlab-ci.d: Is a directory
> grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory
>
> and improves performance by only checking <ARCH>-linux-user directories.
>
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 4f12cd01777e..da09c3589572 100755
> --- a/configure
> +++ b/configure
> @@ -1910,9 +1910,9 @@ for arch in alpha hppa m68k xtensa sh4 microblaze arm ppc s390x sparc sparc64 \
> # remove the file if it has been generated in the source directory
> rm -f "${source_path}/linux-user/${arch}/syscall_nr.h"
> # remove the dependency files
> - find . -name "*.d" \
> - -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} \; \
> - -exec rm {} \;
> + test -d ${arch}-linux-user && find ${arch}-linux-user -type f -name "*.d" \
> + -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} \; \
> + -exec rm {} \;
> done
>
> if test -z "$python"
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking
2020-03-23 11:41 [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking Laurent Vivier
2020-03-23 11:45 ` Philippe Mathieu-Daudé
@ 2020-03-23 15:38 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2020-03-23 15:38 UTC (permalink / raw)
To: Laurent Vivier; +Cc: QEMU Developers
On Mon, 23 Mar 2020 at 11:42, Laurent Vivier <laurent@vivier.eu> wrote:
>
> This is mostly a fix for in-tree build.
>
> It removes errors on .d directories:
>
> grep: ./.gitlab-ci.d: Is a directory
> grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory
>
> and improves performance by only checking <ARCH>-linux-user directories.
>
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
Applied to master to fix the build errors for in-tree builds.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 11:41 [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking Laurent Vivier
2020-03-23 11:45 ` Philippe Mathieu-Daudé
2020-03-23 15:38 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.