All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sören Brinkmann" <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] i2c: cadence: fix Kconfig dependency
Date: Sun, 6 Apr 2014 15:13:18 -0700	[thread overview]
Message-ID: <e1274f35-df56-4e76-8e0d-c83a8b59f059@AM1EHSMHS009.ehs.local> (raw)
In-Reply-To: <1396811227-8851-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

Hi Wolfram,

On Sun, 2014-04-06 at 09:07PM +0200, Wolfram Sang wrote:
> During development, the driver first really needed to depend on
> COMMON_CLK only. Later, it was switched to writel_relaxed, but it was
> forgotten to update the dependencies, so build errors occured:
> 
> config: make ARCH=i386 allyesconfig
> 
> All error/warnings:
> 
>    drivers/i2c/busses/i2c-cadence.c: In function 'cdns_i2c_clear_bus_hold':
> >> drivers/i2c/busses/i2c-cadence.c:168:3: error: implicit declaration
> >> of function 'writel_relaxed' [-Werror=implicit-function-declaration]
> 
> Use a very safe dependency for now.

Thanks for taking care of this. Looks like the '_relaxed' IO helpers are
only available on ARM. I'll give that a try and might send a patch
eventually. I suspect 'ARM && COMMON_CLK' would work and be a little
less restrictive.

	Thanks,
	Sören

WARNING: multiple messages have this Message-ID (diff)
From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: cadence: fix Kconfig dependency
Date: Sun, 6 Apr 2014 15:13:18 -0700	[thread overview]
Message-ID: <e1274f35-df56-4e76-8e0d-c83a8b59f059@AM1EHSMHS009.ehs.local> (raw)
In-Reply-To: <1396811227-8851-1-git-send-email-wsa@the-dreams.de>

Hi Wolfram,

On Sun, 2014-04-06 at 09:07PM +0200, Wolfram Sang wrote:
> During development, the driver first really needed to depend on
> COMMON_CLK only. Later, it was switched to writel_relaxed, but it was
> forgotten to update the dependencies, so build errors occured:
> 
> config: make ARCH=i386 allyesconfig
> 
> All error/warnings:
> 
>    drivers/i2c/busses/i2c-cadence.c: In function 'cdns_i2c_clear_bus_hold':
> >> drivers/i2c/busses/i2c-cadence.c:168:3: error: implicit declaration
> >> of function 'writel_relaxed' [-Werror=implicit-function-declaration]
> 
> Use a very safe dependency for now.

Thanks for taking care of this. Looks like the '_relaxed' IO helpers are
only available on ARM. I'll give that a try and might send a patch
eventually. I suspect 'ARM && COMMON_CLK' would work and be a little
less restrictive.

	Thanks,
	S?ren

  parent reply	other threads:[~2014-04-06 22:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-06 19:07 [PATCH] i2c: cadence: fix Kconfig dependency Wolfram Sang
2014-04-06 19:07 ` Wolfram Sang
     [not found] ` <1396811227-8851-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-04-06 22:13   ` Sören Brinkmann [this message]
2014-04-06 22:13     ` Sören Brinkmann
2014-04-07  6:31 ` Uwe Kleine-König
2014-04-07  6:31   ` Uwe Kleine-König
2014-04-07  6:37   ` Alexander Shiyan
2014-04-07  6:37     ` Alexander Shiyan
     [not found]     ` <1396852656.682914397-OsTKtXgVMwVsdVUOrk1QfQ@public.gmane.org>
2014-04-07  6:56       ` Uwe Kleine-König
2014-04-07  6:56         ` Uwe Kleine-König
     [not found]         ` <20140407065657.GO29751-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-04-07  7:02           ` Alexander Shiyan
2014-04-07  7:02             ` Alexander Shiyan
     [not found]             ` <1396854155.872298456-PhO68MlTG7BsdVUOrk1QfQ@public.gmane.org>
2014-04-07 16:18               ` Sören Brinkmann
2014-04-07 16:18                 ` Sören Brinkmann
     [not found]                 ` <4c4d2ba5-f5f6-4589-8a48-6a88d1c16098-+Ck8Kgl/v09cIS6rUbAYerjjLBE8jN/0@public.gmane.org>
2014-05-21  8:29                   ` Wolfram Sang
2014-05-21  8:29                     ` Wolfram Sang
2014-05-21 16:00                     ` Sören Brinkmann
2014-05-21 16:00                       ` Sören Brinkmann
     [not found]                       ` <78a702ca-5001-444a-b2df-a64de17ffcb6-neA4ZlFjCT0GPAd83OwqBWYJ4DzVTqeXkX/xN29GLwg@public.gmane.org>
2014-05-22  4:58                         ` Michal Simek
2014-05-22  4:58                           ` Michal Simek
2014-04-07 15:36       ` Sören Brinkmann
2014-04-07 15:36         ` Sören Brinkmann
     [not found]         ` <dfab53fa-8b3c-4eb0-90b8-7df779ce68da-8XeO8fnFoNFDUMyIFHz4objjLBE8jN/0@public.gmane.org>
2014-04-07 17:50           ` Uwe Kleine-König
2014-04-07 17:50             ` Uwe Kleine-König
     [not found]   ` <20140407063100.GN29751-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-04-07  6:39     ` Michal Simek
2014-04-07  6:39       ` Michal Simek
     [not found]       ` <5342481B.6020600-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2014-04-07  6:56         ` Wolfram Sang
2014-04-07  6:56           ` Wolfram Sang
2014-04-07  7:00           ` Michal Simek
2014-04-07  7:00             ` Michal Simek
2014-04-08  8:33           ` Michal Simek
2014-04-08  8:33             ` Michal Simek
2014-04-07 15:37         ` Sören Brinkmann
2014-04-07 15:37           ` Sören Brinkmann
2014-04-07 16:14     ` Sören Brinkmann
2014-04-07 16:14       ` Sören Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1274f35-df56-4e76-8e0d-c83a8b59f059@AM1EHSMHS009.ehs.local \
    --to=soren.brinkmann-gjffaj9ahvfqt0dzr+alfa@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.