* [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-27 21:32 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2018-05-27 21:32 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Jaroslav Kysela, Takashi Iwai,
xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The negative error return from the call to to_sndif_format is being
assigned to an unsigned 8 bit integer and hence the check for a negative
value is always going to be false. Fix this by using ret as the error
return and hence the negative error can be detected and assign
the u8 sndif_format to ret if there is no error.
Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/xen/xen_snd_front_alsa.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..5a2bd70a2fa1 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
u8 sndif_format;
int ret;
- sndif_format = to_sndif_format(runtime->format);
- if (sndif_format < 0) {
+ ret = to_sndif_format(runtime->format);
+ if (ret < 0) {
dev_err(&stream->front_info->xb_dev->dev,
"Unsupported sample format: %d\n",
runtime->format);
- return sndif_format;
+ return ret;
}
+ sndif_format = ret;
ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
&stream->sh_buf,
--
2.17.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-27 21:32 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2018-05-27 21:32 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Jaroslav Kysela, Takashi Iwai,
xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The negative error return from the call to to_sndif_format is being
assigned to an unsigned 8 bit integer and hence the check for a negative
value is always going to be false. Fix this by using ret as the error
return and hence the negative error can be detected and assign
the u8 sndif_format to ret if there is no error.
Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/xen/xen_snd_front_alsa.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..5a2bd70a2fa1 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
u8 sndif_format;
int ret;
- sndif_format = to_sndif_format(runtime->format);
- if (sndif_format < 0) {
+ ret = to_sndif_format(runtime->format);
+ if (ret < 0) {
dev_err(&stream->front_info->xb_dev->dev,
"Unsupported sample format: %d\n",
runtime->format);
- return sndif_format;
+ return ret;
}
+ sndif_format = ret;
ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
&stream->sh_buf,
--
2.17.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
2018-05-27 21:32 ` Colin King
@ 2018-05-27 22:49 ` Takashi Sakamoto
-1 siblings, 0 replies; 10+ messages in thread
From: Takashi Sakamoto @ 2018-05-27 22:49 UTC (permalink / raw)
To: Colin King, Oleksandr Andrushchenko, Jaroslav Kysela,
Takashi Iwai, xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On May 28 2018 06:32, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The negative error return from the call to to_sndif_format is being
> assigned to an unsigned 8 bit integer and hence the check for a negative
> value is always going to be false. Fix this by using ret as the error
> return and hence the negative error can be detected and assign
> the u8 sndif_format to ret if there is no error.
>
> Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/xen/xen_snd_front_alsa.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..5a2bd70a2fa1 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> u8 sndif_format;
> int ret;
>
> - sndif_format = to_sndif_format(runtime->format);
> - if (sndif_format < 0) {
> + ret = to_sndif_format(runtime->format);
> + if (ret < 0) {
> dev_err(&stream->front_info->xb_dev->dev,
> "Unsupported sample format: %d\n",
> runtime->format);
> - return sndif_format;
> + return ret;
> }
> + sndif_format = ret;
>
> ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
> &stream->sh_buf,
Indeed. A typical assignment mistake. Instead, we could change the type
of 'sndif_format' to signed int, however in this case it's not the same
as the third argument of xen_snd_front_stream_prepare() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-27 22:49 ` Takashi Sakamoto
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Sakamoto @ 2018-05-27 22:49 UTC (permalink / raw)
To: Colin King, Oleksandr Andrushchenko, Jaroslav Kysela,
Takashi Iwai, xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On May 28 2018 06:32, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The negative error return from the call to to_sndif_format is being
> assigned to an unsigned 8 bit integer and hence the check for a negative
> value is always going to be false. Fix this by using ret as the error
> return and hence the negative error can be detected and assign
> the u8 sndif_format to ret if there is no error.
>
> Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/xen/xen_snd_front_alsa.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..5a2bd70a2fa1 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> u8 sndif_format;
> int ret;
>
> - sndif_format = to_sndif_format(runtime->format);
> - if (sndif_format < 0) {
> + ret = to_sndif_format(runtime->format);
> + if (ret < 0) {
> dev_err(&stream->front_info->xb_dev->dev,
> "Unsupported sample format: %d\n",
> runtime->format);
> - return sndif_format;
> + return ret;
> }
> + sndif_format = ret;
>
> ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
> &stream->sh_buf,
Indeed. A typical assignment mistake. Instead, we could change the type
of 'sndif_format' to signed int, however in this case it's not the same
as the third argument of xen_snd_front_stream_prepare() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
2018-05-27 21:32 ` Colin King
(?)
@ 2018-05-27 22:49 ` Takashi Sakamoto
-1 siblings, 0 replies; 10+ messages in thread
From: Takashi Sakamoto @ 2018-05-27 22:49 UTC (permalink / raw)
To: Colin King, Oleksandr Andrushchenko, Jaroslav Kysela,
Takashi Iwai, xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
Hi,
On May 28 2018 06:32, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The negative error return from the call to to_sndif_format is being
> assigned to an unsigned 8 bit integer and hence the check for a negative
> value is always going to be false. Fix this by using ret as the error
> return and hence the negative error can be detected and assign
> the u8 sndif_format to ret if there is no error.
>
> Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/xen/xen_snd_front_alsa.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..5a2bd70a2fa1 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> u8 sndif_format;
> int ret;
>
> - sndif_format = to_sndif_format(runtime->format);
> - if (sndif_format < 0) {
> + ret = to_sndif_format(runtime->format);
> + if (ret < 0) {
> dev_err(&stream->front_info->xb_dev->dev,
> "Unsupported sample format: %d\n",
> runtime->format);
> - return sndif_format;
> + return ret;
> }
> + sndif_format = ret;
>
> ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
> &stream->sh_buf,
Indeed. A typical assignment mistake. Instead, we could change the type
of 'sndif_format' to signed int, however in this case it's not the same
as the third argument of xen_snd_front_stream_prepare() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Regards
Takashi Sakamoto
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
2018-05-27 22:49 ` Takashi Sakamoto
(?)
@ 2018-05-28 9:30 ` Takashi Iwai
-1 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2018-05-28 9:30 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: alsa-devel, Colin King, Oleksandr Andrushchenko, xen-devel,
Jaroslav Kysela, kernel-janitors, linux-kernel
On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > value is always going to be false. Fix this by using ret as the error
> > return and hence the negative error can be detected and assign
> > the u8 sndif_format to ret if there is no error.
> >
> > Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/xen/xen_snd_front_alsa.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> > index 5041f83e98d2..5a2bd70a2fa1 100644
> > --- a/sound/xen/xen_snd_front_alsa.c
> > +++ b/sound/xen/xen_snd_front_alsa.c
> > @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> > u8 sndif_format;
> > int ret;
> > - sndif_format = to_sndif_format(runtime->format);
> > - if (sndif_format < 0) {
> > + ret = to_sndif_format(runtime->format);
> > + if (ret < 0) {
> > dev_err(&stream->front_info->xb_dev->dev,
> > "Unsupported sample format: %d\n",
> > runtime->format);
> > - return sndif_format;
> > + return ret;
> > }
> > + sndif_format = ret;
> > ret =
> > xen_snd_front_stream_prepare(&stream->evt_pair->req,
> > &stream->sh_buf,
>
> Indeed. A typical assignment mistake. Instead, we could change the
> type of 'sndif_format' to signed int, however in this case it's not
> the same as the third argument of xen_snd_front_stream_prepare()
> because it is 'u8'. This patch looks good to me.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-28 9:30 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2018-05-28 9:30 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: alsa-devel, Oleksandr Andrushchenko, kernel-janitors,
linux-kernel, xen-devel, Colin King
On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > value is always going to be false. Fix this by using ret as the error
> > return and hence the negative error can be detected and assign
> > the u8 sndif_format to ret if there is no error.
> >
> > Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/xen/xen_snd_front_alsa.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> > index 5041f83e98d2..5a2bd70a2fa1 100644
> > --- a/sound/xen/xen_snd_front_alsa.c
> > +++ b/sound/xen/xen_snd_front_alsa.c
> > @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> > u8 sndif_format;
> > int ret;
> > - sndif_format = to_sndif_format(runtime->format);
> > - if (sndif_format < 0) {
> > + ret = to_sndif_format(runtime->format);
> > + if (ret < 0) {
> > dev_err(&stream->front_info->xb_dev->dev,
> > "Unsupported sample format: %d\n",
> > runtime->format);
> > - return sndif_format;
> > + return ret;
> > }
> > + sndif_format = ret;
> > ret > > xen_snd_front_stream_prepare(&stream->evt_pair->req,
> > &stream->sh_buf,
>
> Indeed. A typical assignment mistake. Instead, we could change the
> type of 'sndif_format' to signed int, however in this case it's not
> the same as the third argument of xen_snd_front_stream_prepare()
> because it is 'u8'. This patch looks good to me.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-28 9:30 ` Takashi Iwai
0 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2018-05-28 9:30 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: alsa-devel, Oleksandr Andrushchenko, kernel-janitors,
linux-kernel, xen-devel, Colin King
On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > value is always going to be false. Fix this by using ret as the error
> > return and hence the negative error can be detected and assign
> > the u8 sndif_format to ret if there is no error.
> >
> > Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/xen/xen_snd_front_alsa.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> > index 5041f83e98d2..5a2bd70a2fa1 100644
> > --- a/sound/xen/xen_snd_front_alsa.c
> > +++ b/sound/xen/xen_snd_front_alsa.c
> > @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> > u8 sndif_format;
> > int ret;
> > - sndif_format = to_sndif_format(runtime->format);
> > - if (sndif_format < 0) {
> > + ret = to_sndif_format(runtime->format);
> > + if (ret < 0) {
> > dev_err(&stream->front_info->xb_dev->dev,
> > "Unsupported sample format: %d\n",
> > runtime->format);
> > - return sndif_format;
> > + return ret;
> > }
> > + sndif_format = ret;
> > ret =
> > xen_snd_front_stream_prepare(&stream->evt_pair->req,
> > &stream->sh_buf,
>
> Indeed. A typical assignment mistake. Instead, we could change the
> type of 'sndif_format' to signed int, however in this case it's not
> the same as the third argument of xen_snd_front_stream_prepare()
> because it is 'u8'. This patch looks good to me.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
2018-05-27 22:49 ` Takashi Sakamoto
(?)
@ 2018-05-28 9:30 ` Takashi Iwai
-1 siblings, 0 replies; 10+ messages in thread
From: Takashi Iwai @ 2018-05-28 9:30 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: alsa-devel, Oleksandr Andrushchenko, kernel-janitors,
linux-kernel, Jaroslav Kysela, xen-devel, Colin King
On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > value is always going to be false. Fix this by using ret as the error
> > return and hence the negative error can be detected and assign
> > the u8 sndif_format to ret if there is no error.
> >
> > Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > sound/xen/xen_snd_front_alsa.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> > index 5041f83e98d2..5a2bd70a2fa1 100644
> > --- a/sound/xen/xen_snd_front_alsa.c
> > +++ b/sound/xen/xen_snd_front_alsa.c
> > @@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
> > u8 sndif_format;
> > int ret;
> > - sndif_format = to_sndif_format(runtime->format);
> > - if (sndif_format < 0) {
> > + ret = to_sndif_format(runtime->format);
> > + if (ret < 0) {
> > dev_err(&stream->front_info->xb_dev->dev,
> > "Unsupported sample format: %d\n",
> > runtime->format);
> > - return sndif_format;
> > + return ret;
> > }
> > + sndif_format = ret;
> > ret =
> > xen_snd_front_stream_prepare(&stream->evt_pair->req,
> > &stream->sh_buf,
>
> Indeed. A typical assignment mistake. Instead, we could change the
> type of 'sndif_format' to signed int, however in this case it's not
> the same as the third argument of xen_snd_front_stream_prepare()
> because it is 'u8'. This patch looks good to me.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Applied, thanks.
Takashi
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format
@ 2018-05-27 21:32 Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2018-05-27 21:32 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Jaroslav Kysela, Takashi Iwai,
xen-devel, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The negative error return from the call to to_sndif_format is being
assigned to an unsigned 8 bit integer and hence the check for a negative
value is always going to be false. Fix this by using ret as the error
return and hence the negative error can be detected and assign
the u8 sndif_format to ret if there is no error.
Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/xen/xen_snd_front_alsa.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..5a2bd70a2fa1 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -466,13 +466,14 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
u8 sndif_format;
int ret;
- sndif_format = to_sndif_format(runtime->format);
- if (sndif_format < 0) {
+ ret = to_sndif_format(runtime->format);
+ if (ret < 0) {
dev_err(&stream->front_info->xb_dev->dev,
"Unsupported sample format: %d\n",
runtime->format);
- return sndif_format;
+ return ret;
}
+ sndif_format = ret;
ret = xen_snd_front_stream_prepare(&stream->evt_pair->req,
&stream->sh_buf,
--
2.17.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-05-28 15:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-27 21:32 [PATCH][next] ALSA: xen-front: fix unsigned error check on return from to_sndif_format Colin King
2018-05-27 21:32 ` Colin King
2018-05-27 22:49 ` Takashi Sakamoto
2018-05-27 22:49 ` Takashi Sakamoto
2018-05-27 22:49 ` Takashi Sakamoto
2018-05-28 9:30 ` Takashi Iwai
2018-05-28 9:30 ` Takashi Iwai
2018-05-28 9:30 ` Takashi Iwai
2018-05-28 9:30 ` Takashi Iwai
2018-05-27 21:32 Colin King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.