All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
@ 2022-02-25 10:15 ` Aashish Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Aashish Sharma @ 2022-02-25 10:15 UTC (permalink / raw)
  To: Lee Jones, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches
  Cc: linux-arm-kernel, linux-kernel, groeck, Aashish Sharma

Fix this kernel test robot warning:

drivers/mfd/atmel-flexcom.c:108:32: warning: unused
variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]

The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
is not selected, so marking it as __maybe_unsed.

Signed-off-by: Aashish Sharma <shraash@google.com>
---
 drivers/mfd/atmel-flexcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 559eb4d352b6..33caa4fba6af 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
 	return 0;
 }
 
-static const struct dev_pm_ops atmel_flexcom_pm_ops = {
+static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
 	.resume_noirq = atmel_flexcom_resume_noirq,
 };
 
-- 
2.35.1.574.g5d30c73bfb-goog


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
@ 2022-02-25 10:15 ` Aashish Sharma
  0 siblings, 0 replies; 8+ messages in thread
From: Aashish Sharma @ 2022-02-25 10:15 UTC (permalink / raw)
  To: Lee Jones, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches
  Cc: linux-arm-kernel, linux-kernel, groeck, Aashish Sharma

Fix this kernel test robot warning:

drivers/mfd/atmel-flexcom.c:108:32: warning: unused
variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]

The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
is not selected, so marking it as __maybe_unsed.

Signed-off-by: Aashish Sharma <shraash@google.com>
---
 drivers/mfd/atmel-flexcom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 559eb4d352b6..33caa4fba6af 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
 	return 0;
 }
 
-static const struct dev_pm_ops atmel_flexcom_pm_ops = {
+static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
 	.resume_noirq = atmel_flexcom_resume_noirq,
 };
 
-- 
2.35.1.574.g5d30c73bfb-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
  2022-02-25 10:15 ` Aashish Sharma
@ 2022-02-25 19:00   ` Guenter Roeck
  -1 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2022-02-25 19:00 UTC (permalink / raw)
  To: Aashish Sharma
  Cc: Lee Jones, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
	moderated list:ARM PORT, linux-kernel, Guenter Roeck

On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
>
> Fix this kernel test robot warning:
>
> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>
> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> is not selected, so marking it as __maybe_unsed.
>
> Signed-off-by: Aashish Sharma <shraash@google.com>

Reviewed-by: Guenter Roeck <groeck@google.com>

> ---
>  drivers/mfd/atmel-flexcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 559eb4d352b6..33caa4fba6af 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>         return 0;
>  }
>
> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>         .resume_noirq = atmel_flexcom_resume_noirq,
>  };
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
@ 2022-02-25 19:00   ` Guenter Roeck
  0 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2022-02-25 19:00 UTC (permalink / raw)
  To: Aashish Sharma
  Cc: Alexandre Belloni, linux-kernel, Ludovic Desroches,
	Guenter Roeck, Lee Jones, moderated list:ARM PORT

On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
>
> Fix this kernel test robot warning:
>
> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>
> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> is not selected, so marking it as __maybe_unsed.
>
> Signed-off-by: Aashish Sharma <shraash@google.com>

Reviewed-by: Guenter Roeck <groeck@google.com>

> ---
>  drivers/mfd/atmel-flexcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 559eb4d352b6..33caa4fba6af 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>         return 0;
>  }
>
> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>         .resume_noirq = atmel_flexcom_resume_noirq,
>  };
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
  2022-02-25 19:00   ` Guenter Roeck
@ 2022-02-28  7:36     ` Claudiu.Beznea
  -1 siblings, 0 replies; 8+ messages in thread
From: Claudiu.Beznea @ 2022-02-28  7:36 UTC (permalink / raw)
  To: groeck, shraash
  Cc: alexandre.belloni, linux-kernel, Ludovic.Desroches, groeck,
	lee.jones, linux-arm-kernel

On 25.02.2022 21:00, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
>>
>> Fix this kernel test robot warning:
>>
>> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
>> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>>
>> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
>> is not selected, so marking it as __maybe_unsed.
>>
>> Signed-off-by: Aashish Sharma <shraash@google.com>
> 
> Reviewed-by: Guenter Roeck <groeck@google.com>

There is already [1] posted a while ago...

[1] https://lkml.org/lkml/2021/12/7/474

> 
>> ---
>>  drivers/mfd/atmel-flexcom.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
>> index 559eb4d352b6..33caa4fba6af 100644
>> --- a/drivers/mfd/atmel-flexcom.c
>> +++ b/drivers/mfd/atmel-flexcom.c
>> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>>         return 0;
>>  }
>>
>> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>>         .resume_noirq = atmel_flexcom_resume_noirq,
>>  };
>>
>> --
>> 2.35.1.574.g5d30c73bfb-goog
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
@ 2022-02-28  7:36     ` Claudiu.Beznea
  0 siblings, 0 replies; 8+ messages in thread
From: Claudiu.Beznea @ 2022-02-28  7:36 UTC (permalink / raw)
  To: groeck, shraash
  Cc: alexandre.belloni, linux-kernel, Ludovic.Desroches, groeck,
	lee.jones, linux-arm-kernel

On 25.02.2022 21:00, Guenter Roeck wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
>>
>> Fix this kernel test robot warning:
>>
>> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
>> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
>>
>> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
>> is not selected, so marking it as __maybe_unsed.
>>
>> Signed-off-by: Aashish Sharma <shraash@google.com>
> 
> Reviewed-by: Guenter Roeck <groeck@google.com>

There is already [1] posted a while ago...

[1] https://lkml.org/lkml/2021/12/7/474

> 
>> ---
>>  drivers/mfd/atmel-flexcom.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
>> index 559eb4d352b6..33caa4fba6af 100644
>> --- a/drivers/mfd/atmel-flexcom.c
>> +++ b/drivers/mfd/atmel-flexcom.c
>> @@ -105,7 +105,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>>         return 0;
>>  }
>>
>> -static const struct dev_pm_ops atmel_flexcom_pm_ops = {
>> +static const struct dev_pm_ops __maybe_unused atmel_flexcom_pm_ops = {
>>         .resume_noirq = atmel_flexcom_resume_noirq,
>>  };
>>
>> --
>> 2.35.1.574.g5d30c73bfb-goog
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
  2022-02-28  7:36     ` Claudiu.Beznea
@ 2022-02-28  8:15       ` Lee Jones
  -1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-02-28  8:15 UTC (permalink / raw)
  To: Claudiu.Beznea
  Cc: groeck, shraash, alexandre.belloni, linux-kernel,
	Ludovic.Desroches, groeck, linux-arm-kernel

On Mon, 28 Feb 2022, Claudiu.Beznea@microchip.com wrote:

> On 25.02.2022 21:00, Guenter Roeck wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
> >>
> >> Fix this kernel test robot warning:
> >>
> >> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> >> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
> >>
> >> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> >> is not selected, so marking it as __maybe_unsed.
> >>
> >> Signed-off-by: Aashish Sharma <shraash@google.com>
> > 
> > Reviewed-by: Guenter Roeck <groeck@google.com>
> 
> There is already [1] posted a while ago...
> 
> [1] https://lkml.org/lkml/2021/12/7/474

Lost in the ether!

If this happens again, please resubmit a [RESEND].

Applied now though, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning
@ 2022-02-28  8:15       ` Lee Jones
  0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2022-02-28  8:15 UTC (permalink / raw)
  To: Claudiu.Beznea
  Cc: groeck, shraash, alexandre.belloni, linux-kernel,
	Ludovic.Desroches, groeck, linux-arm-kernel

On Mon, 28 Feb 2022, Claudiu.Beznea@microchip.com wrote:

> On 25.02.2022 21:00, Guenter Roeck wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Fri, Feb 25, 2022 at 2:15 AM Aashish Sharma <shraash@google.com> wrote:
> >>
> >> Fix this kernel test robot warning:
> >>
> >> drivers/mfd/atmel-flexcom.c:108:32: warning: unused
> >> variable 'atmel_flexcom_pm_ops' [-Wunused-const-variable]
> >>
> >> The variable atmel_flexcom_pm_ops is unused when CONFIG_PM
> >> is not selected, so marking it as __maybe_unsed.
> >>
> >> Signed-off-by: Aashish Sharma <shraash@google.com>
> > 
> > Reviewed-by: Guenter Roeck <groeck@google.com>
> 
> There is already [1] posted a while ago...
> 
> [1] https://lkml.org/lkml/2021/12/7/474

Lost in the ether!

If this happens again, please resubmit a [RESEND].

Applied now though, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-28  8:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 10:15 [PATCH] mfd: Avoid unused variable 'atmel_flexcom_pm_ops' warning Aashish Sharma
2022-02-25 10:15 ` Aashish Sharma
2022-02-25 19:00 ` Guenter Roeck
2022-02-25 19:00   ` Guenter Roeck
2022-02-28  7:36   ` Claudiu.Beznea
2022-02-28  7:36     ` Claudiu.Beznea
2022-02-28  8:15     ` Lee Jones
2022-02-28  8:15       ` Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.