All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Raviteja Garimella <raviteja.garimella@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, linux-usb@vger.kernel.org
Subject: Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver
Date: Wed, 18 Jan 2017 10:45:39 -0800	[thread overview]
Message-ID: <e1453122-164a-e1a8-6aa6-fb25eb33101f@gmail.com> (raw)
In-Reply-To: <1484640308-25976-2-git-send-email-raviteja.garimella@broadcom.com>

On 01/17/2017 12:05 AM, Raviteja Garimella wrote:
> This patch splits the amd5536udc driver into two -- one that does
> pci device registration and the other file that does the rest of
> the driver tasks like the gadget/ep ops etc for Synopsys UDC.
> 
> This way of splitting helps in exporting core driver symbols which
> can be used by any other platform/pci driver that is written for
> the same Synopsys USB device controller.
> 
> The current patch also includes a change in the Kconfig and Makefile.
> A new config option USB_SNP_CORE will be selected automatically when
> any one of the platform or pci driver for the same UDC is selected.
> 
> Signed-off-by: Raviteja Garimella <raviteja.garimella@broadcom.com>

Although the changes you have done make sense and it is most certainly a
good idea to split udc core from bus specific glue logic, it is really
hard to review the changes per-se because of the file rename, could that
happen at a later time?

Also, keep in mind that anytime a driver file is renamed, this poses a
backport/maintenance issue where backporting fixes from latest upstream
to a kernel version that has a different file/directory structure is a
major pain.
-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Raviteja Garimella
	<raviteja.garimella-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver
Date: Wed, 18 Jan 2017 10:45:39 -0800	[thread overview]
Message-ID: <e1453122-164a-e1a8-6aa6-fb25eb33101f@gmail.com> (raw)
In-Reply-To: <1484640308-25976-2-git-send-email-raviteja.garimella-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

On 01/17/2017 12:05 AM, Raviteja Garimella wrote:
> This patch splits the amd5536udc driver into two -- one that does
> pci device registration and the other file that does the rest of
> the driver tasks like the gadget/ep ops etc for Synopsys UDC.
> 
> This way of splitting helps in exporting core driver symbols which
> can be used by any other platform/pci driver that is written for
> the same Synopsys USB device controller.
> 
> The current patch also includes a change in the Kconfig and Makefile.
> A new config option USB_SNP_CORE will be selected automatically when
> any one of the platform or pci driver for the same UDC is selected.
> 
> Signed-off-by: Raviteja Garimella <raviteja.garimella-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

Although the changes you have done make sense and it is most certainly a
good idea to split udc core from bus specific glue logic, it is really
hard to review the changes per-se because of the file rename, could that
happen at a later time?

Also, keep in mind that anytime a driver file is renamed, this poses a
backport/maintenance issue where backporting fixes from latest upstream
to a kernel version that has a different file/directory structure is a
major pain.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-01-18 18:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  8:05 [RFC v2 0/5] Platform driver support for 'amd5536udc' driver Raviteja Garimella
2017-01-17  8:05 ` Raviteja Garimella
2017-01-17  8:05 ` [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver Raviteja Garimella
2017-01-17  8:05   ` Raviteja Garimella
2017-01-18 18:45   ` Florian Fainelli [this message]
2017-01-18 18:45     ` Florian Fainelli
2017-01-18 20:18     ` Greg Kroah-Hartman
2017-01-19 10:44     ` Raviteja Garimella
2017-01-19 10:44       ` Raviteja Garimella
2017-01-19 19:28       ` Florian Fainelli
2017-01-19 19:28         ` Florian Fainelli
2017-01-23 13:05         ` Raviteja Garimella
2017-01-17  8:05 ` [RFC v2 2/5] UDC: make debug prints compatible with both pci and platform devices Raviteja Garimella
2017-01-17  8:05 ` [RFC v2 3/5] UDC: Provide correct arguments for 'dma_pool_create' Raviteja Garimella
2017-01-17  8:05 ` [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Raviteja Garimella
2017-01-17  8:05   ` Raviteja Garimella
2017-01-19 17:36   ` Rob Herring
2017-01-19 17:36     ` Rob Herring
2017-01-19 19:30     ` Scott Branden
2017-01-19 19:40       ` Florian Fainelli
2017-01-19 20:07         ` Scott Branden
2017-01-19 20:07           ` Scott Branden
2017-01-19 20:17           ` Florian Fainelli
2017-01-19 21:55             ` Ray Jui
2017-01-19 21:55               ` Ray Jui
2017-01-19 22:36               ` Scott Branden
2017-01-19 22:36                 ` Scott Branden
2017-01-19 22:56                 ` Florian Fainelli
2017-01-19 22:56                   ` Florian Fainelli
2017-01-20 13:58                   ` Rob Herring
2017-01-20 13:58                     ` Rob Herring
2017-01-20 11:52     ` Raviteja Garimella
2017-01-20 11:52       ` Raviteja Garimella
2017-01-17  8:05 ` [RFC v2 5/5] UDC: Add Synopsys UDC Platform driver Raviteja Garimella
2017-01-17  8:05   ` Raviteja Garimella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1453122-164a-e1a8-6aa6-fb25eb33101f@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=balbi@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=raviteja.garimella@broadcom.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.