Re: [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()

From: Paolo Bonzini <pbonzini@redhat.com>
To: Zeng Guang <guang.zeng@intel.com>, kvm@vger.kernel.org
Cc: Robert Hu <robert.hu@intel.com>, Gao Chao <chao.gao@intel.com>,
	Chen Farrah <farrah.chen@intel.com>,
	Wei Danmei <danmei.wei@intel.com>
Subject: Re: [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()
Date: Wed, 4 May 2022 21:12:14 +0200	[thread overview]
Message-ID: <e17f9866-dfd0-da08-6128-852f7346b8a1@redhat.com> (raw)
In-Reply-To: <20220504032102.15062-1-guang.zeng@intel.com>

On 5/4/22 05:21, Zeng Guang wrote:
> Change function claim to static.
> Report warning: no previous prototype for 'vmx_get_pid_table_order'
> [-Wmissing-prototypes].
> 
> Fixes: 101c99f6506d ("KVM: VMX: enable IPI virtualization")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Zeng Guang <guang.zeng@intel.com>
> ---
> Paolo, could you please merge this fix into commit 101c99f6506d ("KVM:
> VMX: enable IPI virtualization") in kvm/queue? Sorry for such mistake.
> 
>   arch/x86/kvm/vmx/vmx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index bb09fc9a7e55..2065babb2c9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -4402,7 +4402,7 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx)
>   	return exec_control;
>   }
>   
> -int vmx_get_pid_table_order(struct kvm *kvm)
> +static int vmx_get_pid_table_order(struct kvm *kvm)
>   {
>   	return get_order(kvm->arch.max_vcpu_ids * sizeof(*to_kvm_vmx(kvm)->pid_table));
>   }

Yup, done.

Paolo