All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-gvt-dev@lists.freedesktop.org" 
	<intel-gvt-dev@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>,
	"Xu, Terrence" <terrence.xu@intel.com>
Subject: Re: [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API
Date: Fri, 17 Dec 2021 08:52:53 +0000	[thread overview]
Message-ID: <e183b95f-89d1-3a2f-27e2-82aa2b10e8fc@intel.com> (raw)
In-Reply-To: <20211130164622.GA15150@lst.de>

On 11/30/2021 6:46 PM, Christoph Hellwig wrote:
> I still think this goes into the wrong direction.
>
> Something closer to your first version that also saves away the
> gvt->mmio.mmio_attribute flags in the core i915 module, and which
> splits the MMIO table into one that contains just the offset, size
> and flags (core i915) and one that has the read-only mask and handlers
> (gvt) would be much simpler and not create this super-tight coupling
> between core i915 and gvt.
>
> Bonus points for moving your new intel_gvt_hw_state structure out
> of struct intel_gvt and into struct i915_virtual_gpu.

Hi Christoph:

Sorry for the late reply as I am supporting the customers recently. I 
will refresh this after the christmas.

Thanks,

Zhi.


WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API
Date: Fri, 17 Dec 2021 08:52:53 +0000	[thread overview]
Message-ID: <e183b95f-89d1-3a2f-27e2-82aa2b10e8fc@intel.com> (raw)
In-Reply-To: <20211130164622.GA15150@lst.de>

On 11/30/2021 6:46 PM, Christoph Hellwig wrote:
> I still think this goes into the wrong direction.
>
> Something closer to your first version that also saves away the
> gvt->mmio.mmio_attribute flags in the core i915 module, and which
> splits the MMIO table into one that contains just the offset, size
> and flags (core i915) and one that has the read-only mask and handlers
> (gvt) would be much simpler and not create this super-tight coupling
> between core i915 and gvt.
>
> Bonus points for moving your new intel_gvt_hw_state structure out
> of struct intel_gvt and into struct i915_virtual_gpu.

Hi Christoph:

Sorry for the late reply as I am supporting the customers recently. I 
will refresh this after the christmas.

Thanks,

Zhi.


WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Christoph Hellwig <hch@lst.de>, Zhi Wang <zhi.wang.linux@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Xu,  Terrence" <terrence.xu@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Jason Gunthorpe <jgg@nvidia.com>,
	"intel-gvt-dev@lists.freedesktop.org"
	<intel-gvt-dev@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API
Date: Fri, 17 Dec 2021 08:52:53 +0000	[thread overview]
Message-ID: <e183b95f-89d1-3a2f-27e2-82aa2b10e8fc@intel.com> (raw)
In-Reply-To: <20211130164622.GA15150@lst.de>

On 11/30/2021 6:46 PM, Christoph Hellwig wrote:
> I still think this goes into the wrong direction.
>
> Something closer to your first version that also saves away the
> gvt->mmio.mmio_attribute flags in the core i915 module, and which
> splits the MMIO table into one that contains just the offset, size
> and flags (core i915) and one that has the read-only mask and handlers
> (gvt) would be much simpler and not create this super-tight coupling
> between core i915 and gvt.
>
> Bonus points for moving your new intel_gvt_hw_state structure out
> of struct intel_gvt and into struct i915_virtual_gpu.

Hi Christoph:

Sorry for the late reply as I am supporting the customers recently. I 
will refresh this after the christmas.

Thanks,

Zhi.


  reply	other threads:[~2021-12-17  8:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 12:38 [PATCH v4 1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API Zhi Wang
2021-11-29 12:38 ` Zhi Wang
2021-11-29 12:38 ` [Intel-gfx] " Zhi Wang
2021-11-29 12:38 ` [PATCH v4 2/2] i915/gvt: save the MMIO snapshot in the early init of GVT-g Zhi Wang
2021-11-29 12:38   ` Zhi Wang
2021-11-29 12:38   ` [Intel-gfx] " Zhi Wang
2021-11-29 12:56 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/2] i915/gvt: Introduce the mmio_info_table.c to support VFIO new mdev API Patchwork
2021-11-29 13:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-11-29 14:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-11-30 16:46 ` [PATCH v4 1/2] " Christoph Hellwig
2021-11-30 16:46   ` [Intel-gfx] " Christoph Hellwig
2021-12-17  8:52   ` Wang, Zhi A [this message]
2021-12-17  8:52     ` Wang, Zhi A
2021-12-17  8:52     ` Wang, Zhi A
2022-01-24  9:40     ` Christoph Hellwig
2022-01-24  9:40       ` [Intel-gfx] " Christoph Hellwig
2022-01-24 10:12       ` zhi.wang.linux
2022-01-24 10:12         ` [Intel-gfx] " zhi.wang.linux
2022-01-24 10:12         ` zhi.wang.linux
2022-01-24 13:18         ` Jason Gunthorpe
2022-01-24 13:18           ` [Intel-gfx] " Jason Gunthorpe
2022-01-24 13:18           ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e183b95f-89d1-3a2f-27e2-82aa2b10e8fc@intel.com \
    --to=zhi.a.wang@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@nvidia.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=terrence.xu@intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.wang.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.