* [PATCH v3 0/2] clk: davinci: pll-dm355: fix SYSCLKn parent names @ 2018-05-09 15:36 ` David Lechner 0 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-clk, linux-arm-kernel Cc: David Lechner, Sekhar Nori, Michael Turquette, Stephen Boyd, linux-kernel v3 changes: * swap order of patches v2 changes: * add new patch to remove non-existent PLL2 SYSCLK2 David Lechner (2): clk: davinci: pll-dm355: drop pll2_sysclk2 clk: davinci: pll-dm355: fix SYSCLKn parent names drivers/clk/davinci/pll-dm355.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.17.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 0/2] clk: davinci: pll-dm355: fix SYSCLKn parent names @ 2018-05-09 15:36 ` David Lechner 0 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-arm-kernel v3 changes: * swap order of patches v2 changes: * add new patch to remove non-existent PLL2 SYSCLK2 David Lechner (2): clk: davinci: pll-dm355: drop pll2_sysclk2 clk: davinci: pll-dm355: fix SYSCLKn parent names drivers/clk/davinci/pll-dm355.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) -- 2.17.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2 2018-05-09 15:36 ` David Lechner @ 2018-05-09 15:36 ` David Lechner -1 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-clk, linux-arm-kernel Cc: David Lechner, Sekhar Nori, Michael Turquette, Stephen Boyd, linux-kernel This removes pll2_sysclk2 from the TI DM355 clock driver. This SoC doesn't have such a clock. Also, SYSCLK_ALWAYS_ENABLED is transferred to pll2_sysclk1 since it drives the DDR and doesn't have another mechanism to keep it on. Reported-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: David Lechner <david@lechnology.com> --- drivers/clk/davinci/pll-dm355.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/davinci/pll-dm355.c b/drivers/clk/davinci/pll-dm355.c index 5345f8286c50..718d9bbbf30d 100644 --- a/drivers/clk/davinci/pll-dm355.c +++ b/drivers/clk/davinci/pll-dm355.c @@ -62,8 +62,7 @@ static const struct davinci_pll_clk_info dm355_pll2_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV); -SYSCLK(2, pll2_sysclk2, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); int dm355_pll2_init(struct device *dev, void __iomem *base) { @@ -71,8 +70,6 @@ int dm355_pll2_init(struct device *dev, void __iomem *base) davinci_pll_sysclk_register(dev, &pll2_sysclk1, base); - davinci_pll_sysclk_register(dev, &pll2_sysclk2, base); - davinci_pll_sysclkbp_clk_register(dev, "pll2_sysclkbp", base); return 0; -- 2.17.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2 @ 2018-05-09 15:36 ` David Lechner 0 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-arm-kernel This removes pll2_sysclk2 from the TI DM355 clock driver. This SoC doesn't have such a clock. Also, SYSCLK_ALWAYS_ENABLED is transferred to pll2_sysclk1 since it drives the DDR and doesn't have another mechanism to keep it on. Reported-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: David Lechner <david@lechnology.com> --- drivers/clk/davinci/pll-dm355.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/davinci/pll-dm355.c b/drivers/clk/davinci/pll-dm355.c index 5345f8286c50..718d9bbbf30d 100644 --- a/drivers/clk/davinci/pll-dm355.c +++ b/drivers/clk/davinci/pll-dm355.c @@ -62,8 +62,7 @@ static const struct davinci_pll_clk_info dm355_pll2_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV); -SYSCLK(2, pll2_sysclk2, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); int dm355_pll2_init(struct device *dev, void __iomem *base) { @@ -71,8 +70,6 @@ int dm355_pll2_init(struct device *dev, void __iomem *base) davinci_pll_sysclk_register(dev, &pll2_sysclk1, base); - davinci_pll_sysclk_register(dev, &pll2_sysclk2, base); - davinci_pll_sysclkbp_clk_register(dev, "pll2_sysclkbp", base); return 0; -- 2.17.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2 2018-05-09 15:36 ` David Lechner @ 2018-05-10 15:29 ` Sekhar Nori -1 siblings, 0 replies; 10+ messages in thread From: Sekhar Nori @ 2018-05-10 15:29 UTC (permalink / raw) To: David Lechner, linux-clk, linux-arm-kernel Cc: Michael Turquette, Stephen Boyd, linux-kernel On Wednesday 09 May 2018 09:06 PM, David Lechner wrote: > This removes pll2_sysclk2 from the TI DM355 clock driver. This SoC > doesn't have such a clock. Also, SYSCLK_ALWAYS_ENABLED is transferred > to pll2_sysclk1 since it drives the DDR and doesn't have another > mechanism to keep it on. > > Reported-by: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: David Lechner <david@lechnology.com> I would not have minded the SYSCLK_ALWAYS_ENABLED change to be a separate patch too, but: Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2 @ 2018-05-10 15:29 ` Sekhar Nori 0 siblings, 0 replies; 10+ messages in thread From: Sekhar Nori @ 2018-05-10 15:29 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 09 May 2018 09:06 PM, David Lechner wrote: > This removes pll2_sysclk2 from the TI DM355 clock driver. This SoC > doesn't have such a clock. Also, SYSCLK_ALWAYS_ENABLED is transferred > to pll2_sysclk1 since it drives the DDR and doesn't have another > mechanism to keep it on. > > Reported-by: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: David Lechner <david@lechnology.com> I would not have minded the SYSCLK_ALWAYS_ENABLED change to be a separate patch too, but: Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names 2018-05-09 15:36 ` David Lechner @ 2018-05-09 15:36 ` David Lechner -1 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-clk, linux-arm-kernel Cc: David Lechner, Sekhar Nori, Michael Turquette, Stephen Boyd, linux-kernel This fixes the parent clock names of the SYSCLKn clocks for the DM355 SoC in the TI DaVinici PLL clock driver. It appears that this name just didn't get updated to the correct name like the other SoCs during the driver's development. Reported-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: David Lechner <david@lechnology.com> --- drivers/clk/davinci/pll-dm355.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/davinci/pll-dm355.c b/drivers/clk/davinci/pll-dm355.c index 718d9bbbf30d..93f4a53d6b44 100644 --- a/drivers/clk/davinci/pll-dm355.c +++ b/drivers/clk/davinci/pll-dm355.c @@ -22,10 +22,10 @@ static const struct davinci_pll_clk_info dm355_pll1_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll1_sysclk1, pll1, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); -SYSCLK(2, pll1_sysclk2, pll1, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); -SYSCLK(3, pll1_sysclk3, pll1, 5, SYSCLK_ALWAYS_ENABLED); -SYSCLK(4, pll1_sysclk4, pll1, 5, SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll1_sysclk1, pll1_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(2, pll1_sysclk2, pll1_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(3, pll1_sysclk3, pll1_pllen, 5, SYSCLK_ALWAYS_ENABLED); +SYSCLK(4, pll1_sysclk4, pll1_pllen, 5, SYSCLK_ALWAYS_ENABLED); int dm355_pll1_init(struct device *dev, void __iomem *base) { @@ -62,7 +62,7 @@ static const struct davinci_pll_clk_info dm355_pll2_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll2_sysclk1, pll2_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); int dm355_pll2_init(struct device *dev, void __iomem *base) { -- 2.17.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names @ 2018-05-09 15:36 ` David Lechner 0 siblings, 0 replies; 10+ messages in thread From: David Lechner @ 2018-05-09 15:36 UTC (permalink / raw) To: linux-arm-kernel This fixes the parent clock names of the SYSCLKn clocks for the DM355 SoC in the TI DaVinici PLL clock driver. It appears that this name just didn't get updated to the correct name like the other SoCs during the driver's development. Reported-by: Sekhar Nori <nsekhar@ti.com> Signed-off-by: David Lechner <david@lechnology.com> --- drivers/clk/davinci/pll-dm355.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/davinci/pll-dm355.c b/drivers/clk/davinci/pll-dm355.c index 718d9bbbf30d..93f4a53d6b44 100644 --- a/drivers/clk/davinci/pll-dm355.c +++ b/drivers/clk/davinci/pll-dm355.c @@ -22,10 +22,10 @@ static const struct davinci_pll_clk_info dm355_pll1_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll1_sysclk1, pll1, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); -SYSCLK(2, pll1_sysclk2, pll1, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); -SYSCLK(3, pll1_sysclk3, pll1, 5, SYSCLK_ALWAYS_ENABLED); -SYSCLK(4, pll1_sysclk4, pll1, 5, SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll1_sysclk1, pll1_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(2, pll1_sysclk2, pll1_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(3, pll1_sysclk3, pll1_pllen, 5, SYSCLK_ALWAYS_ENABLED); +SYSCLK(4, pll1_sysclk4, pll1_pllen, 5, SYSCLK_ALWAYS_ENABLED); int dm355_pll1_init(struct device *dev, void __iomem *base) { @@ -62,7 +62,7 @@ static const struct davinci_pll_clk_info dm355_pll2_info = { PLL_POSTDIV_ALWAYS_ENABLED | PLL_POSTDIV_FIXED_DIV, }; -SYSCLK(1, pll2_sysclk1, pll2, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); +SYSCLK(1, pll2_sysclk1, pll2_pllen, 5, SYSCLK_FIXED_DIV | SYSCLK_ALWAYS_ENABLED); int dm355_pll2_init(struct device *dev, void __iomem *base) { -- 2.17.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names 2018-05-09 15:36 ` David Lechner @ 2018-05-10 15:30 ` Sekhar Nori -1 siblings, 0 replies; 10+ messages in thread From: Sekhar Nori @ 2018-05-10 15:30 UTC (permalink / raw) To: David Lechner, linux-clk, linux-arm-kernel Cc: Michael Turquette, Stephen Boyd, linux-kernel On Wednesday 09 May 2018 09:06 PM, David Lechner wrote: > This fixes the parent clock names of the SYSCLKn clocks for the DM355 > SoC in the TI DaVinici PLL clock driver. > > It appears that this name just didn't get updated to the correct name > like the other SoCs during the driver's development. > > Reported-by: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: David Lechner <david@lechnology.com> Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names @ 2018-05-10 15:30 ` Sekhar Nori 0 siblings, 0 replies; 10+ messages in thread From: Sekhar Nori @ 2018-05-10 15:30 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 09 May 2018 09:06 PM, David Lechner wrote: > This fixes the parent clock names of the SYSCLKn clocks for the DM355 > SoC in the TI DaVinici PLL clock driver. > > It appears that this name just didn't get updated to the correct name > like the other SoCs during the driver's development. > > Reported-by: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: David Lechner <david@lechnology.com> Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-05-10 15:31 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-09 15:36 [PATCH v3 0/2] clk: davinci: pll-dm355: fix SYSCLKn parent names David Lechner 2018-05-09 15:36 ` David Lechner 2018-05-09 15:36 ` [PATCH v3 1/2] clk: davinci: pll-dm355: drop pll2_sysclk2 David Lechner 2018-05-09 15:36 ` David Lechner 2018-05-10 15:29 ` Sekhar Nori 2018-05-10 15:29 ` Sekhar Nori 2018-05-09 15:36 ` [PATCH v3 2/2] clk: davinci: pll-dm355: fix SYSCLKn parent names David Lechner 2018-05-09 15:36 ` David Lechner 2018-05-10 15:30 ` Sekhar Nori 2018-05-10 15:30 ` Sekhar Nori
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.