All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor.dooley@microchip.com>,
	mturquette@baylibre.com, sboyd@kernel.org, aou@eecs.berkeley.edu,
	paul.walmsley@sifive.com, palmer@rivosinc.com,
	a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	robh+dt@kernel.org, krzk+dt@kernel.org
Cc: daire.mcnamara@microchip.com, linux-rtc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 6/9] dt-bindings: rtc: add refclk to mpfs-rtc
Date: Tue, 12 Apr 2022 13:48:10 +0200	[thread overview]
Message-ID: <e202a170-5d94-7484-897a-51718c97eb35@linaro.org> (raw)
In-Reply-To: <20220411085916.941433-7-conor.dooley@microchip.com>

On 11/04/2022 10:59, Conor Dooley wrote:
> The rtc on PolarFire SoC does not use the AHB clock as its reference
> frequency, but rather a 1 MHz refclk that it shares with MTIMER. Add
> this second clock to the binding as a required property.
> 
> Fixes: 4cbcc0d7b397 ("dt-bindings: rtc: add bindings for microchip mpfs rtc")
> Reviewed-by: Daire McNamara <daire.mcnamara@microchip.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/rtc/microchip,mfps-rtc.yaml           | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> index a2e984ea3553..1ffd97dbe6b9 100644
> --- a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> @@ -31,11 +31,18 @@ properties:
>            to that of the RTC's count register.
>  
>    clocks:
> -    maxItems: 1
> +    items:
> +      - description: |
> +          AHB clock
> +      - description: |
> +          Reference clock: divided by the prescaler to create a time-based strobe (typically 1 Hz)
> +          for the calendar counter. By default, the rtc on the PolarFire SoC shares it's reference
> +          with MTIMER so this will be a 1 MHz clock.

Please wrap it at 80-column, it is still preferred coding style. The
same in your patch 4/9.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor.dooley@microchip.com>,
	mturquette@baylibre.com, sboyd@kernel.org, aou@eecs.berkeley.edu,
	paul.walmsley@sifive.com, palmer@rivosinc.com,
	a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	robh+dt@kernel.org, krzk+dt@kernel.org
Cc: daire.mcnamara@microchip.com, linux-rtc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 6/9] dt-bindings: rtc: add refclk to mpfs-rtc
Date: Tue, 12 Apr 2022 13:48:10 +0200	[thread overview]
Message-ID: <e202a170-5d94-7484-897a-51718c97eb35@linaro.org> (raw)
In-Reply-To: <20220411085916.941433-7-conor.dooley@microchip.com>

On 11/04/2022 10:59, Conor Dooley wrote:
> The rtc on PolarFire SoC does not use the AHB clock as its reference
> frequency, but rather a 1 MHz refclk that it shares with MTIMER. Add
> this second clock to the binding as a required property.
> 
> Fixes: 4cbcc0d7b397 ("dt-bindings: rtc: add bindings for microchip mpfs rtc")
> Reviewed-by: Daire McNamara <daire.mcnamara@microchip.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/rtc/microchip,mfps-rtc.yaml           | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> index a2e984ea3553..1ffd97dbe6b9 100644
> --- a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> @@ -31,11 +31,18 @@ properties:
>            to that of the RTC's count register.
>  
>    clocks:
> -    maxItems: 1
> +    items:
> +      - description: |
> +          AHB clock
> +      - description: |
> +          Reference clock: divided by the prescaler to create a time-based strobe (typically 1 Hz)
> +          for the calendar counter. By default, the rtc on the PolarFire SoC shares it's reference
> +          with MTIMER so this will be a 1 MHz clock.

Please wrap it at 80-column, it is still preferred coding style. The
same in your patch 4/9.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

  reply	other threads:[~2022-04-12 11:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  8:59 [PATCH v2 0/9] More PolarFire SoC Fixes for 5.18 Conor Dooley
2022-04-11  8:59 ` Conor Dooley
2022-04-11  8:59 ` [PATCH v2 1/9] clk: microchip: mpfs: fix parents for FIC clocks Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-11  8:59 ` [PATCH v2 2/9] clk: microchip: mpfs: mark CLK_ATHENA as critical Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-11  8:59 ` [PATCH v2 3/9] riscv: dts: microchip: fix usage of fic clocks on mpfs Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-11  8:59 ` [PATCH v2 4/9] dt-bindings: clk: mpfs document msspll dri registers Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-12 11:46   ` Krzysztof Kozlowski
2022-04-12 11:46     ` Krzysztof Kozlowski
2022-04-11  8:59 ` [PATCH v2 5/9] dt-bindings: clk: mpfs: add defines for two new clocks Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-12 11:47   ` Krzysztof Kozlowski
2022-04-12 11:47     ` Krzysztof Kozlowski
2022-04-12 12:04     ` Conor.Dooley
2022-04-12 12:04       ` Conor.Dooley
2022-04-12 12:10       ` Krzysztof Kozlowski
2022-04-12 12:10         ` Krzysztof Kozlowski
2022-04-12 12:26         ` Conor.Dooley
2022-04-12 12:26           ` Conor.Dooley
2022-04-12 17:10           ` Krzysztof Kozlowski
2022-04-12 17:10             ` Krzysztof Kozlowski
2022-04-12 18:29             ` Conor Dooley
2022-04-12 18:29               ` Conor Dooley
2022-04-13  6:44               ` Krzysztof Kozlowski
2022-04-13  6:44                 ` Krzysztof Kozlowski
2022-04-11  8:59 ` [PATCH v2 6/9] dt-bindings: rtc: add refclk to mpfs-rtc Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-12 11:48   ` Krzysztof Kozlowski [this message]
2022-04-12 11:48     ` Krzysztof Kozlowski
2022-04-12 11:50     ` Conor.Dooley
2022-04-12 11:50       ` Conor.Dooley
2022-04-11  8:59 ` [PATCH v2 7/9] clk: microchip: mpfs: re-parent the configurable clocks Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-12 19:14   ` Stephen Boyd
2022-04-12 19:14     ` Stephen Boyd
2022-04-11  8:59 ` [PATCH v2 8/9] clk: microchip: mpfs: add RTCREF clock control Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-11  8:59 ` [PATCH v2 9/9] riscv: dts: microchip: reparent mpfs clocks Conor Dooley
2022-04-11  8:59   ` Conor Dooley
2022-04-11 13:25   ` Conor.Dooley
2022-04-11 13:25     ` Conor.Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e202a170-5d94-7484-897a-51718c97eb35@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=palmer@rivosinc.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.