From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, oss-drivers@netronome.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen A McCamant <smccaman@umn.edu>,
"David S. Miller" <davem@davemloft.net>,
Frederik Lotter <frederik.lotter@netronome.com>,
John Hurley <john.hurley@netronome.com>,
Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>,
Simon Horman <simon.horman@netronome.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs
Date: Fri, 27 Sep 2019 16:06:40 +0200 [thread overview]
Message-ID: <e20e4ea4-72c8-2e2e-1745-309fc6f6a57c@web.de> (raw)
In-Reply-To: <20190925190512.3404-1-navid.emamdoost@gmail.com>
> @@ -433,6 +435,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
> err = nfp_repr_init(app, repr,
> port_id, port, priv->nn->dp.netdev);
> if (err) {
> + kfree(repr_priv);
> nfp_port_free(port);
> nfp_repr_free(repr);
> goto err_reprs_clean;
How do you think about to move common exception handling code
to the end of this function implementation by using another jump target?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
netdev@vger.kernel.org, oss-drivers@netronome.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen A McCamant <smccaman@umn.edu>,
"David S. Miller" <davem@davemloft.net>,
Frederik Lotter <frederik.lotter@netronome.com>,
John Hurley <john.hurley@netronome.com>,
Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>,
Simon Horman <simon.horman@netronome.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs
Date: Fri, 27 Sep 2019 14:06:40 +0000 [thread overview]
Message-ID: <e20e4ea4-72c8-2e2e-1745-309fc6f6a57c@web.de> (raw)
In-Reply-To: <20190925190512.3404-1-navid.emamdoost@gmail.com>
> @@ -433,6 +435,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,
> err = nfp_repr_init(app, repr,
> port_id, port, priv->nn->dp.netdev);
> if (err) {
> + kfree(repr_priv);
> nfp_port_free(port);
> nfp_repr_free(repr);
> goto err_reprs_clean;
How do you think about to move common exception handling code
to the end of this function implementation by using another jump target?
Regards,
Markus
next prev parent reply other threads:[~2019-09-27 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 19:05 [PATCH] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs Navid Emamdoost
2019-09-26 1:22 ` Jakub Kicinski
2019-09-27 14:06 ` Markus Elfring [this message]
2019-09-27 14:06 ` Markus Elfring
2019-09-27 18:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e20e4ea4-72c8-2e2e-1745-309fc6f6a57c@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=frederik.lotter@netronome.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.hurley@netronome.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.