All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sebastian Reichel <sre@kernel.org>,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org
Subject: Re: [PATCHv2] drm/omap: Fix issue with clocks left on after resume
Date: Fri, 7 May 2021 16:26:39 +0300	[thread overview]
Message-ID: <e2181257-4714-e306-1ba8-6b8c9d09807c@ideasonboard.com> (raw)
In-Reply-To: <YJJ9twsxdw2Mi0F6@atomide.com>

On 05/05/2021 14:12, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [210503 12:18]:
>> I think we still fix the dispc related issue too, otherwise the parent
>> child_count will just keep increasing on each suspend. I check that
>> again though.
> 
> After tons more debugging, I found the root cause for the parent child_count
> increasing and posted a patch for it at [0] below.
> 
> This means the $subject patch here can be done later on as clean-up to
> leave out lots of unnecessary PM runtime calls and simplify the system
> suspend :)

Great work, thanks! It's always nice when someone else does the tons of 
debugging ;).

I tested the patch you sent, works fine for me.

While testing I noticed another problem, which happens also without your 
fix: go to suspend with HDMI connected, remove the cable, resume the 
board -> boom. I didn't debug that yet.

  Tomi

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCHv2] drm/omap: Fix issue with clocks left on after resume
Date: Fri, 7 May 2021 16:26:39 +0300	[thread overview]
Message-ID: <e2181257-4714-e306-1ba8-6b8c9d09807c@ideasonboard.com> (raw)
In-Reply-To: <YJJ9twsxdw2Mi0F6@atomide.com>

On 05/05/2021 14:12, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [210503 12:18]:
>> I think we still fix the dispc related issue too, otherwise the parent
>> child_count will just keep increasing on each suspend. I check that
>> again though.
> 
> After tons more debugging, I found the root cause for the parent child_count
> increasing and posted a patch for it at [0] below.
> 
> This means the $subject patch here can be done later on as clean-up to
> leave out lots of unnecessary PM runtime calls and simplify the system
> suspend :)

Great work, thanks! It's always nice when someone else does the tons of 
debugging ;).

I tested the patch you sent, works fine for me.

While testing I noticed another problem, which happens also without your 
fix: go to suspend with HDMI connected, remove the cable, resume the 
board -> boom. I didn't debug that yet.

  Tomi

  reply	other threads:[~2021-05-07 13:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  9:25 [PATCHv2] drm/omap: Fix issue with clocks left on after resume Tony Lindgren
2021-04-28  9:25 ` Tony Lindgren
2021-04-28 14:10 ` Laurent Pinchart
2021-04-28 14:10   ` Laurent Pinchart
2021-04-29  4:46   ` Tony Lindgren
2021-04-29  4:46     ` Tony Lindgren
2021-05-03  8:04     ` Tomi Valkeinen
2021-05-03  8:04       ` Tomi Valkeinen
2021-05-03 10:45       ` Tony Lindgren
2021-05-03 10:45         ` Tony Lindgren
2021-05-03 11:16         ` Tony Lindgren
2021-05-03 11:16           ` Tony Lindgren
2021-05-03 12:17           ` Tony Lindgren
2021-05-03 12:17             ` Tony Lindgren
2021-05-05 11:12             ` Tony Lindgren
2021-05-05 11:12               ` Tony Lindgren
2021-05-07 13:26               ` Tomi Valkeinen [this message]
2021-05-07 13:26                 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2181257-4714-e306-1ba8-6b8c9d09807c@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.