From: Logan Gunthorpe <logang@deltatee.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
Date: Sun, 26 Nov 2017 11:33:35 -0700 [thread overview]
Message-ID: <e22b6039-0696-c9f7-7585-4597c40c1846@deltatee.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1711261912150.2111@hadrien>
On 26/11/17 11:17 AM, Julia Lawall wrote:
> The main limitation that is likely to remain in my script is that
> Coccinelle doesn't always understand ifdefs properly. So
> #ifdef
> printk("xxx");
> #else
> printk("yyy");
> #endif
> pr_cont("zzz");
>
> may give a warning about the first printk.
Yes, that's another clever corner case I didn't think of. My patch will
have the same issue. But that's terrible style[1] and I should hope it's
quite rare.
> 0-day only runs on changed files and only reports on changed code, to
> the best of my understanding, so I don't think it is a problem.
Oh, cool.
Logan
[1]
https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
Date: Sun, 26 Nov 2017 18:33:35 +0000 [thread overview]
Message-ID: <e22b6039-0696-c9f7-7585-4597c40c1846@deltatee.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1711261912150.2111@hadrien>
On 26/11/17 11:17 AM, Julia Lawall wrote:
> The main limitation that is likely to remain in my script is that
> Coccinelle doesn't always understand ifdefs properly. So
> #ifdef
> printk("xxx");
> #else
> printk("yyy");
> #endif
> pr_cont("zzz");
>
> may give a warning about the first printk.
Yes, that's another clever corner case I didn't think of. My patch will
have the same issue. But that's terrible style[1] and I should hope it's
quite rare.
> 0-day only runs on changed files and only reports on changed code, to
> the best of my understanding, so I don't think it is a problem.
Oh, cool.
Logan
[1]
https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation
next prev parent reply other threads:[~2017-11-26 18:33 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 5:40 [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line Logan Gunthorpe
2017-11-26 5:40 ` Logan Gunthorpe
2017-11-26 5:51 ` Julia Lawall
2017-11-26 5:51 ` Julia Lawall
2017-11-26 6:01 ` Joe Perches
2017-11-26 6:01 ` Joe Perches
2017-11-26 17:38 ` Logan Gunthorpe
2017-11-26 17:38 ` Logan Gunthorpe
2017-11-26 22:29 ` Joe Perches
2017-11-26 22:29 ` Joe Perches
[not found] ` <alpine.DEB.2.20.1711262334370.2111@hadrien>
2017-11-27 1:12 ` Joe Perches
2017-11-27 1:12 ` Joe Perches
2017-11-27 6:08 ` Julia Lawall
2017-11-27 6:08 ` Julia Lawall
2017-11-27 9:25 ` Joe Perches
2017-11-27 9:25 ` Joe Perches
2017-11-27 9:32 ` Julia Lawall
2017-11-27 9:32 ` Julia Lawall
2017-11-27 9:42 ` Joe Perches
2017-11-27 9:42 ` Joe Perches
2017-11-27 17:07 ` Logan Gunthorpe
2017-11-27 17:07 ` Logan Gunthorpe
2017-11-27 17:26 ` Joe Perches
2017-11-27 17:26 ` Joe Perches
2017-11-27 17:33 ` Logan Gunthorpe
2017-11-27 17:33 ` Logan Gunthorpe
2017-11-27 17:41 ` Joe Perches
2017-11-27 17:41 ` Joe Perches
2017-11-27 17:42 ` Logan Gunthorpe
2017-11-27 17:42 ` Logan Gunthorpe
2017-11-27 4:00 ` Logan Gunthorpe
2017-11-27 4:00 ` Logan Gunthorpe
2017-11-27 6:11 ` Julia Lawall
2017-11-27 6:11 ` Julia Lawall
2017-11-27 6:27 ` Logan Gunthorpe
2017-11-27 6:27 ` Logan Gunthorpe
2017-11-27 6:34 ` Julia Lawall
2017-11-27 6:34 ` Julia Lawall
2017-11-27 6:40 ` Logan Gunthorpe
2017-11-27 6:40 ` Logan Gunthorpe
2017-11-27 8:28 ` Joe Perches
2017-11-27 8:28 ` Joe Perches
2017-11-27 8:52 ` Julia Lawall
2017-11-27 8:52 ` Julia Lawall
2017-11-27 9:06 ` Joe Perches
2017-11-27 9:06 ` Joe Perches
2017-11-27 16:40 ` Logan Gunthorpe
2017-11-27 16:40 ` Logan Gunthorpe
2017-11-27 17:20 ` Logan Gunthorpe
2017-11-27 17:20 ` Logan Gunthorpe
2017-11-27 17:28 ` Joe Perches
2017-11-27 17:28 ` Joe Perches
2017-11-27 17:35 ` Logan Gunthorpe
2017-11-27 17:35 ` Logan Gunthorpe
2017-11-27 17:42 ` Joe Perches
2017-11-27 17:42 ` Joe Perches
2017-11-27 17:44 ` Logan Gunthorpe
2017-11-27 17:44 ` Logan Gunthorpe
2017-11-27 18:57 ` Joe Perches
2017-11-27 18:57 ` Joe Perches
2017-11-27 19:58 ` Logan Gunthorpe
2017-11-27 19:58 ` Logan Gunthorpe
2017-11-27 20:49 ` Julia Lawall
2017-11-27 20:49 ` Julia Lawall
2017-11-27 22:56 ` Logan Gunthorpe
2017-11-27 22:56 ` Logan Gunthorpe
2017-11-28 0:15 ` Joe Perches
2017-11-28 0:15 ` Joe Perches
2017-11-26 16:55 ` Logan Gunthorpe
2017-11-26 16:55 ` Logan Gunthorpe
2017-11-26 17:09 ` Julia Lawall
2017-11-26 17:09 ` Julia Lawall
2017-11-26 17:47 ` Logan Gunthorpe
2017-11-26 17:47 ` Logan Gunthorpe
2017-11-26 18:17 ` Julia Lawall
2017-11-26 18:17 ` Julia Lawall
2017-11-26 18:33 ` Logan Gunthorpe [this message]
2017-11-26 18:33 ` Logan Gunthorpe
2017-11-27 1:35 ` Joe Perches
2017-11-27 1:35 ` Joe Perches
2017-11-27 6:40 ` Julia Lawall
2017-11-27 6:40 ` Julia Lawall
2017-11-27 6:42 ` Julia Lawall
2017-11-27 6:42 ` Julia Lawall
2017-11-27 6:53 ` Logan Gunthorpe
2017-11-27 6:53 ` Logan Gunthorpe
2017-11-27 6:57 ` Julia Lawall
2017-11-27 6:57 ` Julia Lawall
2017-11-27 9:03 ` Joe Perches
2017-11-27 9:03 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e22b6039-0696-c9f7-7585-4597c40c1846@deltatee.com \
--to=logang@deltatee.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.