All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows
@ 2020-03-19 14:06 Juha-Pekka Heikkila
  2020-03-19 14:53 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Avoid CRC buffer overflows (rev2) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Juha-Pekka Heikkila @ 2020-03-19 14:06 UTC (permalink / raw)
  To: igt-dev

Change test initialization so CRC buffer will not become full
on slower machines.

v2: don't waste time by draining crcs unnecessarily.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_multiple.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 255cd34a..3c503c26 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -121,8 +121,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
 	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
 	igt_skip_on(ret != 0);
 
-	igt_pipe_crc_start(data->pipe_crc);
-	igt_pipe_crc_get_single(data->pipe_crc, &data->ref_crc);
+	igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
 }
 
 static void
@@ -330,6 +329,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		 igt_output_name(output), kmstest_pipe_name(pipe), c,
 		 info, opt.seed);
 
+	igt_pipe_crc_start(data->pipe_crc);
+
 	i = 0;
 	while (i < iterations || loop_forever) {
 		/* randomize planes and set up the holes */
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows
@ 2020-03-18 20:16 Juha-Pekka Heikkila
  0 siblings, 0 replies; 7+ messages in thread
From: Juha-Pekka Heikkila @ 2020-03-18 20:16 UTC (permalink / raw)
  To: igt-dev

Change test initialization so CRC buffer will not become full
on slower machines.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_multiple.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 255cd34a..78769933 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -121,8 +121,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
 	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
 	igt_skip_on(ret != 0);
 
-	igt_pipe_crc_start(data->pipe_crc);
-	igt_pipe_crc_get_single(data->pipe_crc, &data->ref_crc);
+	igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
 }
 
 static void
@@ -257,6 +256,7 @@ prepare_planes(data_t *data, enum pipe pipe_id, color_t *color,
 
 		igt_plane_set_position(data->plane[i], x[i], y[i]);
 		igt_plane_set_fb(data->plane[i], &data->fb[i]);
+		igt_pipe_crc_drain(data->pipe_crc);
 	}
 
 	/* primary plane */
@@ -330,6 +330,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		 igt_output_name(output), kmstest_pipe_name(pipe), c,
 		 info, opt.seed);
 
+	igt_pipe_crc_start(data->pipe_crc);
+
 	i = 0;
 	while (i < iterations || loop_forever) {
 		/* randomize planes and set up the holes */
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-20 21:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 14:06 [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows Juha-Pekka Heikkila
2020-03-19 14:53 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Avoid CRC buffer overflows (rev2) Patchwork
2020-03-19 15:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-03-20 13:03 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows Kahola, Mika
2020-03-20 15:53 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Avoid CRC buffer overflows (rev3) Patchwork
2020-03-20 21:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-03-18 20:16 [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows Juha-Pekka Heikkila

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.