* [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
@ 2021-01-05 11:25 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:25 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Venkata Ramana Nayana, Chris Wilson
Disable banning as we deliberately inject GPU resets to test isolation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
---
tests/i915/gem_ctx_isolation.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
index 58a35b487..4f1742685 100644
--- a/tests/i915/gem_ctx_isolation.c
+++ b/tests/i915/gem_ctx_isolation.c
@@ -762,10 +762,21 @@ static void isolation(int fd,
#define S4 (4 << 8)
#define SLEEP_MASK (0xf << 8)
+static uint32_t create_reset_context(int i915)
+{
+ struct drm_i915_gem_context_param param = {
+ .ctx_id = gem_context_clone_with_engines(i915, 0),
+ .param = I915_CONTEXT_PARAM_BANNABLE,
+ };
+
+ gem_context_set_param(i915, ¶m);
+ return param.ctx_id;
+}
+
static void inject_reset_context(int fd, const struct intel_execution_engine2 *e)
{
struct igt_spin_factory opts = {
- .ctx = gem_context_clone_with_engines(fd, 0),
+ .ctx = create_reset_context(fd),
.engine = e->flags,
.flags = IGT_SPIN_FAST,
};
--
2.30.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
@ 2021-01-05 11:25 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:25 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Venkata Ramana Nayana, Chris Wilson
Disable banning as we deliberately inject GPU resets to test isolation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
---
tests/i915/gem_ctx_isolation.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
index 58a35b487..4f1742685 100644
--- a/tests/i915/gem_ctx_isolation.c
+++ b/tests/i915/gem_ctx_isolation.c
@@ -762,10 +762,21 @@ static void isolation(int fd,
#define S4 (4 << 8)
#define SLEEP_MASK (0xf << 8)
+static uint32_t create_reset_context(int i915)
+{
+ struct drm_i915_gem_context_param param = {
+ .ctx_id = gem_context_clone_with_engines(i915, 0),
+ .param = I915_CONTEXT_PARAM_BANNABLE,
+ };
+
+ gem_context_set_param(i915, ¶m);
+ return param.ctx_id;
+}
+
static void inject_reset_context(int fd, const struct intel_execution_engine2 *e)
{
struct igt_spin_factory opts = {
- .ctx = gem_context_clone_with_engines(fd, 0),
+ .ctx = create_reset_context(fd),
.engine = e->flags,
.flags = IGT_SPIN_FAST,
};
--
2.30.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH i-g-t 2/2] i915/gem_ctx_exec: Protect norecovery from being banned
2021-01-05 11:25 ` [igt-dev] " Chris Wilson
@ 2021-01-05 11:25 ` Chris Wilson
-1 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:25 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Venkata Ramana Nayana, Chris Wilson
Disable banning as we deliberately inject GPU resets to test norecovery
handling.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
---
tests/i915/gem_ctx_exec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
index 897761856..c80a98473 100644
--- a/tests/i915/gem_ctx_exec.c
+++ b/tests/i915/gem_ctx_exec.c
@@ -171,14 +171,16 @@ static void norecovery(int i915)
for (int pass = 1; pass >= 0; pass--) {
struct drm_i915_gem_context_param param = {
.ctx_id = gem_context_create(i915),
- .param = I915_CONTEXT_PARAM_RECOVERABLE,
- .value = pass,
+ .param = I915_CONTEXT_PARAM_BANNABLE,
};
int expect = pass == 0 ? -EIO : 0;
igt_spin_t *spin;
gem_context_set_param(i915, ¶m);
+ param.param = I915_CONTEXT_PARAM_RECOVERABLE;
+ param.value = pass;
+ gem_context_set_param(i915, ¶m);
param.value = !pass;
gem_context_get_param(i915, ¶m);
igt_assert_eq(param.value, pass);
--
2.30.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] i915/gem_ctx_exec: Protect norecovery from being banned
@ 2021-01-05 11:25 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:25 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Venkata Ramana Nayana, Chris Wilson
Disable banning as we deliberately inject GPU resets to test norecovery
handling.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
---
tests/i915/gem_ctx_exec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
index 897761856..c80a98473 100644
--- a/tests/i915/gem_ctx_exec.c
+++ b/tests/i915/gem_ctx_exec.c
@@ -171,14 +171,16 @@ static void norecovery(int i915)
for (int pass = 1; pass >= 0; pass--) {
struct drm_i915_gem_context_param param = {
.ctx_id = gem_context_create(i915),
- .param = I915_CONTEXT_PARAM_RECOVERABLE,
- .value = pass,
+ .param = I915_CONTEXT_PARAM_BANNABLE,
};
int expect = pass == 0 ? -EIO : 0;
igt_spin_t *spin;
gem_context_set_param(i915, ¶m);
+ param.param = I915_CONTEXT_PARAM_RECOVERABLE;
+ param.value = pass;
+ gem_context_set_param(i915, ¶m);
param.value = !pass;
gem_context_get_param(i915, ¶m);
igt_assert_eq(param.value, pass);
--
2.30.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
2021-01-05 11:25 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2021-01-05 13:24 ` Patchwork
-1 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-01-05 13:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 3231 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
URL : https://patchwork.freedesktop.org/series/85500/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9545 -> IGTPW_5356
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5356 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5356, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5356:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@active:
- fi-snb-2600: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9545/fi-snb-2600/igt@i915_selftest@live@active.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/fi-snb-2600/igt@i915_selftest@live@active.html
Known issues
------------
Here are the changes found in IGTPW_5356 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@query-info:
- fi-tgl-y: NOTRUN -> [SKIP][3] ([fdo#109315] / [i915#2575])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/fi-tgl-y/igt@amdgpu/amd_basic@query-info.html
* igt@fbdev@read:
- fi-tgl-y: [PASS][4] -> [DMESG-WARN][5] ([i915#402])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9545/fi-tgl-y/igt@fbdev@read.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/fi-tgl-y/igt@fbdev@read.html
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][6] ([i915#1161] / [i915#262]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9545/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (42 -> 35)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-dg1-1 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5942 -> IGTPW_5356
CI-20190529: 20190529
CI_DRM_9545: a412bacbe58bb98252a6b55f6390857a20689fc6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5356: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/index.html
IGT_5942: e14e76a87c44c684ec958b391b030bb549254f88 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5356/index.html
[-- Attachment #1.2: Type: text/html, Size: 3914 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
2021-01-05 11:25 ` [igt-dev] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2021-01-06 6:22 ` Nayana, Venkata Ramana
-1 siblings, 0 replies; 8+ messages in thread
From: Nayana, Venkata Ramana @ 2021-01-06 6:22 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
> -----Original Message-----
> From: Chris Wilson <chris@chris-wilson.co.uk>
> Sent: Tuesday, January 5, 2021 4:56 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: igt-dev@lists.freedesktop.org; Chris Wilson <chris@chris-wilson.co.uk>;
> Nayana, Venkata Ramana <venkata.ramana.nayana@intel.com>
> Subject: [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect
> inject_reset_context() from banning
>
> Disable banning as we deliberately inject GPU resets to test isolation.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
> ---
> tests/i915/gem_ctx_isolation.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index 58a35b487..4f1742685 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -762,10 +762,21 @@ static void isolation(int fd, #define S4 (4 << 8)
> #define SLEEP_MASK (0xf << 8)
>
> +static uint32_t create_reset_context(int i915) {
> + struct drm_i915_gem_context_param param = {
> + .ctx_id = gem_context_clone_with_engines(i915, 0),
> + .param = I915_CONTEXT_PARAM_BANNABLE,
> + };
> +
> + gem_context_set_param(i915, ¶m);
> + return param.ctx_id;
> +}
> +
> static void inject_reset_context(int fd, const struct intel_execution_engine2
> *e) {
> struct igt_spin_factory opts = {
> - .ctx = gem_context_clone_with_engines(fd, 0),
> + .ctx = create_reset_context(fd),
> .engine = e->flags,
> .flags = IGT_SPIN_FAST,
> };
> --
> 2.30.0
Reviewed-by: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
@ 2021-01-05 11:19 Chris Wilson
2021-01-05 11:21 ` Chris Wilson
0 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:19 UTC (permalink / raw)
To: intel-gfx; +Cc: Venkata Ramana Nayana, Chris Wilson
Disable banning as we deliberately inject GPU resets to test isolation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
---
tests/i915/gem_ctx_isolation.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
index 58a35b487..4f1742685 100644
--- a/tests/i915/gem_ctx_isolation.c
+++ b/tests/i915/gem_ctx_isolation.c
@@ -762,10 +762,21 @@ static void isolation(int fd,
#define S4 (4 << 8)
#define SLEEP_MASK (0xf << 8)
+static uint32_t create_reset_context(int i915)
+{
+ struct drm_i915_gem_context_param param = {
+ .ctx_id = gem_context_clone_with_engines(i915, 0),
+ .param = I915_CONTEXT_PARAM_BANNABLE,
+ };
+
+ gem_context_set_param(i915, ¶m);
+ return param.ctx_id;
+}
+
static void inject_reset_context(int fd, const struct intel_execution_engine2 *e)
{
struct igt_spin_factory opts = {
- .ctx = gem_context_clone_with_engines(fd, 0),
+ .ctx = create_reset_context(fd),
.engine = e->flags,
.flags = IGT_SPIN_FAST,
};
--
2.30.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning
2021-01-05 11:19 Chris Wilson
@ 2021-01-05 11:21 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2021-01-05 11:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Venkata Ramana Nayana
Quoting Chris Wilson (2021-01-05 11:19:26)
> Disable banning as we deliberately inject GPU resets to test isolation.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Venkata Ramana Nayana <venkata.ramana.nayana@intel.com>
> ---
> tests/i915/gem_ctx_isolation.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_isolation.c b/tests/i915/gem_ctx_isolation.c
> index 58a35b487..4f1742685 100644
> --- a/tests/i915/gem_ctx_isolation.c
> +++ b/tests/i915/gem_ctx_isolation.c
> @@ -762,10 +762,21 @@ static void isolation(int fd,
> #define S4 (4 << 8)
> #define SLEEP_MASK (0xf << 8)
>
> +static uint32_t create_reset_context(int i915)
> +{
> + struct drm_i915_gem_context_param param = {
> + .ctx_id = gem_context_clone_with_engines(i915, 0),
An alternative is that we pass CLONE_FLAGS to
gem_context_clone_with_engines(). Danger is context_clone_with_engines
is widely used.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-06 6:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 11:25 [Intel-gfx] [PATCH i-g-t 1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning Chris Wilson
2021-01-05 11:25 ` [igt-dev] " Chris Wilson
2021-01-05 11:25 ` [Intel-gfx] [PATCH i-g-t 2/2] i915/gem_ctx_exec: Protect norecovery from being banned Chris Wilson
2021-01-05 11:25 ` [igt-dev] " Chris Wilson
2021-01-05 13:24 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] i915/gem_ctx_isolation: Protect inject_reset_context() from banning Patchwork
2021-01-06 6:22 ` [Intel-gfx] [PATCH i-g-t 1/2] " Nayana, Venkata Ramana
-- strict thread matches above, loose matches on Subject: below --
2021-01-05 11:19 Chris Wilson
2021-01-05 11:21 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.