* [PATCH] nvme-fabrics: decode host pathing error for connect
@ 2021-05-21 8:23 Hannes Reinecke
2021-05-21 17:27 ` Himanshu Madhani
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Hannes Reinecke @ 2021-05-21 8:23 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Sagi Grimberg, Keith Busch, linux-nvme, Hannes Reinecke
Add an additional decoding for 'host pathing error' during connect.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/host/fabrics.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index a2bb7fc63a73..34a84d2086c7 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -336,6 +336,11 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
cmd->connect.recfmt);
break;
+ case NVME_SC_HOST_PATH_ERROR:
+ dev_err(ctrl->device,
+ "Connect command failed: host path error\n");
+ break;
+
default:
dev_err(ctrl->device,
"Connect command failed, error wo/DNR bit: %d\n",
--
2.29.2
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-fabrics: decode host pathing error for connect
2021-05-21 8:23 [PATCH] nvme-fabrics: decode host pathing error for connect Hannes Reinecke
@ 2021-05-21 17:27 ` Himanshu Madhani
2021-05-21 20:18 ` Sagi Grimberg
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Himanshu Madhani @ 2021-05-21 17:27 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Sagi Grimberg, Keith Busch, linux-nvme
On 5/21/21 3:23 AM, Hannes Reinecke wrote:
> Add an additional decoding for 'host pathing error' during connect.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/nvme/host/fabrics.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
> index a2bb7fc63a73..34a84d2086c7 100644
> --- a/drivers/nvme/host/fabrics.c
> +++ b/drivers/nvme/host/fabrics.c
> @@ -336,6 +336,11 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
> cmd->connect.recfmt);
> break;
>
> + case NVME_SC_HOST_PATH_ERROR:
> + dev_err(ctrl->device,
> + "Connect command failed: host path error\n");
> + break;
> +
> default:
> dev_err(ctrl->device,
> "Connect command failed, error wo/DNR bit: %d\n",
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] nvme-fabrics: decode host pathing error for connect
2021-05-21 8:23 [PATCH] nvme-fabrics: decode host pathing error for connect Hannes Reinecke
2021-05-21 17:27 ` Himanshu Madhani
@ 2021-05-21 20:18 ` Sagi Grimberg
2021-05-21 21:32 ` Chaitanya Kulkarni
2021-05-25 7:25 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Sagi Grimberg @ 2021-05-21 20:18 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Keith Busch, linux-nvme
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme-fabrics: decode host pathing error for connect
2021-05-21 8:23 [PATCH] nvme-fabrics: decode host pathing error for connect Hannes Reinecke
2021-05-21 17:27 ` Himanshu Madhani
2021-05-21 20:18 ` Sagi Grimberg
@ 2021-05-21 21:32 ` Chaitanya Kulkarni
2021-05-25 7:25 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2021-05-21 21:32 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Sagi Grimberg, Keith Busch, linux-nvme
On 5/21/21 01:30, Hannes Reinecke wrote:
> Add an additional decoding for 'host pathing error' during connect.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] nvme-fabrics: decode host pathing error for connect
2021-05-21 8:23 [PATCH] nvme-fabrics: decode host pathing error for connect Hannes Reinecke
` (2 preceding siblings ...)
2021-05-21 21:32 ` Chaitanya Kulkarni
@ 2021-05-25 7:25 ` Christoph Hellwig
3 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2021-05-25 7:25 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme
Thanks,
applied to nvme-5.13.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-25 7:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 8:23 [PATCH] nvme-fabrics: decode host pathing error for connect Hannes Reinecke
2021-05-21 17:27 ` Himanshu Madhani
2021-05-21 20:18 ` Sagi Grimberg
2021-05-21 21:32 ` Chaitanya Kulkarni
2021-05-25 7:25 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.