* [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node
@ 2021-12-09 20:50 Oleksandr Tyshchenko
2021-12-10 1:14 ` Stefano Stabellini
2021-12-10 9:00 ` Julien Grall
0 siblings, 2 replies; 4+ messages in thread
From: Oleksandr Tyshchenko @ 2021-12-09 20:50 UTC (permalink / raw)
To: xen-devel
Cc: Oleksandr Tyshchenko, Stefano Stabellini, Julien Grall,
Volodymyr Babchuk, Bertrand Marquis
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Remove the following sentence:
"This property is unnecessary when booting Dom0 using ACPI."
for "reg" and "interrupts" properties as the initialization is not
done via device-tree "hypervisor" node in that case anyway.
Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
---
docs/misc/arm/device-tree/guest.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
index c115751..2b974bb 100644
--- a/docs/misc/arm/device-tree/guest.txt
+++ b/docs/misc/arm/device-tree/guest.txt
@@ -15,11 +15,9 @@ the following properties:
or equal to gnttab_max_grant_frames()).
Regions 1...N are extended regions (unused address space) for mapping foreign
GFNs and grants, they might be absent if there is nothing to expose.
- This property is unnecessary when booting Dom0 using ACPI.
- interrupts: the interrupt used by Xen to inject event notifications.
A GIC node is also required.
- This property is unnecessary when booting Dom0 using ACPI.
To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
under /hypervisor with following parameters:
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node
2021-12-09 20:50 [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node Oleksandr Tyshchenko
@ 2021-12-10 1:14 ` Stefano Stabellini
2021-12-10 9:00 ` Julien Grall
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2021-12-10 1:14 UTC (permalink / raw)
To: Oleksandr Tyshchenko
Cc: xen-devel, Oleksandr Tyshchenko, Stefano Stabellini,
Julien Grall, Volodymyr Babchuk, Bertrand Marquis
On Thu, 9 Dec 2021, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Remove the following sentence:
> "This property is unnecessary when booting Dom0 using ACPI."
> for "reg" and "interrupts" properties as the initialization is not
> done via device-tree "hypervisor" node in that case anyway.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> docs/misc/arm/device-tree/guest.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
> index c115751..2b974bb 100644
> --- a/docs/misc/arm/device-tree/guest.txt
> +++ b/docs/misc/arm/device-tree/guest.txt
> @@ -15,11 +15,9 @@ the following properties:
> or equal to gnttab_max_grant_frames()).
> Regions 1...N are extended regions (unused address space) for mapping foreign
> GFNs and grants, they might be absent if there is nothing to expose.
> - This property is unnecessary when booting Dom0 using ACPI.
>
> - interrupts: the interrupt used by Xen to inject event notifications.
> A GIC node is also required.
> - This property is unnecessary when booting Dom0 using ACPI.
>
> To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
> under /hypervisor with following parameters:
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node
2021-12-09 20:50 [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node Oleksandr Tyshchenko
2021-12-10 1:14 ` Stefano Stabellini
@ 2021-12-10 9:00 ` Julien Grall
2021-12-10 9:20 ` Oleksandr
1 sibling, 1 reply; 4+ messages in thread
From: Julien Grall @ 2021-12-10 9:00 UTC (permalink / raw)
To: Oleksandr Tyshchenko, xen-devel
Cc: Oleksandr Tyshchenko, Stefano Stabellini, Volodymyr Babchuk,
Bertrand Marquis
Hi Oleksandr,
On 09/12/2021 20:50, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>
> Remove the following sentence:
> "This property is unnecessary when booting Dom0 using ACPI."
> for "reg" and "interrupts" properties as the initialization is not
> done via device-tree "hypervisor" node in that case anyway.
Why do you think that? On ACPI, the hypervisor node is used to discover
whether the OS is running on top of Xen (see [1]).
For dom0, Xen will actually create the hypervisor node with the
compatible property and the uefi bits (see [2]).
The properties "regs" and "interrupts" are not created for ACPI and
therefore this should be mentioned in the Device-Tree bindings.
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> ---
> docs/misc/arm/device-tree/guest.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/docs/misc/arm/device-tree/guest.txt b/docs/misc/arm/device-tree/guest.txt
> index c115751..2b974bb 100644
> --- a/docs/misc/arm/device-tree/guest.txt
> +++ b/docs/misc/arm/device-tree/guest.txt
> @@ -15,11 +15,9 @@ the following properties:
> or equal to gnttab_max_grant_frames()).
> Regions 1...N are extended regions (unused address space) for mapping foreign
> GFNs and grants, they might be absent if there is nothing to expose.
> - This property is unnecessary when booting Dom0 using ACPI.
>
> - interrupts: the interrupt used by Xen to inject event notifications.
> A GIC node is also required.
> - This property is unnecessary when booting Dom0 using ACPI.
>
> To support UEFI on Xen ARM virtual platforms, Xen populates the FDT "uefi" node
> under /hypervisor with following parameters:
Cheers,
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/xen/enlighten.c#n253
[2]
https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/acpi/domain_build.c;h=bbdc90f92c003c0c6d0f0b0290a1776336224719;hb=HEAD#l90
--
Julien Grall
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node
2021-12-10 9:00 ` Julien Grall
@ 2021-12-10 9:20 ` Oleksandr
0 siblings, 0 replies; 4+ messages in thread
From: Oleksandr @ 2021-12-10 9:20 UTC (permalink / raw)
To: Julien Grall
Cc: xen-devel, Oleksandr Tyshchenko, Stefano Stabellini,
Volodymyr Babchuk, Bertrand Marquis
On 10.12.21 11:00, Julien Grall wrote:
> Hi Oleksandr,
Hi Julien
>
> On 09/12/2021 20:50, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Remove the following sentence:
>> "This property is unnecessary when booting Dom0 using ACPI."
>> for "reg" and "interrupts" properties as the initialization is not
>> done via device-tree "hypervisor" node in that case anyway.
>
> Why do you think that? On ACPI, the hypervisor node is used to
> discover whether the OS is running on top of Xen (see [1]).
>
> For dom0, Xen will actually create the hypervisor node with the
> compatible property and the uefi bits (see [2]).
>
> The properties "regs" and "interrupts" are not created for ACPI and
> therefore this should be mentioned in the Device-Tree bindings.
You are right. I missed that fact. Current patch is not needed in this case.
>
>
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> ---
>> docs/misc/arm/device-tree/guest.txt | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/docs/misc/arm/device-tree/guest.txt
>> b/docs/misc/arm/device-tree/guest.txt
>> index c115751..2b974bb 100644
>> --- a/docs/misc/arm/device-tree/guest.txt
>> +++ b/docs/misc/arm/device-tree/guest.txt
>> @@ -15,11 +15,9 @@ the following properties:
>> or equal to gnttab_max_grant_frames()).
>> Regions 1...N are extended regions (unused address space) for
>> mapping foreign
>> GFNs and grants, they might be absent if there is nothing to expose.
>> - This property is unnecessary when booting Dom0 using ACPI.
>> - interrupts: the interrupt used by Xen to inject event
>> notifications.
>> A GIC node is also required.
>> - This property is unnecessary when booting Dom0 using ACPI.
>> To support UEFI on Xen ARM virtual platforms, Xen populates the
>> FDT "uefi" node
>> under /hypervisor with following parameters:
>
> Cheers,
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/xen/enlighten.c#n253
>
> [2]
> https://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/arch/arm/acpi/domain_build.c;h=bbdc90f92c003c0c6d0f0b0290a1776336224719;hb=HEAD#l90
>
--
Regards,
Oleksandr Tyshchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-10 9:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 20:50 [PATCH] arm/docs: Drop mentioning of ACPI for properties under "hypervisor" node Oleksandr Tyshchenko
2021-12-10 1:14 ` Stefano Stabellini
2021-12-10 9:00 ` Julien Grall
2021-12-10 9:20 ` Oleksandr
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.