* [PATCH 1/2] xilinx: zynqmp: Add missing prototype for zynqmp_mmio_write
2023-02-21 7:03 [PATCH 0/2] Fix sparse warnings Ashok Reddy Soma
@ 2023-02-21 7:03 ` Ashok Reddy Soma
2023-02-21 7:03 ` [PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order Ashok Reddy Soma
1 sibling, 0 replies; 4+ messages in thread
From: Ashok Reddy Soma @ 2023-02-21 7:03 UTC (permalink / raw)
To: u-boot
Cc: michal.simek, peng.fan, jh80.chung, jagan, sjg, alpernebiyasak,
nathan.morrison, git, Algapally Santosh Sagar, Ashok Reddy Soma
From: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Add missing prototype to fix the sparse warning, warning: no
previous prototype for 'zynqmp_mmio_write' [-Wmissing-prototypes].
Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
---
arch/arm/mach-versal-net/include/mach/sys_proto.h | 7 +------
arch/arm/mach-versal/include/mach/sys_proto.h | 6 +-----
drivers/mmc/zynq_sdhci.c | 1 +
drivers/spi/zynqmp_gqspi.c | 5 +++++
4 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-versal-net/include/mach/sys_proto.h b/arch/arm/mach-versal-net/include/mach/sys_proto.h
index 5bba9030f2..a20cf02712 100644
--- a/arch/arm/mach-versal-net/include/mach/sys_proto.h
+++ b/arch/arm/mach-versal-net/include/mach/sys_proto.h
@@ -8,9 +8,4 @@
void mem_map_fill(void);
-static inline int zynqmp_mmio_write(const u32 address, const u32 mask,
- const u32 value)
-{
- BUILD_BUG();
- return -EINVAL;
-}
+int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value);
diff --git a/arch/arm/mach-versal/include/mach/sys_proto.h b/arch/arm/mach-versal/include/mach/sys_proto.h
index 8e5712e0c9..3f01508ecb 100644
--- a/arch/arm/mach-versal/include/mach/sys_proto.h
+++ b/arch/arm/mach-versal/include/mach/sys_proto.h
@@ -13,8 +13,4 @@ enum {
void tcm_init(u8 mode);
void mem_map_fill(void);
-static inline int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value)
-{
- BUILD_BUG();
- return -EINVAL;
-}
+int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value);
diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
index 8b559d8a7a..9dc310663f 100644
--- a/drivers/mmc/zynq_sdhci.c
+++ b/drivers/mmc/zynq_sdhci.c
@@ -14,6 +14,7 @@
#include "mmc_private.h"
#include <log.h>
#include <reset.h>
+#include <asm/arch/sys_proto.h>
#include <dm/device_compat.h>
#include <linux/err.h>
#include <linux/libfdt.h>
diff --git a/drivers/spi/zynqmp_gqspi.c b/drivers/spi/zynqmp_gqspi.c
index 335b458cb9..c4aee279aa 100644
--- a/drivers/spi/zynqmp_gqspi.c
+++ b/drivers/spi/zynqmp_gqspi.c
@@ -183,6 +183,11 @@ struct zynqmp_qspi_priv {
const struct spi_mem_op *op;
};
+__weak int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value)
+{
+ return 0;
+}
+
static int zynqmp_qspi_of_to_plat(struct udevice *bus)
{
struct zynqmp_qspi_plat *plat = dev_get_plat(bus);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order
2023-02-21 7:03 [PATCH 0/2] Fix sparse warnings Ashok Reddy Soma
2023-02-21 7:03 ` [PATCH 1/2] xilinx: zynqmp: Add missing prototype for zynqmp_mmio_write Ashok Reddy Soma
@ 2023-02-21 7:03 ` Ashok Reddy Soma
2023-02-21 7:51 ` Michal Simek
1 sibling, 1 reply; 4+ messages in thread
From: Ashok Reddy Soma @ 2023-02-21 7:03 UTC (permalink / raw)
To: u-boot
Cc: michal.simek, peng.fan, jh80.chung, jagan, sjg, alpernebiyasak,
nathan.morrison, git, Algapally Santosh Sagar, Ashok Reddy Soma
From: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Add missing prototype to fix the sparse warning, warning: no
previous prototype for 'board_boot_order' [-Wmissing-prototypes].
Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
---
arch/arm/mach-zynqmp/include/mach/sys_proto.h | 1 +
common/spl/spl.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/mach-zynqmp/include/mach/sys_proto.h b/arch/arm/mach-zynqmp/include/mach/sys_proto.h
index c6733ed1bb..0f648c47a3 100644
--- a/arch/arm/mach-zynqmp/include/mach/sys_proto.h
+++ b/arch/arm/mach-zynqmp/include/mach/sys_proto.h
@@ -51,6 +51,7 @@ unsigned int zynqmp_get_silicon_version(void);
int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value);
int zynqmp_mmio_read(const u32 address, u32 *value);
+void board_boot_order(u32 *spl_boot_list);
void initialize_tcm(bool mode);
void mem_map_fill(void);
#if defined(CONFIG_SYS_MEM_RSVD_FOR_MMU) || defined(CONFIG_DEFINE_TCM_OCM_MMAP)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index a630e79866..6e5f326481 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -20,6 +20,7 @@
#include <serial.h>
#include <spl.h>
#include <system-constants.h>
+#include <asm/arch/sys_proto.h>
#include <asm/global_data.h>
#include <asm-generic/gpio.h>
#include <asm/u-boot.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread